Issues in app.js - Fixed Issues - Inspection of "少量重构" - Equim-chan/csu-ems-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b5efe9...e20821 )

by Equim

created 2017-01-17 07:14 UTC

app.js (2 issues)

Labels

Best Practice 2

Severity

Minor 2

/* TODO
 * 完善异常处理
 * 建立用户名-Cookie数据库
 */

'use strict';

var express    = require('express'),
    superagent = require('superagent'),
    cheerio    = require('cheerio'),
    escaper    = require('true-html-escape'),
    colors     = require('colors'),
    program    = require('commander'),
    Date       = require('./lib/Date.js'),
    access     = require('./lib/access.js');

program
    .option('-h, --help')
    .option('-v, --version')
    .option('-p, --port [n]', parseInt)
    .option('-f, --fullLog')
    .parse(process.argv);

// 别问我为什么这里逻辑这么奇怪……测试的结果确实是这样的啊hhh
if (!program.help || !program.version) {
    console.log(('CSUEMS API v2.0.3').rainbow);
    console.log(('by The Liberators').rainbow);
    if (!program.help) {
        console.log('Preparation:');
        console.log('  \\\\This section is WIP\\\\');
        console.log('\nUsage:');
        console.log('  npm start [-- <options...>]');
        console.log('\nOptions:');
        console.log('  -h, --help          print this message and exit.');
        console.log('  -v, --version       print the version and exit.');
        console.log('  -f, --fullLog       enable full log, by default only errors are logged.');
        console.log('  -p, --port [value]  specify a port to listen, 2333 by default.');
        console.log('\nExamples:');
        console.log('  $ npm start -p 43715                  # listening to 43715');
        console.log('  $ forever start app.js                # deploy with forever as daemon (root access recommended)');
        console.log('  $ pm2 start -i 0 -n "csuapi" app.js   # deploy with pm2 as daemon  (root access recommended)');
    }
    process.exit(0);
}

const timeStamp = () => new Date().format('[MM-dd hh:mm:ss] '),
      // 以系统时间获取当前学期
      getSem = () => {
          let now = new Date();
          let month = now.getMonth();
          let year = now.getFullYear();
          if (month === 0) {
              return (year - 1) + '-' + year + '-1';
          } else if (month <= 6) {
              return (year - 1) + '-' + year + '-2';
          } else {
              return year + '-' + (year + 1) + '-1';
          }
      },
      port = program.port || 2333,
      fullLog = program.fullLog;

var app = express();

// 查成绩API，通过GET传入用户名和密码
app.get('/grades', function (req, res, next) {
    if (!req.query.id || !req.query.pwd || (req.query.sem && !(/^20\d{2}-20\d{2}-[1-2]$/).test(req.query.sem))) {
        res.send({ error: "参数不正确" });
        return;
    }
    if (fullLog) {
        var start = new Date();
        console.log((timeStamp() + 'Started to query the grades: ').cyan + req.query.id.yellow);
    }
    access.login(req.query.id, req.query.pwd, res, function (headers, ires) {
        fullLog && console.log((timeStamp() + 'Successfully logged in.').green);

        var ret = {};
        var $ = cheerio.load(ires.text);

        ret.name = escaper.unescape($('.block1text').html()).match(/姓名：.+</)[0].substring(3).replace(/</, '');
        ret.id = req.query.id;

        // 实际上xnxq01id为空的时候和GET这个URL的效果是一样的，都是查询所有学期
        superagent
            .post('http://csujwc.its.csu.edu.cn/jsxsd/kscj/yscjcx_list')
            .set(headers)
            .type('form')
            .send({
                xnxq01id: req.query.sem
            })
            .end(function (err, iires) {
                if (err) {
                    console.log((timeStamp() + 'Failed to get grades page\n' + err.stack).red);
                    res.send({ error: '无法进入成绩页面' });
                    return next(err);
                }
                fullLog && console.log((timeStamp() + 'Successfully entered grades page.').green);

                $ = cheerio.load(iires.text);
                
                ret.grades = {};
                ret.failed = {};

                // 获取成绩列表
                $('#dataList tr').each(function (index) {
                    if (index === 0) {
                        return;
                    }
                    let element = $(this).find('td');
                    let title = escaper.unescape(element.eq(3).text().match(/].+$/)[0].substring(1));

                    let item = {};
                    item.sem = escaper.unescape(element.eq(2).text());
                    item.regular = escaper.unescape(element.eq(4).text());
                    item.exam = escaper.unescape(element.eq(5).text());
                    item.overall = escaper.unescape(element.eq(6).text());
                    if (req.query.details) {
                        item.id = escaper.unescape(element.eq(3).text().match(/\[.+\]/)[0].replace(/\[|\]/g, ''));
                        item.attr = escaper.unescape(element.eq(8).text());
                        item.genre = escaper.unescape(element.eq(9).text());
                        item.credit = escaper.unescape(element.eq(7).text());
                    }

                    // 如果有补考记录，则以最高分的为准
                    if (title in ret.grades) {
                        // 暂不考虑NaN
                        if (item.overall < ret.grades[title].overall) {
                            return;
                        }
                        if (!element.eq(6).css('color')) {
                            delete ret.failed[title];
                        }
                    } else if (element.eq(6).css('color')) {
                        ret.failed[title] = item;
                    }

                    ret.grades[title] = item;
                });

                ret['subject-count'] = Object.keys(ret.grades).length;
                ret['failed-count'] = Object.keys(ret.failed).length;

                access.logout(headers, res, function() {
                    // 返回JSON
                    res.send(JSON.stringify(ret));
                    fullLog && console.log((timeStamp() +
                        'Successfully logged out: ').green +
                        req.query.id.yellow +
                        (' (processed in ' +
                            (new Date() - start) + 'ms)'
                        ).green);
                });

            });
    });
});

// 查考试API，通过GET传入用户名和密码
app.get('/exams', function (req, res, next) {
    if (!req.query.id || !req.query.pwd || (req.query.sem && !(/^20\d{2}-20\d{2}-[1-2]$/).test(req.query.sem))) {
        res.send({ error: "参数不正确" });
        return;
    }
    if (fullLog) {
        var start = new Date();
        console.log((timeStamp() + 'Started to query the exams: ').cyan + req.query.id.yellow);
    }
    access.login(req.query.id, req.query.pwd, res, function (headers, ires) {
        fullLog && console.log((timeStamp() + 'Successfully logged in.').green);

        var ret = {};
        var $ = cheerio.load(ires.text);

        ret.name = escaper.unescape($('.block1text').html()).match(/姓名：.+</)[0].replace('<', '').substring(3);
        ret.id = req.query.id;
        ret.sem = req.query.sem || getSem();

        superagent
            .post('http://csujwc.its.csu.edu.cn/jsxsd/xsks/xsksap_list')
            .set(headers)
            .type('form')
            .send({
                xqlbmc: '',
                xnxqid: ret.sem,
                xqlb: ''
            })
            .end(function (err, iires) {
                if (err) {
                    console.log((timeStamp() + 'Failed to reach exams page\n' + err.stack).red);
                    res.send({ error: '获取成绩失败' });
                    return next(err);
                }
                fullLog && console.log((timeStamp() + 'Successfully entered exams page.').green);

                $ = cheerio.load(iires.text);

                ret.exams = {};
                ret['exams-count'] = 0;

                $('#dataList tr').each(function (index) {
                    if (index === 0) {
                        return;
                    }
                    let element = $(this).find('td');
                    let title = escaper.unescape(element.eq(3).text());

                    let item = {};
                    item.time = escaper.unescape(element.eq(4).text());
                    item.location = escaper.unescape(element.eq(5).text());
                    item.seat = escaper.unescape(element.eq(6).text());

                    ret.exams[title] = item;
                    ret['exams-count']++;
                });

                access.logout(headers, res, function() {
                    res.send(JSON.stringify(ret));
                    fullLog && console.log((timeStamp() + 'Successfully logged out: ').green + req.query.id.yellow + (' (processed in ' + (new Date() - start) + 'ms)').green);
                });

            });
    });
});

app.listen(port);
console.log((timeStamp() +
    'The server is now running on port ' +
    port + '. Full logging is ' +
    (fullLog ? 'enabled.' : 'disabled.')
    ).green);


1		/* TODO
2		* 完善异常处理
3		* 建立用户名-Cookie数据库
4		*/
5
6		'use strict';
7
8		var express = require('express'),
9		superagent = require('superagent'),
10		cheerio = require('cheerio'),
11		escaper = require('true-html-escape'),
12		colors = require('colors'),
13		program = require('commander'),
14		Date = require('./lib/Date.js'),
15		access = require('./lib/access.js');
16
17		program
18		.option('-h, --help')
19		.option('-v, --version')
20		.option('-p, --port [n]', parseInt)
21		.option('-f, --fullLog')
22		.parse(process.argv);
23
24		// 别问我为什么这里逻辑这么奇怪……测试的结果确实是这样的啊hhh
25		if (!program.help \|\| !program.version) {
26		console.log(('CSUEMS API v2.0.3').rainbow);
27		console.log(('by The Liberators').rainbow);
28		if (!program.help) {
29		console.log('Preparation:');
30		console.log(' \\\\This section is WIP\\\\');
31		console.log('\nUsage:');
32		console.log(' npm start [-- <options...>]');
33		console.log('\nOptions:');
34		console.log(' -h, --help print this message and exit.');
35		console.log(' -v, --version print the version and exit.');
36		console.log(' -f, --fullLog enable full log, by default only errors are logged.');
37		console.log(' -p, --port [value] specify a port to listen, 2333 by default.');
38		console.log('\nExamples:');
39		console.log(' $ npm start -p 43715 # listening to 43715');
40		console.log(' $ forever start app.js # deploy with forever as daemon (root access recommended)');
41		console.log(' $ pm2 start -i 0 -n "csuapi" app.js # deploy with pm2 as daemon (root access recommended)');
42		}
43		process.exit(0);
44		}
45
46		const timeStamp = () => new Date().format('[MM-dd hh:mm:ss] '),
47		// 以系统时间获取当前学期
48		getSem = () => {
49		let now = new Date();
50		let month = now.getMonth();
51		let year = now.getFullYear();
52		if (month === 0) {
53		return (year - 1) + '-' + year + '-1';
54		} else if (month <= 6) {
55		return (year - 1) + '-' + year + '-2';
56		} else {
57		return year + '-' + (year + 1) + '-1';
58		}
59		},
60		port = program.port \|\| 2333,
61		fullLog = program.fullLog;
62
63		var app = express();
64
65		// 查成绩API，通过GET传入用户名和密码
66	View Code Duplication	app.get('/grades', function (req, res, next) {
67		if (!req.query.id \|\| !req.query.pwd \|\| (req.query.sem && !(/^20\d{2}-20\d{2}-[1-2]$/).test(req.query.sem))) {
68		res.send({ error: "参数不正确" });
69		return;
70		}
71		if (fullLog) {
72		var start = new Date();
73		console.log((timeStamp() + 'Started to query the grades: ').cyan + req.query.id.yellow);
74		}
75		access.login(req.query.id, req.query.pwd, res, function (headers, ires) {
76		fullLog && console.log((timeStamp() + 'Successfully logged in.').green);
77
78		var ret = {};
79		var $ = cheerio.load(ires.text);
80
81		ret.name = escaper.unescape($('.block1text').html()).match(/姓名：.+</)[0].substring(3).replace(/</, '');
82		ret.id = req.query.id;
83
84		// 实际上xnxq01id为空的时候和GET这个URL的效果是一样的，都是查询所有学期
85		superagent
86		.post('http://csujwc.its.csu.edu.cn/jsxsd/kscj/yscjcx_list')
87		.set(headers)
88		.type('form')
89		.send({
90		xnxq01id: req.query.sem
91		})
92		.end(function (err, iires) {
93		if (err) {
94		console.log((timeStamp() + 'Failed to get grades page\n' + err.stack).red);
95		res.send({ error: '无法进入成绩页面' });
96		return next(err);
97		}
98		fullLog && console.log((timeStamp() + 'Successfully entered grades page.').green);
99
100		$ = cheerio.load(iires.text);
101
102		ret.grades = {};
103		ret.failed = {};
104
105		// 获取成绩列表
106		$('#dataList tr').each(function (index) {
107		if (index === 0) {
108		return;
109		}
110		let element = $(this).find('td');
111		let title = escaper.unescape(element.eq(3).text().match(/].+$/)[0].substring(1));
112
113		let item = {};
114		item.sem = escaper.unescape(element.eq(2).text());
115		item.regular = escaper.unescape(element.eq(4).text());
116		item.exam = escaper.unescape(element.eq(5).text());
117		item.overall = escaper.unescape(element.eq(6).text());
118		if (req.query.details) {
119		item.id = escaper.unescape(element.eq(3).text().match(/\[.+\]/)[0].replace(/\[\|\]/g, ''));
120		item.attr = escaper.unescape(element.eq(8).text());
121		item.genre = escaper.unescape(element.eq(9).text());
122		item.credit = escaper.unescape(element.eq(7).text());
123		}
124
125		// 如果有补考记录，则以最高分的为准
126		if (title in ret.grades) {
127		// 暂不考虑NaN
128		if (item.overall < ret.grades[title].overall) {
129		return;
130		}
131		if (!element.eq(6).css('color')) {
132		delete ret.failed[title];
133		}
134		} else if (element.eq(6).css('color')) {
135		ret.failed[title] = item;
136		}
137
138		ret.grades[title] = item;
139		});
140
141		ret['subject-count'] = Object.keys(ret.grades).length;
142		ret['failed-count'] = Object.keys(ret.failed).length;
143
144		access.logout(headers, res, function() {
145		// 返回JSON
146		res.send(JSON.stringify(ret));
147		fullLog && console.log((timeStamp() +
148		'Successfully logged out: ').green +
149		req.query.id.yellow +
150		(' (processed in ' +
151		(new Date() - start) + 'ms)'
152		).green);
153		});
		0 ignored issues – show Best Practice introduced 2017-01-17 06:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
154		});
155		});
156		});
157
158		// 查考试API，通过GET传入用户名和密码
159	View Code Duplication	app.get('/exams', function (req, res, next) {
160		if (!req.query.id \|\| !req.query.pwd \|\| (req.query.sem && !(/^20\d{2}-20\d{2}-[1-2]$/).test(req.query.sem))) {
161		res.send({ error: "参数不正确" });
162		return;
163		}
164		if (fullLog) {
165		var start = new Date();
166		console.log((timeStamp() + 'Started to query the exams: ').cyan + req.query.id.yellow);
167		}
168		access.login(req.query.id, req.query.pwd, res, function (headers, ires) {
169		fullLog && console.log((timeStamp() + 'Successfully logged in.').green);
170
171		var ret = {};
172		var $ = cheerio.load(ires.text);
173
174		ret.name = escaper.unescape($('.block1text').html()).match(/姓名：.+</)[0].replace('<', '').substring(3);
175		ret.id = req.query.id;
176		ret.sem = req.query.sem \|\| getSem();
177
178		superagent
179		.post('http://csujwc.its.csu.edu.cn/jsxsd/xsks/xsksap_list')
180		.set(headers)
181		.type('form')
182		.send({
183		xqlbmc: '',
184		xnxqid: ret.sem,
185		xqlb: ''
186		})
187		.end(function (err, iires) {
188		if (err) {
189		console.log((timeStamp() + 'Failed to reach exams page\n' + err.stack).red);
190		res.send({ error: '获取成绩失败' });
191		return next(err);
192		}
193		fullLog && console.log((timeStamp() + 'Successfully entered exams page.').green);
194
195		$ = cheerio.load(iires.text);
196
197		ret.exams = {};
198		ret['exams-count'] = 0;
199
200		$('#dataList tr').each(function (index) {
201		if (index === 0) {
202		return;
203		}
204		let element = $(this).find('td');
205		let title = escaper.unescape(element.eq(3).text());
206
207		let item = {};
208		item.time = escaper.unescape(element.eq(4).text());
209		item.location = escaper.unescape(element.eq(5).text());
210		item.seat = escaper.unescape(element.eq(6).text());
211
212		ret.exams[title] = item;
213		ret['exams-count']++;
214		});
215
216		access.logout(headers, res, function() {
217		res.send(JSON.stringify(ret));
218		fullLog && console.log((timeStamp() + 'Successfully logged out: ').green + req.query.id.yellow + (' (processed in ' + (new Date() - start) + 'ms)').green);
219		});
		0 ignored issues – show Best Practice introduced 2017-01-17 06:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
220		});
221		});
222		});
223
224		app.listen(port);
225		console.log((timeStamp() +
226		'The server is now running on port ' +
227		port + '. Full logging is ' +
228		(fullLog ? 'enabled.' : 'disabled.')
229		).green);
230

Equim-chan / csu-ems-api

Push — master ( b5efe9...e20821 )

app.js (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like