Equim-chan / csu-ems-api

app.js

/* TODO

 * 完善异常处理

 * 建立用户名-Cookie数据库

 */


'use strict';


var express    = require('express'),

    superagent = require('superagent'),

    cheerio    = require('cheerio'),

    escaper    = require('true-html-escape'),

    colors     = require('colors'),

    program    = require('commander'),

    Date       = require('./lib/Date.js'),

You are shadowing the built-in type Date. This makes code hard to read, consider using a different name.

    access     = require('./lib/access.js');


program

    .option('-h, --help')

    .option('-v, --version')

    .option('-p, --port [n]', parseInt)

The variable parseInt seems to be never declared. If this is a global, consider adding a /** global: parseInt */ comment.

    .option('-f, --fullLog')

    .parse(process.argv);


// 别问我为什么这里逻辑这么奇怪……测试的结果确实是这样的啊hhh

if (!program.help || !program.version) {

    console.log(('CSUEMS API v1.0.1').rainbow);

console.log looks like debug code. Are you sure you do not want to remove it?

    console.log(('by The Liberators').rainbow);

    if (!program.help) {

        console.log('Preparation:');

        console.log('  \\\\This section is WIP\\\\');

        console.log('\nUsage:');

        console.log('  npm start [-- <options...>]');

        console.log('\nOptions:');

        console.log('  -h, --help          print this message and exit.');

        console.log('  -v, --version       print the version and exit.');

        console.log('  -f, --fullLog       enable full log, by default only errors are logged.');

        console.log('  -p, --port [value]  specify a port to listen, 2333 by default.');

        console.log('\nExamples:');

        console.log('  $ npm start -p 43715                  # listening to 43715');

        console.log('  $ forever start app.js                # deploy with forever as daemon (root access recommended)');

        console.log('  $ pm2 start -i 0 -n "csuapi" app.js   # deploy with pm2 as daemon  (root access recommended)');

    }

    process.exit(0);

Use of process.exit() is discouraged as it will potentially stop the complete node.js application. Consider quitting gracefully instead by throwing an Error.

}


const timeStamp = () => new Date().format('[MM-dd hh:mm:ss] '),

      // 以系统时间获取当前学期

      getSem = () => {

          let now = new Date();

          let month = now.getMonth();

          let year = now.getFullYear();

          if (month === 0) {

              return (year - 1) + '-' + year + '-1';

          } else if (month <= 6) {

              return (year - 1) + '-' + year + '-2';

          } else {

              return year + '-' + (year + 1) + '-1';

          }

      },

      port = program.port || 2333,

      fullLog = program.fullLog;


var app = express();


// 查成绩API，通过GET传入用户名和密码

app.get('/grades', function (req, res, next) {

This code seems to be duplicated in your project.

    if (!req.query.id || !req.query.pwd || (req.query.sem && !(/^20\d{2}-20\d{2}-[1-2]$/).test(req.query.sem))) {

        res.send({ error: "参数不正确" });

        return;

    }

    if (fullLog) {

        var start = new Date();

        console.log((timeStamp() + 'Started to query the grades: ').cyan + req.query.id.yellow);

console.log looks like debug code. Are you sure you do not want to remove it?

    }

    access.login(req.query.id, req.query.pwd, res, function (headers, ires) {

        fullLog && console.log((timeStamp() + 'Successfully logged in.').green);

console.log looks like debug code. Are you sure you do not want to remove it?

        var ret = {};

        var $ = cheerio.load(ires.text);


        ret.name = escaper.unescape($('.block1text').html()).match(/姓名：.+</)[0].substring(3).replace(/</, '');

        ret.id = req.query.id;


        // 实际上xnxq01id为空的时候和GET这个URL的效果是一样的，都是查询所有学期

        superagent

            .post('http://csujwc.its.csu.edu.cn/jsxsd/kscj/yscjcx_list')

            .set(headers)

            .type('form')

            .send({

                xnxq01id: req.query.sem

            })

            .end(function (err, iires) {

                if (err) {

                    console.log((timeStamp() + 'Failed to get grades page\n' + err.stack).red);

console.log looks like debug code. Are you sure you do not want to remove it?

                    res.send({ error: '无法进入成绩页面' });

                    return next(err);

                }

                fullLog && console.log((timeStamp() + 'Successfully entered grades page.').green);


                $ = cheerio.load(iires.text);

                

                ret.grades = {};

                ret['subject-count'] = 0;

                ret.failed = {};

                ret['failed-count'] = 0;


                // 获取成绩列表，如果有补考记录，则以最高分的为准

                $('#dataList tr').each(function (index) {

                    if (index === 0) {

                        return;

                    }

                    let element = $(this).find('td');

                    let title = escaper.unescape(element.eq(3).text().match(/].+$/)[0].substring(1));


                    let item = {};

                    item.sem = escaper.unescape(element.eq(2).text());

                    item.regular = escaper.unescape(element.eq(4).text());

                    item.exam = escaper.unescape(element.eq(5).text());

                    item.overall = escaper.unescape(element.eq(6).text());


                    if (title in ret.grades) {

                        if (item.overall < ret.grades[title].overall) {

                            return;

                        }

                    }


                    ret.grades[title] = item;

                    ret['subject-count']++;


                    // 暂不考虑NaN，(字符串 < 60)为false

                    if (parseInt(item.overall) < 60) {

                        ret.failed[title] = item;

                        ret['failed-count']++;

                    }

                });


                access.logout(headers, res, function() {

                    // 返回JSON

                    res.send(JSON.stringify(ret));

                    fullLog && console.log((timeStamp() + 'Successfully logged out: ').green + req.query.id.yellow + (' (processed in ' + (new Date() - start) + 'ms)').green);

The variable start does not seem to be initialized in case fullLog on line 71 is false. Are you sure this can never be the case?

console.log looks like debug code. Are you sure you do not want to remove it?

                });

There is no return statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding return undefined; explicitly.

            });



    });

});


// 查考试API，通过GET传入用户名和密码

app.get('/exams', function (req, res, next) {

This code seems to be duplicated in your project.

    if (!req.query.id || !req.query.pwd || (req.query.sem && !(/^20\d{2}-20\d{2}-[1-2]$/).test(req.query.sem))) {

        res.send({ error: "参数不正确" });

        return;

    }

    if (fullLog) {

        var start = new Date();

        console.log((timeStamp() + 'Started to query the exams: ').cyan + req.query.id.yellow);

console.log looks like debug code. Are you sure you do not want to remove it?

    }

    access.login(req.query.id, req.query.pwd, res, function (headers, ires) {

        fullLog && console.log((timeStamp() + 'Successfully logged in.').green);

console.log looks like debug code. Are you sure you do not want to remove it?

        var ret = {};

        var $ = cheerio.load(ires.text);


        ret.name = escaper.unescape($('.block1text').html()).match(/姓名：.+</)[0].replace('<', '').substring(3);

        ret.id = req.query.id;

        ret.sem = req.query.sem || getSem();


        superagent

            .post('http://csujwc.its.csu.edu.cn/jsxsd/xsks/xsksap_list')

            .set(headers)

            .type('form')

            .send({

                xqlbmc: '',

                xnxqid: ret.sem,

                xqlb: ''

            })

            .end(function (err, iires) {

                if (err) {

                    console.log((timeStamp() + 'Failed to reach exams page\n' + err.stack).red);

console.log looks like debug code. Are you sure you do not want to remove it?

                    res.send({ error: '获取成绩失败' });

                    return next(err);

                }

                fullLog && console.log((timeStamp() + 'Successfully entered exams page.').green);


                $ = cheerio.load(iires.text);


                ret.exams = {};

                ret['exams-count'] = 0;


                $('#dataList tr').each(function (index) {

                    if (index === 0) {

                        return;

                    }

                    let element = $(this).find('td');

                    let title = escaper.unescape(element.eq(3).text());


                    let item = {};

                    item.time = escaper.unescape(element.eq(4).text());

                    item.location = escaper.unescape(element.eq(5).text());

                    item.seat = escaper.unescape(element.eq(6).text());


                    ret.exams[title] = item;

                    ret['exams-count']++;

                });


                access.logout(headers, res, function() {

                    res.send(JSON.stringify(ret));

                    fullLog && console.log((timeStamp() + 'Successfully logged out: ').green + req.query.id.yellow + (' (processed in ' + (new Date() - start) + 'ms)').green);

console.log looks like debug code. Are you sure you do not want to remove it?

The variable start does not seem to be initialized in case fullLog on line 154 is false. Are you sure this can never be the case?

                });

There is no return statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding return undefined; explicitly.

            });

    });

});


app.listen(port);

console.log((timeStamp() + 'The server is now running on port ' + port + '.').green);