app.get(ꞌ/grades/ꞌ) - Code Metrics - Inspection of "将登入登出模块化，重构部分代码" - Equim-chan/csu-ems-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (f59160)

by Equim

created 2017-01-10 11:30 UTC

app.get(ꞌ/grades/ꞌ) A

↳ Parent: app.js

Complexity

Conditions	2
Paths	16

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	16
nop	3
dl	0
loc	58
rs	9.639
c	0
b	0
f	0

1 Function

Rating	Name	Duplication	Size	Complexity
A	��)	0	52	1

How to fix Long Method

/* TODO
 * 完善异常处理
 */

var http = require('http'),
    express = require('express'),
    superagent = require('superagent'),
    cheerio = require('cheerio'),
    escaper = require('true-html-escape'),
    colors = require('colors'),
    program = require('commander'),
    Date = require('./lib/Date.js'),

    access = require('./lib/access.js');

program
    .option('-h, --help')
    .option('-v, --version')
    .option('-p, --port [n]', parseInt)

    .option('-f, --fulllog')
    .parse(process.argv);

// 别问我为什么这里逻辑这么奇怪……测试的结果确实是这样的啊hhh
if (!program.help || !program.version) {
    console.log(('CSUEMS API v1.0.0').rainbow);

    console.log(('by The Liberators').rainbow);
    if (!program.help) {
        console.log('Preparation:')
        console.log('  \\\\This section is WIP\\\\');
        console.log('\nUsage:');
        console.log('  npm start [-- <options...>]');
        console.log('\nOptions:');
        console.log('  -h, --help          print this message and exit.');
        console.log('  -v, --version       print the version and exit.');
        console.log('  -f, --fulllog       enable full log, by default only errors are logged.');
        console.log('  -p, --port [value]  specify a port to listen, 2333 by default.');
        console.log('\nExamples:');
        console.log('  $ npm start -p 43715                      # listening to 43715');
        console.log('  # forever start app.js                    # deploy with forever as daemon (root access recommended)');
        console.log('  # pm2 start -i 0 --name "csuapi" app.js   # deploy with pm2 as daemon  (root access recommended)');
    }
    process.exit(0);

}

const timeStamp = () => new Date().format('[MM-dd hh:mm:ss] '),
      port = program.port || 2333;
      base = 'http://csujwc.its.csu.edu.cn';


var app = express();

// 查成绩API，通过GET传入用户名和密码
app.get('/grades/', function (req, res, next) {
    if (program.fulllog) {
        var start = new Date();
        console.log((timeStamp() + 'Started to query the grades: ').cyan + req.query.id.yellow);

    }
    access.login(req.query.id, req.query.pwd, res, function (headers, iires) {
        program.fulllog && console.log((timeStamp() + 'Successfully logged in.').green);

        var ret = {};
        var $ = cheerio.load(iires.text);
        ret.name = escaper.unescape($('.block1text').html()).match(/姓名：.+</)[0].replace('<', '').substring(3);
        ret.id = req.query.id;

        // 进入成绩页面
        superagent.get(base + $('li[title="我的成绩"] a').attr('href'))
            .set(headers)
            .end(function (err, iiires) {
                if (err) {
                    console.log((timeStamp() + 'Failed to fetch grades\n' + err.stack).red);

                    ret.error = '获取成绩失败';
                    return next(err);
                }
                program.fulllog && console.log((timeStamp() + 'Successfully entered grades page.').green);

                $ = cheerio.load(iiires.text);

                // 获取成绩列表
                let grades = {};
                let failed = {};
                $('#dataList').each(function (index) {
                    // cheerio没有实现jQuery的lt
                    if (index >= 2)
                        return;
if (a > 0)
    b = 42;
                    $(this).find('tr[class!="theadCss"]').each(function() {
                        // 这段写得真是要吐血了
                        let subject = escaper.unescape($(this).find('td[align="left"]').eq(1).text());
                        if (subject) {
                            let score = $(this).find('font');
                            if (score.text())
                                grades[subject] = score.text();
if (a > 0)
    b = 42;
                            if (score.css('color'))
                                failed[subject] = score.text();
if (a > 0)
    b = 42;
                        }
                    });
                });
                ret.grades = grades;
                ret['subject-count'] = Object.getOwnPropertyNames(grades).length;
                ret.failed = failed;
                ret['failed-count'] = Object.getOwnPropertyNames(failed).length;

                // 完成所有工作后，登出
                access.logout(headers, res, function() {
                        // 第五步：返回JSON
                        res.send(JSON.stringify(ret));
                        program.fulllog && console.log((timeStamp() + 'Successfully logged out: ').green + req.query.id.yellow + (' (processed in ' + (new Date() - start) + 'ms)').green);

                });

            });
    });
});

// 查考试API，通过GET传入用户名和密码
/*
app.get('/exams/', function (req, res, next) {
    if (program.fulllog) {
        var start = new Date();
        console.log((timeStamp() + 'Started to query the exams: ').cyan + req.query.id.yellow);
    }
    login(req.query.id, req.query.pwd, res, function (headers, iires) {
        var ret = {};
        var $ = cheerio.load(iires.text);
        ret.name = escaper.unescape($('.block1text').html()).match(/姓名：.+</)[0].replace('<', '').substring(3);
        ret.id = req.query.id;

        // TODO: POST，注意headers
});
*/

app.listen(port);
console.log((timeStamp() + 'The server is now running on port ' + port + '.').green);

1			/* TODO
2			* 完善异常处理
3			*/
4
5			var http = require('http'),
6			express = require('express'),
7			superagent = require('superagent'),
8			cheerio = require('cheerio'),
9			escaper = require('true-html-escape'),
10			colors = require('colors'),
11			program = require('commander'),
12			Date = require('./lib/Date.js'),
			0 ignored issues – show Comprehensibility introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report You are shadowing the built-in type `Date`. This makes code hard to read, consider using a different name. Loading history...
13			access = require('./lib/access.js');
14
15			program
16			.option('-h, --help')
17			.option('-v, --version')
18			.option('-p, --port [n]', parseInt)
			0 ignored issues – show Bug introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report The variable `parseInt` seems to be never declared. If this is a global, consider adding a `/** global: parseInt */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
19			.option('-f, --fulllog')
20			.parse(process.argv);
21
22			// 别问我为什么这里逻辑这么奇怪……测试的结果确实是这样的啊hhh
23			if (!program.help \|\| !program.version) {
24			console.log(('CSUEMS API v1.0.0').rainbow);
			1 ignored issue – show Debugging Code introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
25			console.log(('by The Liberators').rainbow);
26			if (!program.help) {
27			console.log('Preparation:')
28			console.log(' \\\\This section is WIP\\\\');
29			console.log('\nUsage:');
30			console.log(' npm start [-- <options...>]');
31			console.log('\nOptions:');
32			console.log(' -h, --help print this message and exit.');
33			console.log(' -v, --version print the version and exit.');
34			console.log(' -f, --fulllog enable full log, by default only errors are logged.');
35			console.log(' -p, --port [value] specify a port to listen, 2333 by default.');
36			console.log('\nExamples:');
37			console.log(' $ npm start -p 43715 # listening to 43715');
38			console.log(' # forever start app.js # deploy with forever as daemon (root access recommended)');
39			console.log(' # pm2 start -i 0 --name "csuapi" app.js # deploy with pm2 as daemon (root access recommended)');
40			}
41			process.exit(0);
			1 ignored issue – show Compatibility Debugging Code Best Practice introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report Use of `process.exit()` is discouraged as it will potentially stop the complete node.js application. Consider quitting gracefully instead by throwing an Error. Loading history...
42			}
43
44			const timeStamp = () => new Date().format('[MM-dd hh:mm:ss] '),
45			port = program.port \|\| 2333;
46			base = 'http://csujwc.its.csu.edu.cn';
			0 ignored issues – show Bug introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report The variable `base` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.base`. Loading history...
47
48			var app = express();
49
50			// 查成绩API，通过GET传入用户名和密码
51			app.get('/grades/', function (req, res, next) {
52			if (program.fulllog) {
53			var start = new Date();
54			console.log((timeStamp() + 'Started to query the grades: ').cyan + req.query.id.yellow);
			1 ignored issue – show Debugging Code introduced 2017-01-10 11:31 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
55			}
56			access.login(req.query.id, req.query.pwd, res, function (headers, iires) {
57			program.fulllog && console.log((timeStamp() + 'Successfully logged in.').green);
			1 ignored issue – show Debugging Code introduced 2017-01-10 11:31 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
58			var ret = {};
59			var $ = cheerio.load(iires.text);
60			ret.name = escaper.unescape($('.block1text').html()).match(/姓名：.+</)[0].replace('<', '').substring(3);
61			ret.id = req.query.id;
62
63			// 进入成绩页面
64			superagent.get(base + $('li[title="我的成绩"] a').attr('href'))
65			.set(headers)
66			.end(function (err, iiires) {
67			if (err) {
68			console.log((timeStamp() + 'Failed to fetch grades\n' + err.stack).red);
			1 ignored issue – show Debugging Code introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
69			ret.error = '获取成绩失败';
70			return next(err);
71			}
72			program.fulllog && console.log((timeStamp() + 'Successfully entered grades page.').green);
73
74			$ = cheerio.load(iiires.text);
75
76			// 获取成绩列表
77			let grades = {};
78			let failed = {};
79			$('#dataList').each(function (index) {
80			// cheerio没有实现jQuery的lt
81			if (index >= 2)
82			return;
			0 ignored issues – show Coding Style Best Practice introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
83			$(this).find('tr[class!="theadCss"]').each(function() {
84			// 这段写得真是要吐血了
85			let subject = escaper.unescape($(this).find('td[align="left"]').eq(1).text());
86			if (subject) {
87			let score = $(this).find('font');
88			if (score.text())
89			grades[subject] = score.text();
			0 ignored issues – show Coding Style Best Practice introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
90			if (score.css('color'))
91			failed[subject] = score.text();
			0 ignored issues – show Coding Style Best Practice introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
92			}
93			});
94			});
95			ret.grades = grades;
96			ret['subject-count'] = Object.getOwnPropertyNames(grades).length;
97			ret.failed = failed;
98			ret['failed-count'] = Object.getOwnPropertyNames(failed).length;
99
100			// 完成所有工作后，登出
101			access.logout(headers, res, function() {
102			// 第五步：返回JSON
103			res.send(JSON.stringify(ret));
104			program.fulllog && console.log((timeStamp() + 'Successfully logged out: ').green + req.query.id.yellow + (' (processed in ' + (new Date() - start) + 'ms)').green);
			1 ignored issue – show Bug introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report The variable `start` does not seem to be initialized in case `program.fulllog` on line `52` is `false`. Are you sure this can never be the case? Loading history... Debugging Code introduced 2017-01-10 11:31 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
105			});
			0 ignored issues – show Best Practice introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
106			});
107			});
108			});
109
110			// 查考试API，通过GET传入用户名和密码
111			/*
112			app.get('/exams/', function (req, res, next) {
113			if (program.fulllog) {
114			var start = new Date();
115			console.log((timeStamp() + 'Started to query the exams: ').cyan + req.query.id.yellow);
116			}
117			login(req.query.id, req.query.pwd, res, function (headers, iires) {
118			var ret = {};
119			var $ = cheerio.load(iires.text);
120			ret.name = escaper.unescape($('.block1text').html()).match(/姓名：.+</)[0].replace('<', '').substring(3);
121			ret.id = req.query.id;
122
123			// TODO: POST，注意headers
124			});
125			*/
126
127			app.listen(port);
128			console.log((timeStamp() + 'The server is now running on port ' + port + '.').green);

Equim-chan / csu-ems-api

Branch — master (f59160)

app.get(ꞌ/grades/ꞌ) A

Complexity

Size

Duplication

Importance

1 Function

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like