Issues in app.js - Fixed Issues - Inspection of "改进了异常处理" - Equim-chan/csu-ems-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( db3748...452316 )

by Equim

created 2017-01-22 15:40 UTC

app.js (1 issue)

Labels

Duplication 1

Severity

Informational 1

'use strict';

const
    express    = require('express'),
    superagent = require('superagent'),
    cheerio    = require('cheerio'),
    colors     = require('colors'),
    program    = require('commander'),
    moment     = require('moment'),
    co         = require('co'),
    thunkify   = require('thunkify'),
    access     = require('./lib/access.js');

program
    .option('-h, --help')
    .option('-v, --version')
    .option('-p, --port [value]', parseInt)
    .option('-f, --fullLog')
    .parse(process.argv);

// 别问我为什么这里逻辑这么奇怪……测试的结果确实是这样的啊hhh
if (!program.help || !program.version) {
    console.log(
`${`CSUEMS API v${require('./package').version}
by The Liberators`.rainbow}${program.help ? '' :
`

Preparation:
  ${'(This section is WIP)'.grey}

Usage:
  npm start [-- <options...>]

Options:
  -h, --help          print this message and exit.
  -v, --version       print the version and exit.
  -f, --fullLog       enable full log, by default only errors are logged.
  -p, --port [value]  specify a port to listen, process.env.PORT || 2333 by default.

Examples:
  $ npm start -- -p 43715               # listening to 43715
  $ forever start app.js                # deploy with forever as daemon (root access recommended)
  $ pm2 start -i 0 -n "csuapi" app.js   # deploy with pm2 as daemon  (root access recommended)`}`);
    process.exit(0);
}

superagent.Request.prototype.endThunk = thunkify(superagent.Request.prototype.end);

const
    logging = (log) => console.log(`${moment().format('[[]YY-MM-DD HH:mm:ss[]]')} ${log}`),
    fullLogging = (log) => program.fullLog && logging(log),
    getSem = () => {
        // 以系统时间获取当前学期
        let now = new Date();
        let month = now.getMonth();
        let year = now.getFullYear();
        if (month <= 6) {
            return `${year - 1}-${year}-${month > 0 ? 2 : 1}`;
        } else {
            return `${year}-${year + 1}-1`;
        }
    },
//  wait = (ms) => (callback) => setTimeout(callback, ms),
    port = program.port || process.env.PORT || 2333,
    app = express();

// 获取文档
app.get('/doc', (req, res) => res.sendFile(`${__dirname}/doc/API.html`));

// 查成绩API，通过GET传入用户名和密码
app.get(/^\/g(?:|rades)$/, co.wrap(function *(req, res) {
    if (!req.query.id || !req.query.pwd || (req.query.sem && !(/^20\d{2}-20\d{2}-[1-2]$/).test(req.query.sem))) {
        res.status(404).send({ error: "参数不正确" });
        return;
    }

    let start = new Date();
    fullLogging('Started to query the grades: '.cyan + req.query.id.yellow);

    let headers;
    try {
        headers = yield access.login(req.query.id, req.query.pwd, res);
    } catch (err) { return; }
    fullLogging('Successfully logged in.'.green);

    let ires;
    try {
        // 实际上xnxq01id为空的时候和GET这个URL的效果是一样的，都是查询所有学期
        ires = yield superagent
            .post('http://csujwc.its.csu.edu.cn/jsxsd/kscj/yscjcx_list')
            .set(headers)
            .type('form')
            .send({ xnxq01id: req.query.sem })
            .endThunk();
    } catch (err) {
        logging(` Failed to get grades page\n${err.stack}`.red);
        res.status(404).send({ error: '无法进入成绩页面' });
        return;
    } finally {
        // 直接异步进行?
        co(function *() {
            yield access.logout(headers);
            fullLogging('Successfully logged out: '.green + req.query.id.yellow);
        });
    }
    fullLogging('Successfully entered grades page.'.green);

    let $ = cheerio.load(ires.text);

    let top = $('#Top1_divLoginName').text();
    let result = {
        name: top.match(/\s.+\(/)[0].replace(/\s|\(/g, ''),
        id: top.match(/\(.+\)/)[0].replace(/\(|\)/g, ''),
        grades: {},
        'subject-count': 0,
        failed: {},
        'failed-count': 0,
    };
    // 获取成绩列表
    $('#dataList tr').each(function (index) {
        if (index === 0) {
            return;
        }

        let element = $(this).find('td');

        let title = element.eq(3).text().match(/].+$/)[0].substring(1);
        let item = {
            sem: element.eq(2).text(),
            reg: element.eq(4).text(),
            exam: element.eq(5).text(),
            overall: element.eq(6).text()
        };
        if (req.query.details) {
            item.id = element.eq(3).text().match(/\[.+\]/)[0].replace(/\[|\]/g, '');
            item.attr = element.eq(8).text();
            item.genre = element.eq(9).text();
            item.credit = element.eq(7).text();
        }

        // 如果有补考记录，则以最高分的为准(暂不考虑NaN)
        if (title in result.grades && item.overall < result.grades[title].overall) {
            return;
        }

        result.grades[title] = item;

        // 挂科判定
        if (element.eq(6).css('color')) {
            result.failed[title] = item;
        } else {
            delete result.failed[title];
        }
    });

    result['subject-count'] = Object.keys(result.grades).length;
    result['failed-count'] = Object.keys(result.failed).length;

    res.send(JSON.stringify(result));
    fullLogging(`Successfully responded. (req -> res processed in ${new Date() - start} ms)`.green);
}));

// 查考试API，通过GET传入用户名和密码
app.get(/^\/e(?:|xams)$/, co.wrap(function *(req, res) {
    if (!req.query.id || !req.query.pwd || (req.query.sem && !(/^20\d{2}-20\d{2}-[1-2]$/).test(req.query.sem))) {

        res.status(404).send({ error: "参数不正确" });
        return;
    }

    let start = new Date();
    fullLogging('Started to query the exams: '.cyan + req.query.id.yellow);

    let headers;
    try {
        headers = yield access.login(req.query.id, req.query.pwd, res);
    } catch (err) { return; }
    fullLogging('Successfully logged in.'.green);

    let ires;
    let _sem = req.query.sem || getSem();
    try {
        ires = yield superagent
            .post('http://csujwc.its.csu.edu.cn/jsxsd/xsks/xsksap_list')
            .set(headers)
            .type('form')
            .send({
                xqlbmc: '',
                xnxqid: _sem,
                xqlb: ''
            })
            .endThunk();
    } catch (err) {
        logging(` Failed to reach exams page\n${err.stack}`.red);
        res.status(404).send({ error: '无法进入考试页面' });
        return;
    } finally {
        co(function *() {
            yield access.logout(headers);
            fullLogging('Successfully logged out: '.green + req.query.id.yellow);
        });
    }
    fullLogging('Successfully entered exams page.'.green);

    let $ = cheerio.load(ires.text);

    let top = $('#Top1_divLoginName').text();
    let result = {
        name: top.match(/\s.+\(/)[0].replace(/\s|\(/g, ''),
        id: top.match(/\(.+\)/)[0].replace(/\(|\)/g, ''),
        sem: _sem,
        exams: {},
        'exams-count': 0,
    };
    $('#dataList tr').each(function (index) {
        if (index === 0) {
            return;
        }

        let element = $(this).find('td');

        let title = element.eq(3).text();
        let item = {
            time: element.eq(4).text(),
            location: element.eq(5).text(),
            seat: element.eq(6).text()
        };

        result.exams[title] = item;
        result['exams-count']++;
    });

    res.send(JSON.stringify(result));
    fullLogging(`Successfully responded. (req -> res processed in ${new Date() - start} ms)`.green);
}));

app.listen(port, () => {
    logging(` The API is now running on port ${port}. Full logging is ${program.fullLog ? 'enabled' : 'disabled'}`.green);
});

1		'use strict';
2
3		const
4		express = require('express'),
5		superagent = require('superagent'),
6		cheerio = require('cheerio'),
7		colors = require('colors'),
8		program = require('commander'),
9		moment = require('moment'),
10		co = require('co'),
11		thunkify = require('thunkify'),
12		access = require('./lib/access.js');
13
14		program
15		.option('-h, --help')
16		.option('-v, --version')
17		.option('-p, --port [value]', parseInt)
18		.option('-f, --fullLog')
19		.parse(process.argv);
20
21		// 别问我为什么这里逻辑这么奇怪……测试的结果确实是这样的啊hhh
22		if (!program.help \|\| !program.version) {
23		console.log(
24		`${`CSUEMS API v${require('./package').version}
25		by The Liberators`.rainbow}${program.help ? '' :
26		`
27
28		Preparation:
29		${'(This section is WIP)'.grey}
30
31		Usage:
32		npm start [-- <options...>]
33
34		Options:
35		-h, --help print this message and exit.
36		-v, --version print the version and exit.
37		-f, --fullLog enable full log, by default only errors are logged.
38		-p, --port [value] specify a port to listen, process.env.PORT \|\| 2333 by default.
39
40		Examples:
41		$ npm start -- -p 43715 # listening to 43715
42		$ forever start app.js # deploy with forever as daemon (root access recommended)
43		$ pm2 start -i 0 -n "csuapi" app.js # deploy with pm2 as daemon (root access recommended)`}`);
44		process.exit(0);
45		}
46
47		superagent.Request.prototype.endThunk = thunkify(superagent.Request.prototype.end);
48
49		const
50		logging = (log) => console.log(`${moment().format('[[]YY-MM-DD HH:mm:ss[]]')} ${log}`),
51		fullLogging = (log) => program.fullLog && logging(log),
52		getSem = () => {
53		// 以系统时间获取当前学期
54		let now = new Date();
55		let month = now.getMonth();
56		let year = now.getFullYear();
57		if (month <= 6) {
58		return `${year - 1}-${year}-${month > 0 ? 2 : 1}`;
59		} else {
60		return `${year}-${year + 1}-1`;
61		}
62		},
63		// wait = (ms) => (callback) => setTimeout(callback, ms),
64		port = program.port \|\| process.env.PORT \|\| 2333,
65		app = express();
66
67		// 获取文档
68		app.get('/doc', (req, res) => res.sendFile(`${__dirname}/doc/API.html`));
69
70		// 查成绩API，通过GET传入用户名和密码
71	View Code Duplication	app.get(/^\/g(?:\|rades)$/, co.wrap(function *(req, res) {
72		if (!req.query.id \|\| !req.query.pwd \|\| (req.query.sem && !(/^20\d{2}-20\d{2}-[1-2]$/).test(req.query.sem))) {
73		res.status(404).send({ error: "参数不正确" });
74		return;
75		}
76
77		let start = new Date();
78		fullLogging('Started to query the grades: '.cyan + req.query.id.yellow);
79
80		let headers;
81		try {
82		headers = yield access.login(req.query.id, req.query.pwd, res);
83		} catch (err) { return; }
84		fullLogging('Successfully logged in.'.green);
85
86		let ires;
87		try {
88		// 实际上xnxq01id为空的时候和GET这个URL的效果是一样的，都是查询所有学期
89		ires = yield superagent
90		.post('http://csujwc.its.csu.edu.cn/jsxsd/kscj/yscjcx_list')
91		.set(headers)
92		.type('form')
93		.send({ xnxq01id: req.query.sem })
94		.endThunk();
95		} catch (err) {
96		logging(` Failed to get grades page\n${err.stack}`.red);
97		res.status(404).send({ error: '无法进入成绩页面' });
98		return;
99		} finally {
100		// 直接异步进行?
101		co(function *() {
102		yield access.logout(headers);
103		fullLogging('Successfully logged out: '.green + req.query.id.yellow);
104		});
105		}
106		fullLogging('Successfully entered grades page.'.green);
107
108		let $ = cheerio.load(ires.text);
109
110		let top = $('#Top1_divLoginName').text();
111		let result = {
112		name: top.match(/\s.+\(/)[0].replace(/\s\|\(/g, ''),
113		id: top.match(/\(.+\)/)[0].replace(/\(\|\)/g, ''),
114		grades: {},
115		'subject-count': 0,
116		failed: {},
117		'failed-count': 0,
118		};
119		// 获取成绩列表
120		$('#dataList tr').each(function (index) {
121		if (index === 0) {
122		return;
123		}
124
125		let element = $(this).find('td');
126
127		let title = element.eq(3).text().match(/].+$/)[0].substring(1);
128		let item = {
129		sem: element.eq(2).text(),
130		reg: element.eq(4).text(),
131		exam: element.eq(5).text(),
132		overall: element.eq(6).text()
133		};
134		if (req.query.details) {
135		item.id = element.eq(3).text().match(/\[.+\]/)[0].replace(/\[\|\]/g, '');
136		item.attr = element.eq(8).text();
137		item.genre = element.eq(9).text();
138		item.credit = element.eq(7).text();
139		}
140
141		// 如果有补考记录，则以最高分的为准(暂不考虑NaN)
142		if (title in result.grades && item.overall < result.grades[title].overall) {
143		return;
144		}
145
146		result.grades[title] = item;
147
148		// 挂科判定
149		if (element.eq(6).css('color')) {
150		result.failed[title] = item;
151		} else {
152		delete result.failed[title];
153		}
154		});
155
156		result['subject-count'] = Object.keys(result.grades).length;
157		result['failed-count'] = Object.keys(result.failed).length;
158
159		res.send(JSON.stringify(result));
160		fullLogging(`Successfully responded. (req -> res processed in ${new Date() - start} ms)`.green);
161		}));
162
163		// 查考试API，通过GET传入用户名和密码
164		app.get(/^\/e(?:\|xams)$/, co.wrap(function *(req, res) {
165	View Code Duplication	if (!req.query.id \|\| !req.query.pwd \|\| (req.query.sem && !(/^20\d{2}-20\d{2}-[1-2]$/).test(req.query.sem))) {
		0 ignored issues – show Duplication introduced 2017-01-22 13:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated in your project. Loading history...
166		res.status(404).send({ error: "参数不正确" });
167		return;
168		}
169
170		let start = new Date();
171		fullLogging('Started to query the exams: '.cyan + req.query.id.yellow);
172
173		let headers;
174		try {
175		headers = yield access.login(req.query.id, req.query.pwd, res);
176		} catch (err) { return; }
177		fullLogging('Successfully logged in.'.green);
178
179		let ires;
180		let _sem = req.query.sem \|\| getSem();
181		try {
182		ires = yield superagent
183		.post('http://csujwc.its.csu.edu.cn/jsxsd/xsks/xsksap_list')
184		.set(headers)
185		.type('form')
186		.send({
187		xqlbmc: '',
188		xnxqid: _sem,
189		xqlb: ''
190		})
191		.endThunk();
192		} catch (err) {
193		logging(` Failed to reach exams page\n${err.stack}`.red);
194		res.status(404).send({ error: '无法进入考试页面' });
195		return;
196		} finally {
197		co(function *() {
198		yield access.logout(headers);
199		fullLogging('Successfully logged out: '.green + req.query.id.yellow);
200		});
201		}
202		fullLogging('Successfully entered exams page.'.green);
203
204		let $ = cheerio.load(ires.text);
205
206		let top = $('#Top1_divLoginName').text();
207		let result = {
208		name: top.match(/\s.+\(/)[0].replace(/\s\|\(/g, ''),
209		id: top.match(/\(.+\)/)[0].replace(/\(\|\)/g, ''),
210		sem: _sem,
211		exams: {},
212		'exams-count': 0,
213		};
214		$('#dataList tr').each(function (index) {
215		if (index === 0) {
216		return;
217		}
218
219		let element = $(this).find('td');
220
221		let title = element.eq(3).text();
222		let item = {
223		time: element.eq(4).text(),
224		location: element.eq(5).text(),
225		seat: element.eq(6).text()
226		};
227
228		result.exams[title] = item;
229		result['exams-count']++;
230		});
231
232		res.send(JSON.stringify(result));
233		fullLogging(`Successfully responded. (req -> res processed in ${new Date() - start} ms)`.green);
234		}));
235
236		app.listen(port, () => {
237		logging(` The API is now running on port ${port}. Full logging is ${program.fullLog ? 'enabled' : 'disabled'}`.green);
238		});

Equim-chan / csu-ems-api

Push — master ( db3748...452316 )

app.js (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like