Issues in app.js - All Issues - Inspection of "改进了异常处理" - Equim-chan/csu-ems-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( db3748...452316 )

by Equim

created 2017-01-22 15:40 UTC

app.js (5 issues)

Labels

Severity

'use strict';

const
    express    = require('express'),
    superagent = require('superagent'),
    cheerio    = require('cheerio'),
    colors     = require('colors'),

    program    = require('commander'),
    moment     = require('moment'),
    co         = require('co'),
    thunkify   = require('thunkify'),
    access     = require('./lib/access.js');

program
    .option('-h, --help')
    .option('-v, --version')
    .option('-p, --port [value]', parseInt)

    .option('-f, --fullLog')
    .parse(process.argv);

// 别问我为什么这里逻辑这么奇怪……测试的结果确实是这样的啊hhh
if (!program.help || !program.version) {
    console.log(
`${`CSUEMS API v${require('./package').version}
by The Liberators`.rainbow}${program.help ? '' :
`

Preparation:
  ${'(This section is WIP)'.grey}

Usage:
  npm start [-- <options...>]

Options:
  -h, --help          print this message and exit.
  -v, --version       print the version and exit.
  -f, --fullLog       enable full log, by default only errors are logged.
  -p, --port [value]  specify a port to listen, process.env.PORT || 2333 by default.

Examples:
  $ npm start -- -p 43715               # listening to 43715
  $ forever start app.js                # deploy with forever as daemon (root access recommended)
  $ pm2 start -i 0 -n "csuapi" app.js   # deploy with pm2 as daemon  (root access recommended)`}`);
    process.exit(0);
}

superagent.Request.prototype.endThunk = thunkify(superagent.Request.prototype.end);

const
    logging = (log) => console.log(`${moment().format('[[]YY-MM-DD HH:mm:ss[]]')} ${log}`),
    fullLogging = (log) => program.fullLog && logging(log),
    getSem = () => {
        // 以系统时间获取当前学期
        let now = new Date();
        let month = now.getMonth();
        let year = now.getFullYear();
        if (month <= 6) {
            return `${year - 1}-${year}-${month > 0 ? 2 : 1}`;
        } else {
            return `${year}-${year + 1}-1`;
        }
    },
//  wait = (ms) => (callback) => setTimeout(callback, ms),
    port = program.port || process.env.PORT || 2333,
    app = express();

// 获取文档
app.get('/doc', (req, res) => res.sendFile(`${__dirname}/doc/API.html`));

// 查成绩API，通过GET传入用户名和密码
app.get(/^\/g(?:|rades)$/, co.wrap(function *(req, res) {

    if (!req.query.id || !req.query.pwd || (req.query.sem && !(/^20\d{2}-20\d{2}-[1-2]$/).test(req.query.sem))) {
        res.status(404).send({ error: "参数不正确" });
        return;
    }

    let start = new Date();
    fullLogging('Started to query the grades: '.cyan + req.query.id.yellow);

    let headers;
    try {
        headers = yield access.login(req.query.id, req.query.pwd);
    } catch (err) {
        logging(err.eqMessage.inner.red);
        res.status(404).send({ error: err.eqMessage.public });
        return;
    }
    fullLogging('Successfully logged in.'.green);

    let ires;
    try {
        // 实际上xnxq01id为空的时候和GET这个URL的效果是一样的，都是查询所有学期
        ires = yield superagent
            .post('http://csujwc.its.csu.edu.cn/jsxsd/kscj/yscjcx_list')
            .set(headers)
            .type('form')
            .send({ xnxq01id: req.query.sem })
            .endThunk();
    } catch (err) {
        logging(`Failed to get grades page\n${err.stack}`.red);
        res.status(404).send({ error: '无法进入成绩页面' });
        return;
    } finally {
        // 直接异步进行?
        co(function *() {
            try {
                yield access.logout(headers);
            } catch (err) {
                logging(err.eqMessage.inner.red);
                return;

            }
            fullLogging('Successfully logged out: '.green + req.query.id.yellow);
        });
    }
    fullLogging('Successfully entered grades page.'.green);

    let $ = cheerio.load(ires.text);

    let top = $('#Top1_divLoginName').text();
    let result = {
        name: top.match(/\s.+\(/)[0].replace(/\s|\(/g, ''),
        id: top.match(/\(.+\)/)[0].replace(/\(|\)/g, ''),
        grades: {},
        'subject-count': 0,
        failed: {},
        'failed-count': 0,
    };
    // 获取成绩列表
    $('#dataList tr').each(function (index) {
        if (index === 0) {
            return;
        }

        let element = $(this).find('td');

        let title = element.eq(3).text().match(/].+$/)[0].substring(1);
        let item = {
            sem: element.eq(2).text(),
            reg: element.eq(4).text(),
            exam: element.eq(5).text(),
            overall: element.eq(6).text()
        };
        if (req.query.details) {
            item.id = element.eq(3).text().match(/\[.+\]/)[0].replace(/\[|\]/g, '');
            item.attr = element.eq(8).text();
            item.genre = element.eq(9).text();
            item.credit = element.eq(7).text();
        }

        // 如果有补考记录，则以最高分的为准(暂不考虑NaN)
        if (title in result.grades && item.overall < result.grades[title].overall) {
            return;
        }

        result.grades[title] = item;

        // 挂科判定
        if (element.eq(6).css('color')) {
            result.failed[title] = item;
        } else {
            delete result.failed[title];
        }
    });

    result['subject-count'] = Object.keys(result.grades).length;
    result['failed-count'] = Object.keys(result.failed).length;

    res.send(JSON.stringify(result));
    fullLogging(`Successfully responded. (req -> res processed in ${new Date() - start} ms)`.green);
}));

// 查考试API，通过GET传入用户名和密码
app.get(/^\/e(?:|xams)$/, co.wrap(function *(req, res) {

    if (!req.query.id || !req.query.pwd || (req.query.sem && !(/^20\d{2}-20\d{2}-[1-2]$/).test(req.query.sem))) {
        res.status(404).send({ error: "参数不正确" });
        return;
    }

    let start = new Date();
    fullLogging('Started to query the exams: '.cyan + req.query.id.yellow);

    let headers;
    try {
        headers = yield access.login(req.query.id, req.query.pwd);
    } catch (err) {
        logging(err.eqMessage.inner.red);
        res.status(404).send({ error: err.eqMessage.public });
        return;
    }
    fullLogging('Successfully logged in.'.green);

    let ires;
    let _sem = req.query.sem || getSem();
    try {
        ires = yield superagent
            .post('http://csujwc.its.csu.edu.cn/jsxsd/xsks/xsksap_list')
            .set(headers)
            .type('form')
            .send({
                xqlbmc: '',
                xnxqid: _sem,
                xqlb: ''
            })
            .endThunk();
    } catch (err) {
        logging(`Failed to reach exams page\n${err.stack}`.red);
        res.status(404).send({ error: '无法进入考试页面' });
        return;
    } finally {
        co(function *() {
            try {
                yield access.logout(headers);
            } catch (err) {
                logging(err.eqMessage.inner.red);
            }
            fullLogging('Successfully logged out: '.green + req.query.id.yellow);
        });
    }
    fullLogging('Successfully entered exams page.'.green);

    let $ = cheerio.load(ires.text);

    let top = $('#Top1_divLoginName').text();
    let result = {
        name: top.match(/\s.+\(/)[0].replace(/\s|\(/g, ''),
        id: top.match(/\(.+\)/)[0].replace(/\(|\)/g, ''),
        sem: _sem,
        exams: {},
        'exams-count': 0,
    };
    $('#dataList tr').each(function (index) {
        if (index === 0) {
            return;
        }

        let element = $(this).find('td');

        let title = element.eq(3).text();
        let item = {
            time: element.eq(4).text(),
            location: element.eq(5).text(),
            seat: element.eq(6).text()
        };

        result.exams[title] = item;
        result['exams-count']++;
    });

    res.send(JSON.stringify(result));
    fullLogging(`Successfully responded. (req -> res processed in ${new Date() - start} ms)`.green);
}));

app.listen(port, () => {
    logging(`The API is now running on port ${port}. Full logging is ${program.fullLog ? 'enabled' : 'disabled'}`.green);
});

1		'use strict';
2
3		const
4		express = require('express'),
5		superagent = require('superagent'),
6		cheerio = require('cheerio'),
7		colors = require('colors'),
		0 ignored issues – show Unused Code introduced 2017-01-19 08:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `colors` seems to be never used. Consider removing it. Loading history...
8		program = require('commander'),
9		moment = require('moment'),
10		co = require('co'),
11		thunkify = require('thunkify'),
12		access = require('./lib/access.js');
13
14		program
15		.option('-h, --help')
16		.option('-v, --version')
17		.option('-p, --port [value]', parseInt)
		0 ignored issues – show Bug introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `parseInt` seems to be never declared. If this is a global, consider adding a `/** global: parseInt */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
18		.option('-f, --fullLog')
19		.parse(process.argv);
20
21		// 别问我为什么这里逻辑这么奇怪……测试的结果确实是这样的啊hhh
22		if (!program.help \|\| !program.version) {
23		console.log(
24		`${`CSUEMS API v${require('./package').version}
25		by The Liberators`.rainbow}${program.help ? '' :
26		`
27
28		Preparation:
29		${'(This section is WIP)'.grey}
30
31		Usage:
32		npm start [-- <options...>]
33
34		Options:
35		-h, --help print this message and exit.
36		-v, --version print the version and exit.
37		-f, --fullLog enable full log, by default only errors are logged.
38		-p, --port [value] specify a port to listen, process.env.PORT \|\| 2333 by default.
39
40		Examples:
41		$ npm start -- -p 43715 # listening to 43715
42		$ forever start app.js # deploy with forever as daemon (root access recommended)
43		$ pm2 start -i 0 -n "csuapi" app.js # deploy with pm2 as daemon (root access recommended)`}`);
44		process.exit(0);
45		}
46
47		superagent.Request.prototype.endThunk = thunkify(superagent.Request.prototype.end);
48
49		const
50		logging = (log) => console.log(`${moment().format('[[]YY-MM-DD HH:mm:ss[]]')} ${log}`),
51		fullLogging = (log) => program.fullLog && logging(log),
52		getSem = () => {
53		// 以系统时间获取当前学期
54		let now = new Date();
55		let month = now.getMonth();
56		let year = now.getFullYear();
57		if (month <= 6) {
58		return `${year - 1}-${year}-${month > 0 ? 2 : 1}`;
59		} else {
60		return `${year}-${year + 1}-1`;
61		}
62		},
63		// wait = (ms) => (callback) => setTimeout(callback, ms),
64		port = program.port \|\| process.env.PORT \|\| 2333,
65		app = express();
66
67		// 获取文档
68		app.get('/doc', (req, res) => res.sendFile(`${__dirname}/doc/API.html`));
69
70		// 查成绩API，通过GET传入用户名和密码
71	View Code Duplication	app.get(/^\/g(?:\|rades)$/, co.wrap(function *(req, res) {
		0 ignored issues – show Duplication introduced 2017-01-22 13:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated in your project. Loading history...
72		if (!req.query.id \|\| !req.query.pwd \|\| (req.query.sem && !(/^20\d{2}-20\d{2}-[1-2]$/).test(req.query.sem))) {
73		res.status(404).send({ error: "参数不正确" });
74		return;
75		}
76
77		let start = new Date();
78		fullLogging('Started to query the grades: '.cyan + req.query.id.yellow);
79
80		let headers;
81		try {
82		headers = yield access.login(req.query.id, req.query.pwd);
83		} catch (err) {
84		logging(err.eqMessage.inner.red);
85		res.status(404).send({ error: err.eqMessage.public });
86		return;
87		}
88		fullLogging('Successfully logged in.'.green);
89
90		let ires;
91		try {
92		// 实际上xnxq01id为空的时候和GET这个URL的效果是一样的，都是查询所有学期
93		ires = yield superagent
94		.post('http://csujwc.its.csu.edu.cn/jsxsd/kscj/yscjcx_list')
95		.set(headers)
96		.type('form')
97		.send({ xnxq01id: req.query.sem })
98		.endThunk();
99		} catch (err) {
100		logging(`Failed to get grades page\n${err.stack}`.red);
101		res.status(404).send({ error: '无法进入成绩页面' });
102		return;
103		} finally {
104		// 直接异步进行?
105		co(function *() {
106		try {
107		yield access.logout(headers);
108		} catch (err) {
109		logging(err.eqMessage.inner.red);
110		return;
		0 ignored issues – show Comprehensibility Bug introduced 2017-01-22 15:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this Usage of the `return` statement in a finally clause is discouraged. This construct may mask errors and makes debugging difficult. Loading history...
111		}
112		fullLogging('Successfully logged out: '.green + req.query.id.yellow);
113		});
114		}
115		fullLogging('Successfully entered grades page.'.green);
116
117		let $ = cheerio.load(ires.text);
118
119		let top = $('#Top1_divLoginName').text();
120		let result = {
121		name: top.match(/\s.+\(/)[0].replace(/\s\|\(/g, ''),
122		id: top.match(/\(.+\)/)[0].replace(/\(\|\)/g, ''),
123		grades: {},
124		'subject-count': 0,
125		failed: {},
126		'failed-count': 0,
127		};
128		// 获取成绩列表
129		$('#dataList tr').each(function (index) {
130		if (index === 0) {
131		return;
132		}
133
134		let element = $(this).find('td');
135
136		let title = element.eq(3).text().match(/].+$/)[0].substring(1);
137		let item = {
138		sem: element.eq(2).text(),
139		reg: element.eq(4).text(),
140		exam: element.eq(5).text(),
141		overall: element.eq(6).text()
142		};
143		if (req.query.details) {
144		item.id = element.eq(3).text().match(/\[.+\]/)[0].replace(/\[\|\]/g, '');
145		item.attr = element.eq(8).text();
146		item.genre = element.eq(9).text();
147		item.credit = element.eq(7).text();
148		}
149
150		// 如果有补考记录，则以最高分的为准(暂不考虑NaN)
151		if (title in result.grades && item.overall < result.grades[title].overall) {
152		return;
153		}
154
155		result.grades[title] = item;
156
157		// 挂科判定
158		if (element.eq(6).css('color')) {
159		result.failed[title] = item;
160		} else {
161		delete result.failed[title];
162		}
163		});
164
165		result['subject-count'] = Object.keys(result.grades).length;
166		result['failed-count'] = Object.keys(result.failed).length;
167
168		res.send(JSON.stringify(result));
169		fullLogging(`Successfully responded. (req -> res processed in ${new Date() - start} ms)`.green);
170		}));
171
172		// 查考试API，通过GET传入用户名和密码
173	View Code Duplication	app.get(/^\/e(?:\|xams)$/, co.wrap(function *(req, res) {
		0 ignored issues – show Duplication introduced 2017-01-22 15:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated in your project. Loading history...
174		if (!req.query.id \|\| !req.query.pwd \|\| (req.query.sem && !(/^20\d{2}-20\d{2}-[1-2]$/).test(req.query.sem))) {
175		res.status(404).send({ error: "参数不正确" });
176		return;
177		}
178
179		let start = new Date();
180		fullLogging('Started to query the exams: '.cyan + req.query.id.yellow);
181
182		let headers;
183		try {
184		headers = yield access.login(req.query.id, req.query.pwd);
185		} catch (err) {
186		logging(err.eqMessage.inner.red);
187		res.status(404).send({ error: err.eqMessage.public });
188		return;
189		}
190		fullLogging('Successfully logged in.'.green);
191
192		let ires;
193		let _sem = req.query.sem \|\| getSem();
194		try {
195		ires = yield superagent
196		.post('http://csujwc.its.csu.edu.cn/jsxsd/xsks/xsksap_list')
197		.set(headers)
198		.type('form')
199		.send({
200		xqlbmc: '',
201		xnxqid: _sem,
202		xqlb: ''
203		})
204		.endThunk();
205		} catch (err) {
206		logging(`Failed to reach exams page\n${err.stack}`.red);
207		res.status(404).send({ error: '无法进入考试页面' });
208		return;
209		} finally {
210		co(function *() {
211		try {
212		yield access.logout(headers);
213		} catch (err) {
214		logging(err.eqMessage.inner.red);
215		}
216		fullLogging('Successfully logged out: '.green + req.query.id.yellow);
217		});
218		}
219		fullLogging('Successfully entered exams page.'.green);
220
221		let $ = cheerio.load(ires.text);
222
223		let top = $('#Top1_divLoginName').text();
224		let result = {
225		name: top.match(/\s.+\(/)[0].replace(/\s\|\(/g, ''),
226		id: top.match(/\(.+\)/)[0].replace(/\(\|\)/g, ''),
227		sem: _sem,
228		exams: {},
229		'exams-count': 0,
230		};
231		$('#dataList tr').each(function (index) {
232		if (index === 0) {
233		return;
234		}
235
236		let element = $(this).find('td');
237
238		let title = element.eq(3).text();
239		let item = {
240		time: element.eq(4).text(),
241		location: element.eq(5).text(),
242		seat: element.eq(6).text()
243		};
244
245		result.exams[title] = item;
246		result['exams-count']++;
247		});
248
249		res.send(JSON.stringify(result));
250		fullLogging(`Successfully responded. (req -> res processed in ${new Date() - start} ms)`.green);
251		}));
252
253		app.listen(port, () => {
254		logging(`The API is now running on port ${port}. Full logging is ${program.fullLog ? 'enabled' : 'disabled'}`.green);
255		});

Equim-chan / csu-ems-api

Push — master ( db3748...452316 )

app.js (5 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like