app.get(ꞌ/exams/ꞌ) - Code Metrics - Inspection of "添加了考试安排查询" - Equim-chan/csu-ems-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 84125d...23c154 )

by Equim

created 2017-01-10 19:42 UTC

app.get(ꞌ/exams/ꞌ) A

↳ Parent: app.js

Complexity

Conditions	2
Paths	8

Size

Total Lines

Duplication

Lines	52
Ratio	100 %

Importance

Changes

Metric	Value
cc	2
nc	8
nop	3
dl	52
loc	52
rs	9.4929
c	0
b	0
f	0

1 Function

Rating	Name	Duplication	Size	Complexity
B	��)	46	46	1

How to fix Long Method

/* TODO
 * 完善异常处理
 */

"use strict";

var express = require('express'),
    superagent = require('superagent'),
    cheerio = require('cheerio'),
    escaper = require('true-html-escape'),
    colors = require('colors'),
    program = require('commander'),
    Date = require('./lib/Date.js'),

    access = require('./lib/access.js');

program
    .option('-h, --help')
    .option('-v, --version')
    .option('-p, --port [n]', parseInt)

    .option('-f, --fullLog')
    .parse(process.argv);

// 别问我为什么这里逻辑这么奇怪……测试的结果确实是这样的啊hhh
if (!program.help || !program.version) {
    console.log(('CSUEMS API v1.0.0').rainbow);

    console.log(('by The Liberators').rainbow);
    if (!program.help) {
        console.log('Preparation:');
        console.log('  \\\\This section is WIP\\\\');
        console.log('\nUsage:');
        console.log('  npm start [-- <options...>]');
        console.log('\nOptions:');
        console.log('  -h, --help          print this message and exit.');
        console.log('  -v, --version       print the version and exit.');
        console.log('  -f, --fullLog       enable full log, by default only errors are logged.');
        console.log('  -p, --port [value]  specify a port to listen, 2333 by default.');
        console.log('\nExamples:');
        console.log('  $ npm start -p 43715                           # listening to 43715');
        console.log('  $ sudo forever start app.js                    # deploy with forever as daemon (root access recommended)');
        console.log('  $ sudo pm2 start -i 0 --name "csuapi" app.js   # deploy with pm2 as daemon  (root access recommended)');
    }
    process.exit(0);

}

const timeStamp = () => new Date().format('[MM-dd hh:mm:ss] '),
      port = program.port || 2333,
      base = 'http://csujwc.its.csu.edu.cn';

var app = express();

// 查成绩API，通过GET传入用户名和密码
app.get('/grades/', function (req, res, next) {

    if (program.fulllog) {
        var start = new Date();
        console.log((timeStamp() + 'Started to query the grades: ').cyan + req.query.id.yellow);

    }
    access.login(req.query.id, req.query.pwd, res, function (headers, ires) {
        program.fulllog && console.log((timeStamp() + 'Successfully logged in.').green);

        var ret = {};
        var $ = cheerio.load(ires.text);
        ret.name = escaper.unescape($('.block1text').html()).match(/姓名：.+</)[0].replace('<', '').substring(3);
        ret.id = req.query.id;

        // 进入成绩页面
        superagent.get(base + $('li[title="我的成绩"] a').attr('href'))
            .set(headers)
            .end(function (err, iires) {
                if (err) {
                    console.log((timeStamp() + 'Failed to get grades page\n' + err.stack).red);

                    res.send({ error: '无法进入成绩页面' });
                    return next(err);
                }
                program.fulllog && console.log((timeStamp() + 'Successfully entered grades page.').green);

                $ = cheerio.load(iires.text);

                // 获取成绩列表
                let grades = {};
                let failed = {};
                $('#dataList').each(function (index) {
                    // cheerio没有实现jQuery的lt
                    if (index >= 2)
                        return;
if (a > 0)
    b = 42;
                    $(this).find('tr[class!="theadCss"]').each(function() {
                        // 这段写得真是要吐血了
                        let subject = escaper.unescape($(this).find('td[align="left"]').eq(1).text());
                        if (subject) {
                            let score = $(this).find('font');
                            if (score.text())
                                grades[subject] = score.text();
if (a > 0)
    b = 42;
                            if (score.css('color'))
                                failed[subject] = score.text();
if (a > 0)
    b = 42;
                        }
                    });
                });
                ret.grades = grades;
                ret['subject-count'] = Object.getOwnPropertyNames(grades).length;
                ret.failed = failed;
                ret['failed-count'] = Object.getOwnPropertyNames(failed).length;

                // 完成所有工作后，登出
                access.logout(headers, res, function() {
                    // 第五步：返回JSON
                    res.send(JSON.stringify(ret));
                    program.fulllog && console.log((timeStamp() + 'Successfully logged out: ').green + req.query.id.yellow + (' (processed in ' + (new Date() - start) + 'ms)').green);

                });

            });
    });
});

// TODO: 对参数的正确性进行检查

// 查考试API，通过GET传入用户名和密码
app.get('/exams/', function (req, res, next) {

    if (program.fulllog) {
        var start = new Date();
        console.log((timeStamp() + 'Started to query the exams: ').cyan + req.query.id.yellow);

    }
    access.login(req.query.id, req.query.pwd, res, function (headers, ires) {
        var ret = {};
        var $ = cheerio.load(ires.text);
        ret.name = escaper.unescape($('.block1text').html()).match(/姓名：.+</)[0].replace('<', '').substring(3);
        ret.id = req.query.id;
        
        superagent.post('http://csujwc.its.csu.edu.cn/jsxsd/xsks/xsksap_list')
            .set(headers)
            .type('form')
            .send({
                xqlbmc: '',
                xnxqid: '2016-2017-1',      //TODO: 添加别的选项，或者通过参数传入
                xqlb: ''
            })
            .end(function (err, iires) {
                if (err) {
                    console.log((timeStamp() + 'Failed to reach exams page\n' + err.stack).red);

                    res.send({ error: '获取成绩失败' });
                    return next(err);
                }
                program.fulllog && console.log((timeStamp() + 'Successfully entered exams page.').green);

                $ = cheerio.load(iires.text);

                let exams = [];

                $('#dataList tr').each(function (index) {
                    if (index === 0)
                        return;
if (a > 0)
    b = 42;
                    let item = $(this).find('td');
                    let subject = {};
                    subject.subject = escaper.unescape(item.eq(3).text());
                    subject.time = escaper.unescape(item.eq(4).text());
                    subject.location = escaper.unescape(item.eq(5).text());
                    subject.seat = escaper.unescape(item.eq(6).text());
                    exams.push(subject);
                });

                ret.exams = exams;

                access.logout(headers, res, function() {
                    res.send(JSON.stringify(ret));
                    program.fulllog && console.log((timeStamp() + 'Successfully logged out: ').green + req.query.id.yellow + (' (processed in ' + (new Date() - start) + 'ms)').green);

                });

            });
    });
});

app.listen(port);
console.log((timeStamp() + 'The server is now running on port ' + port + '.').green);

1		/* TODO
2		* 完善异常处理
3		*/
4
5		"use strict";
6
7		var express = require('express'),
8		superagent = require('superagent'),
9		cheerio = require('cheerio'),
10		escaper = require('true-html-escape'),
11		colors = require('colors'),
12		program = require('commander'),
13		Date = require('./lib/Date.js'),
		0 ignored issues – show Comprehensibility introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report You are shadowing the built-in type `Date`. This makes code hard to read, consider using a different name. Loading history...
14		access = require('./lib/access.js');
15
16		program
17		.option('-h, --help')
18		.option('-v, --version')
19		.option('-p, --port [n]', parseInt)
		0 ignored issues – show Bug introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report The variable `parseInt` seems to be never declared. If this is a global, consider adding a `/** global: parseInt */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
20		.option('-f, --fullLog')
21		.parse(process.argv);
22
23		// 别问我为什么这里逻辑这么奇怪……测试的结果确实是这样的啊hhh
24		if (!program.help \|\| !program.version) {
25		console.log(('CSUEMS API v1.0.0').rainbow);
		1 ignored issue – show Debugging Code introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
26		console.log(('by The Liberators').rainbow);
27		if (!program.help) {
28		console.log('Preparation:');
29		console.log(' \\\\This section is WIP\\\\');
30		console.log('\nUsage:');
31		console.log(' npm start [-- <options...>]');
32		console.log('\nOptions:');
33		console.log(' -h, --help print this message and exit.');
34		console.log(' -v, --version print the version and exit.');
35		console.log(' -f, --fullLog enable full log, by default only errors are logged.');
36		console.log(' -p, --port [value] specify a port to listen, 2333 by default.');
37		console.log('\nExamples:');
38		console.log(' $ npm start -p 43715 # listening to 43715');
39		console.log(' $ sudo forever start app.js # deploy with forever as daemon (root access recommended)');
40		console.log(' $ sudo pm2 start -i 0 --name "csuapi" app.js # deploy with pm2 as daemon (root access recommended)');
41		}
42		process.exit(0);
		1 ignored issue – show Compatibility Debugging Code Best Practice introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report Use of `process.exit()` is discouraged as it will potentially stop the complete node.js application. Consider quitting gracefully instead by throwing an Error. Loading history...
43		}
44
45		const timeStamp = () => new Date().format('[MM-dd hh:mm:ss] '),
46		port = program.port \|\| 2333,
47		base = 'http://csujwc.its.csu.edu.cn';
48
49		var app = express();
50
51		// 查成绩API，通过GET传入用户名和密码
52	View Code Duplication	app.get('/grades/', function (req, res, next) {
		0 ignored issues – show Duplication introduced 2017-01-10 19:43 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
53		if (program.fulllog) {
54		var start = new Date();
55		console.log((timeStamp() + 'Started to query the grades: ').cyan + req.query.id.yellow);
		1 ignored issue – show Debugging Code introduced 2017-01-10 11:31 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
56		}
57		access.login(req.query.id, req.query.pwd, res, function (headers, ires) {
58		program.fulllog && console.log((timeStamp() + 'Successfully logged in.').green);
		1 ignored issue – show Debugging Code introduced 2017-01-10 11:31 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
59		var ret = {};
60		var $ = cheerio.load(ires.text);
61		ret.name = escaper.unescape($('.block1text').html()).match(/姓名：.+</)[0].replace('<', '').substring(3);
62		ret.id = req.query.id;
63
64		// 进入成绩页面
65		superagent.get(base + $('li[title="我的成绩"] a').attr('href'))
66		.set(headers)
67		.end(function (err, iires) {
68		if (err) {
69		console.log((timeStamp() + 'Failed to get grades page\n' + err.stack).red);
		1 ignored issue – show Debugging Code introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
70		res.send({ error: '无法进入成绩页面' });
71		return next(err);
72		}
73		program.fulllog && console.log((timeStamp() + 'Successfully entered grades page.').green);
74
75		$ = cheerio.load(iires.text);
76
77		// 获取成绩列表
78		let grades = {};
79		let failed = {};
80		$('#dataList').each(function (index) {
81		// cheerio没有实现jQuery的lt
82		if (index >= 2)
83		return;
		0 ignored issues – show Coding Style Best Practice introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
84		$(this).find('tr[class!="theadCss"]').each(function() {
85		// 这段写得真是要吐血了
86		let subject = escaper.unescape($(this).find('td[align="left"]').eq(1).text());
87		if (subject) {
88		let score = $(this).find('font');
89		if (score.text())
90		grades[subject] = score.text();
		0 ignored issues – show Coding Style Best Practice introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
91		if (score.css('color'))
92		failed[subject] = score.text();
		0 ignored issues – show Coding Style Best Practice introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
93		}
94		});
95		});
96		ret.grades = grades;
97		ret['subject-count'] = Object.getOwnPropertyNames(grades).length;
98		ret.failed = failed;
99		ret['failed-count'] = Object.getOwnPropertyNames(failed).length;
100
101		// 完成所有工作后，登出
102		access.logout(headers, res, function() {
103		// 第五步：返回JSON
104		res.send(JSON.stringify(ret));
105		program.fulllog && console.log((timeStamp() + 'Successfully logged out: ').green + req.query.id.yellow + (' (processed in ' + (new Date() - start) + 'ms)').green);
		1 ignored issue – show Bug introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report The variable `start` does not seem to be initialized in case `program.fulllog` on line `53` is `false`. Are you sure this can never be the case? Loading history... Debugging Code introduced 2017-01-10 11:31 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
106		});
		0 ignored issues – show Best Practice introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
107		});
108		});
109		});
110
111		// TODO: 对参数的正确性进行检查
112
113		// 查考试API，通过GET传入用户名和密码
114	View Code Duplication	app.get('/exams/', function (req, res, next) {
		0 ignored issues – show Duplication introduced 2017-01-10 19:43 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
115		if (program.fulllog) {
116		var start = new Date();
117		console.log((timeStamp() + 'Started to query the exams: ').cyan + req.query.id.yellow);
		1 ignored issue – show Debugging Code introduced 2017-01-10 09:20 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
118		}
119		access.login(req.query.id, req.query.pwd, res, function (headers, ires) {
120		var ret = {};
121		var $ = cheerio.load(ires.text);
122		ret.name = escaper.unescape($('.block1text').html()).match(/姓名：.+</)[0].replace('<', '').substring(3);
123		ret.id = req.query.id;
124
125		superagent.post('http://csujwc.its.csu.edu.cn/jsxsd/xsks/xsksap_list')
126		.set(headers)
127		.type('form')
128		.send({
129		xqlbmc: '',
130		xnxqid: '2016-2017-1', //TODO: 添加别的选项，或者通过参数传入
131		xqlb: ''
132		})
133		.end(function (err, iires) {
134		if (err) {
135		console.log((timeStamp() + 'Failed to reach exams page\n' + err.stack).red);
		1 ignored issue – show Debugging Code introduced 2017-01-10 19:43 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
136		res.send({ error: '获取成绩失败' });
137		return next(err);
138		}
139		program.fulllog && console.log((timeStamp() + 'Successfully entered exams page.').green);
140
141		$ = cheerio.load(iires.text);
142
143		let exams = [];
144
145		$('#dataList tr').each(function (index) {
146		if (index === 0)
147		return;
		0 ignored issues – show Coding Style Best Practice introduced 2017-01-10 19:43 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
148		let item = $(this).find('td');
149		let subject = {};
150		subject.subject = escaper.unescape(item.eq(3).text());
151		subject.time = escaper.unescape(item.eq(4).text());
152		subject.location = escaper.unescape(item.eq(5).text());
153		subject.seat = escaper.unescape(item.eq(6).text());
154		exams.push(subject);
155		});
156
157		ret.exams = exams;
158
159		access.logout(headers, res, function() {
160		res.send(JSON.stringify(ret));
161		program.fulllog && console.log((timeStamp() + 'Successfully logged out: ').green + req.query.id.yellow + (' (processed in ' + (new Date() - start) + 'ms)').green);
		1 ignored issue – show Bug introduced 2017-01-10 19:43 UTC by Report Bug Copy Issue Report The variable `start` does not seem to be initialized in case `program.fulllog` on line `115` is `false`. Are you sure this can never be the case? Loading history... Debugging Code introduced 2017-01-10 19:43 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
162		});
		0 ignored issues – show Best Practice introduced 2017-01-10 19:43 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
163		});
164		});
165		});
166
167		app.listen(port);
168		console.log((timeStamp() + 'The server is now running on port ' + port + '.').green);

Equim-chan / csu-ems-api

Push — master ( 84125d...23c154 )

app.get(ꞌ/exams/ꞌ) A

Complexity

Size

Duplication

Importance

1 Function

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like