wps_barcode::insert_barcode() - Code Metrics - Inspection of "Optimisation + Validation devis" - Eoxia/wpshop - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 88dfbf...b0f2bc )

unknown

created 2017-01-27 16:56 UTC

wps_barcode::insert_barcode() D

↳ Parent: wps_barcode

Complexity

Conditions	14
Paths	50

Size

Total Lines	98
Code Lines	47

Duplication

Lines	36
Ratio	36.73 %

Importance

Changes

Metric	Value
cc	14
eloc	47
nc	50
nop	3
dl	36
loc	98
rs	4.9516
c	0
b	0
f	0

How to fix Long Method Complexity

<?php if ( !defined( 'ABSPATH' ) ) exit;
class wps_barcode {
	public function __construct() {
		global $post_ID;

		$this->install();
		add_action( 'save_post', array($this, 'insert_barcode' ), 10, 3 );
	}

	/**
	 * Install default configuration in database if not present
	 */
	public function install() {
		global $table_prefix, $wpdb;

		/*Create config informations*/
		$conf = get_option('wps_barcode');

		if ( empty($conf) ) {
			$conf['generate_barcode'] = false;
			$conf['type'] = 'internal';
			$conf['internal_client'] = '040';
			$conf['internal_provider'] = '041';
			$conf['internal_invoice_client'] = '042';
			$conf['internal_do_client'] = '043';
			$conf['internal_product'] = '044';
			$conf['internal_assets_client'] = '050';
			$conf['internal_coupons'] = '051';
			$conf['internal_invoice_provider'] = '045';
			$conf['internal_do_provider'] = '046';

			$conf['normal_country_code'] = '320';
			$conf['normal_enterprise_code'] = '0001';

			add_option('wps_barcode', $conf);

			/*Adding barcode for existing products*/
			$posts = get_posts( array('posts_per_page' => -1 ,'post_type' => 'wpshop_product'));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
			foreach ( $posts as $post ) {

				$meta = get_post_meta($post->ID);

				$attr = wpshop_attributes_set::getAttributeSetDetails($meta['_wpshop_product_attribute_set_id']);
				$output_order = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

				if ( count($attr) > 0 ) {
					if (!empty($attr) ) {
						foreach ( $attr as $product_attr_group_id =>

								$product_attr_group_detail) {
							foreach ( $product_attr_group_detail['attribut']
									as $position => $attribute_def) {
								if ( !empty($attribute_def->code)
										AND $attribute_def->code === 'barcode') {

									$types_with_barcode = array(
											WPSHOP_IDENTIFIER_PRODUCT,
											WPSHOP_NEWTYPE_IDENTIFIER_PRODUCT,
											WPSHOP_NEWTYPE_IDENTIFIER_PRODUCT_VARIATION,
											WPSHOP_NEWTYPE_IDENTIFIER_COUPON,
											WPSHOP_NEWTYPE_IDENTIFIER_ORDER,
									);

									if ( !empty( $post->post_type ) &&
											in_array( $post->post_type,
											$types_with_barcode ) ) {

										$ref = '';

										if ( strlen($post->ID) < 5 ) {

											$length = 5-strlen($post->ID);
											for ($i = 0; $i < $length; $i++) {
												$ref .= '0';
											}
										}

										$ref .= strval($post->ID);

										if ( $conf['type'] === 'normal' ) {

											$array['normal'] = array('country' =>
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
													$conf['normal_country_code'],
													'enterprise' =>
													$conf['normal_enterprise_code'],'ID' => $ref);
										}
										else if ( $conf['type'] === 'internal' ) {
											$pDate = new DateTime($post->post_date);
											$date = $pDate->format('my');

											if ($post->post_type === WPSHOP_NEWTYPE_IDENTIFIER_PRODUCT ||
													$post->post_type === WPSHOP_IDENTIFIER_PRODUCT) {
												$type = $conf['internal_product'];
											}
											else if ($post->post_type === WPSHOP_NEWTYPE_IDENTIFIER_ORDER) {
												$type = $conf['internal_invoice_client'];
											}
											else if ($post->post_type === WPSHOP_NEWTYPE_IDENTIFIER_COUPON) {
												$type = $conf['internal_coupons'];
											}
											else {
												$type = '000';
											}

											$array['internal'] = array('type' => $type,
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
													'date' => $date,
													'ID' => $ref);
										}

										$barcode = $this->wps_generate_barcode($array);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
										$data = array('entity_type_id' => 4,
												'attribute_id' => '12',
												'entity_id' => $post->ID,
												'user_id' => $post->post_author,
												'value' => $barcode,
												'creation_date_value' => date( 'Y-m-d H:i:s' ));


										$query = $wpdb->prepare( "
											SELECT *
											FROM " . WPSHOP_DBT_ATTRIBUTE_VALUES_VARCHAR . "
											WHERE entity_id = %d
												AND attribute_id = (
													SELECT id
													FROM " . WPSHOP_DBT_ATTRIBUTE . "
													WHERE code = %s
												)" , $post->ID, 'barcode' );
											$result = $wpdb->get_results( $query, ARRAY_A );

										if ( empty($result) ) {
											$wpdb->insert($table_prefix.
													'wpshop__attribute_value_varchar', $data);
										} elseif( empty( $result[0]['value'] ) ) {
											$wpdb->update($table_prefix.
													'wpshop__attribute_value_varchar', $data, array( 'value_id' => $result[0]['value_id'] ) );
										}
									}
								}
							}
						}
					}
				}
			}

			/*Adding barcode for existing coupon*/
			$posts = get_posts( array('posts_per_page' => -1 ,'post_type' => 'wpshop_shop_coupon') );
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
			foreach ( $posts as $post ) {

				$meta = get_post_meta($post->ID);
				if ( empty($meta['wpshop_coupon_barcode']) ) {
					if ( $conf['type'] === 'normal' ) {
						$array['normal'] = array('country' =>
								$conf['normal_country_code'],
								'enterprise' =>
								$conf['normal_enterprise_code'],'ID' => $ref);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
					}
					else if ( $conf['type'] === 'internal' ) {
						$pDate = new DateTime($post->post_date);
						$date = $pDate->format('my');

						if ($post->post_type === WPSHOP_NEWTYPE_IDENTIFIER_COUPON) {
							$type = $conf['internal_coupons'];
						}
						else {
							$type = '000';
						}

						$ref = '';
						if ( strlen($post->ID) < 5 ) {

							$length = 5-strlen($post->ID);
							for ($i = 0; $i < $length; $i++) {
								$ref .= '0';
							}
						}

						$ref .= strval($post->ID);
						$array['internal'] = array('type' => $type,
								'date' => $date,
								'ID' => $ref);
					}
					$barcode = $this->wps_generate_barcode($array);
					update_post_meta($post->ID, 'wpshop_coupon_barcode', $barcode);
				}
			}
		}
	}

	/**
	 * Verifty post identifier and run a barcode generator
	 * @param string $post_ID Ident of post
	 */
	public function insert_barcode( $post_ID, $post, $update ) {

		if ( wp_is_post_revision( $post_ID ) )
			return;

		global $wpdb;

		$types_with_barcode = array(
			WPSHOP_IDENTIFIER_PRODUCT,
			WPSHOP_NEWTYPE_IDENTIFIER_PRODUCT,
			WPSHOP_NEWTYPE_IDENTIFIER_PRODUCT_VARIATION,
			WPSHOP_NEWTYPE_IDENTIFIER_COUPON,
			WPSHOP_NEWTYPE_IDENTIFIER_ORDER,
		);

		/** Si c'est un type qui est dans le tableau $types_with_barcode */
		if ( !empty( $post->post_type ) && in_array( $post->post_type,
				$types_with_barcode ) ) {

			$conf = get_option('wps_barcode');
			$ref = '';

			if ( strlen($post_ID) < 5 ) {

				$length = 5-strlen($post_ID);
				for ($i = 0; $i < $length; $i++) {
					$ref .= '0';
				}
			}

			$ref .= strval($post_ID);

			if ( $conf['type'] === 'normal' ) {

				$array['normal'] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
					'country' 		=> $conf['normal_country_code'],
					'enterprise' 	=> $conf['normal_enterprise_code'],
					'ID' 			=> $ref,
				);
			}
			else if ( $conf['type'] === 'internal' ) {
				$pDate = new DateTime($post->post_date);
				$date = $pDate->format('my');

				if ($post->post_type === WPSHOP_NEWTYPE_IDENTIFIER_PRODUCT || $post->post_type === WPSHOP_IDENTIFIER_PRODUCT) {
					$type = $conf['internal_product'];
				}
				else if ($post->post_type === WPSHOP_NEWTYPE_IDENTIFIER_ORDER) {
					$type = $conf['internal_invoice_client'];
				}
				else if ($post->post_type === WPSHOP_NEWTYPE_IDENTIFIER_COUPON) {
					$type = $conf['internal_coupons'];
				}
				else {
					$type = '000';
				}

				$array['internal'] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
					'type' => $type,
					'date' => $date,
					'ID' => $ref
				);
			}

			//$barcode = $this->wps_generate_barcode($array);

			/** For add a product */
			$_REQUEST['wpshop_product_attribute']['varchar']['barcode'] = !empty( $_REQUEST['wpshop_product_attribute']['varchar']['barcode'] ) ? sanitize_text_field( $_REQUEST['wpshop_product_attribute']['varchar']['barcode'] ) : null;
			if( !isset($_REQUEST['wpshop_product_attribute']['varchar']['barcode']) ) {
				wpeologs_ctr::log_datas_in_files( 'wps_barcode',
				array(
					'object_id' => $post_ID,
					'message' => sprintf( __('Adding barcode: %s for %s object ID', 'wps_barcode'), '<b>'.$_REQUEST['wpshop_product_attribute']['varchar']['barcode'].'</b>', '<b>'.$post_ID.'</b>') ),
				0);
				$_REQUEST['wpshop_product_attribute']['varchar']['barcode'] = $this->wps_generate_barcode($array);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			}
			/*if (  isset($barcode) ) {
				if ($barcode !== '') {
					wpeologs_ctr::log_datas_in_files( 'wps_barcode',
					array(
					'object_id' => $post_ID,
					'message' => sprintf( __('Change barcode: %s replacing %s for %s object ID', 'wps_barcode'), '<b>'.sanitize_text_field( $_REQUEST['wpshop_product_attribute']['varchar']['barcode'] ).'</b>', '<b>'.$barcode.'</b>', '<b>'.$post_ID.'</b>') ), 0);

					$barcode = sanitize_text_field( $_REQUEST['wpshop_product_attribute']['varchar']['barcode'] );
				}
				else {
					wpeologs_ctr::log_datas_in_files( 'wps_barcode',
					array(
						'object_id' => $post_ID,
						'message' => sprintf( __('Adding barcode: %s for %s object ID', 'wps_barcode'), '<b>'.$barcode.'</b>', '<b>'.$post_ID.'</b>') ),
					0);

					// $_REQUEST['wpshop_product_attribute']['varchar']['barcode'] = $barcode;
				}
			}
			else {
				/** On met à jour l'attribut barcode *//*
				$products = new wps_product_ctr();
				$products->update_the_attribute_for_product($post_ID, 'varchar', 'barcode', $barcode);
			}*/
		}
	}

	/**
	 * Save post meta of the post
	 * @param string $post_type Constant identifier of post
	 * @param string $post_date Date of creation post
	 * @param string $post_ID Ident of post
	 * @return string Number code of barcode
	 */
	//private function wps_generate_barcode($post_type, $post_date, $post_ID) {

	private function wps_generate_barcode($array) {
		include_once('wps_barcodegen.ctr.php');

		$code = '';
		$ref = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		$barcode = new wps_barcodegen;

		$conf = get_option('wps_barcode');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

		if ( array_key_exists('normal', $array) ) {
			$code .= $array['normal']['country'];
			$code .= $array['normal']['enterprise'];
			$code .= $array['normal']['ID'];

			$id = $array['normal']['ID'];

		}
		else if ( array_key_exists('internal', $array) ) {
			$code.= $array['internal']['type'];
			$code .= $array['internal']['date'];
			$code .= $array['internal']['ID'];

			$id = $array['internal']['ID'];
		}

		$gencode = $barcode->checksum($code);

		$barcode->writeLog( sprintf( __("Checksum generate: %s from %s <br />",
		'wps_barcode'), '<b>'.$gencode.'</b>',
		'<b>'.$code.'</b>') );

		$message = sprintf( __("Log generated by wps_barcodegen for add/update product: <br /> %s",
				'wps_barcode'), $barcode->getLog() );

		if ( class_exists('wpeologs_ctr') ) {
			wpeologs_ctr::log_datas_in_files( 'wps_barcode', array('object_id' => $id, 'message' => $message), 0);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		}

		return $gencode;
	}
}


Push — master ( 88dfbf...b0f2bc )

wps_barcode::insert_barcode() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php if ( !defined( 'ABSPATH' ) ) exit;
2			class wps_barcode {
3			public function __construct() {
4			global $post_ID;
5
6			$this->install();
7			add_action( 'save_post', array($this, 'insert_barcode' ), 10, 3 );
8			}
9
10			/**
11			* Install default configuration in database if not present
12			*/
13			public function install() {
14			global $table_prefix, $wpdb;
15
16			/Create config informations/
17			$conf = get_option('wps_barcode');
18
19			if ( empty($conf) ) {
20			$conf['generate_barcode'] = false;
21			$conf['type'] = 'internal';
22			$conf['internal_client'] = '040';
23			$conf['internal_provider'] = '041';
24			$conf['internal_invoice_client'] = '042';
25			$conf['internal_do_client'] = '043';
26			$conf['internal_product'] = '044';
27			$conf['internal_assets_client'] = '050';
28			$conf['internal_coupons'] = '051';
29			$conf['internal_invoice_provider'] = '045';
30			$conf['internal_do_provider'] = '046';
31
32			$conf['normal_country_code'] = '320';
33			$conf['normal_enterprise_code'] = '0001';
34
35			add_option('wps_barcode', $conf);
36
37			/Adding barcode for existing products/
38			$posts = get_posts( array('posts_per_page' => -1 ,'post_type' => 'wpshop_product'));
			0 ignored issues – show Bug introduced 2016-05-17 10:17 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$posts` is correct as `get_posts(array('posts_p...' => 'wpshop_product'))` (which targets `get_posts()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
39			foreach ( $posts as $post ) {

Eoxia / wpshop

Push — master ( 88dfbf...b0f2bc )

wps_barcode::insert_barcode() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like