tests.test_activities - Code Metrics - Inspection of "WIP: Activities api" - EnterpriseyIntranet/nextcloud-API - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#15)

unknown

created 2019-01-06 16:35 UTC

tests.test_activities A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Importance

Changes

Metric	Value
wmc	5
eloc	31
dl	0
loc	46
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	TestActivities.test_get_filter_activities()	0	38	5

from .base import BaseTestCase
class SomeClass:
    def some_method(self):
        """Do x and return foo."""


class TestActivities(BaseTestCase):

    SUCCESS_CODE = 200

    def test_get_filter_activities(self):
        res = self.nxc.get_activities()
        all_data = res['ocs']['data']
        assert res['ocs']['meta']['statuscode'] == self.SUCCESS_CODE

        # test limit
        res = self.nxc.get_activities(limit=1)
        assert res['ocs']['meta']['statuscode'] == self.SUCCESS_CODE
        assert len(res['ocs']['data']) <= 1

        # test ascending sorting
        res = self.nxc.get_activities(sort="asc")
        assert res['ocs']['meta']['statuscode'] == self.SUCCESS_CODE
        data = res['ocs']['data']
        for num in range(1, len(data)):
            assert data[num - 1]['activity_id'] <= data[num]['activity_id']

        # test descending sorting
        res = self.nxc.get_activities(sort="desc")
        assert res['ocs']['meta']['statuscode'] == self.SUCCESS_CODE
        data = res['ocs']['data']
        for num in range(1, len(data)):
            assert data[num - 1]['activity_id'] >= data[num]['activity_id']

        # TODO: add more reliable tests for since, object_id, object_type parameters, if WebDAV Directory API will be

        #  implemented and it will be possible to make files manipulation to create activities from api


        # not reliable test for filter by object_id and object_type
        if len(all_data):
            object_to_filter_by = all_data[0]
            res = self.nxc.get_activities(object_id=object_to_filter_by['object_id'],
                                          object_type=object_to_filter_by['object_type'])
            assert res['ocs']['meta']['statuscode'] == self.SUCCESS_CODE
            data = res['ocs']['data']
            assert len(data) >= 1
            for each in data:
                assert each['object_id'] == object_to_filter_by['object_id']
                assert each['object_type'] == object_to_filter_by['object_type']




1			from .base import BaseTestCase
			0 ignored issues – show Coding Style introduced 2018-12-26 00:50 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2
3
4			class TestActivities(BaseTestCase):
5
6			SUCCESS_CODE = 200
7
8			def test_get_filter_activities(self):
9			res = self.nxc.get_activities()
10			all_data = res['ocs']['data']
11			assert res['ocs']['meta']['statuscode'] == self.SUCCESS_CODE
12
13			# test limit
14			res = self.nxc.get_activities(limit=1)
15			assert res['ocs']['meta']['statuscode'] == self.SUCCESS_CODE
16			assert len(res['ocs']['data']) <= 1
17
18			# test ascending sorting
19			res = self.nxc.get_activities(sort="asc")
20			assert res['ocs']['meta']['statuscode'] == self.SUCCESS_CODE
21			data = res['ocs']['data']
22			for num in range(1, len(data)):
23			assert data[num - 1]['activity_id'] <= data[num]['activity_id']
24
25			# test descending sorting
26			res = self.nxc.get_activities(sort="desc")
27			assert res['ocs']['meta']['statuscode'] == self.SUCCESS_CODE
28			data = res['ocs']['data']
29			for num in range(1, len(data)):
30			assert data[num - 1]['activity_id'] >= data[num]['activity_id']
31
32			# TODO: add more reliable tests for since, object_id, object_type parameters, if WebDAV Directory API will be
			0 ignored issues – show Coding Style introduced 2019-01-06 16:36 UTC by Report Bug Copy Issue Report `TODO` and `FIXME` comments should generally be avoided. Loading history... Coding Style introduced 2019-01-06 16:36 UTC by Report Bug Copy Issue Report This line is too long as per the coding-style (117/100). This check looks for lines that are too long. You can specify the maximum line length. Loading history...
33			# implemented and it will be possible to make files manipulation to create activities from api
			0 ignored issues – show Coding Style introduced 2019-01-06 16:36 UTC by Report Bug Copy Issue Report This line is too long as per the coding-style (103/100). This check looks for lines that are too long. You can specify the maximum line length. Loading history...
34
35			# not reliable test for filter by object_id and object_type
36			if len(all_data):
37			object_to_filter_by = all_data[0]
38			res = self.nxc.get_activities(object_id=object_to_filter_by['object_id'],
39			object_type=object_to_filter_by['object_type'])
40			assert res['ocs']['meta']['statuscode'] == self.SUCCESS_CODE
41			data = res['ocs']['data']
42			assert len(data) >= 1
43			for each in data:
44			assert each['object_id'] == object_to_filter_by['object_id']
45			assert each['object_type'] == object_to_filter_by['object_type']
46
			0 ignored issues – show coding-style introduced 2019-01-06 16:36 UTC by Report Bug Copy Issue Report Trailing newlines Loading history...
47

EnterpriseyIntranet / nextcloud-API

Pull Request — master (#15)

tests.test_activities A

Complexity

Size/Duplication

Importance

1 Method

Duplication Side-by-Side

Filter issues like