Enjoys\Forms\Renderer\Html\HtmlRenderer

Complexity

Total Complexity

10

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Test Coverage

Coverage

88%

Importance

Changes	5
Bugs	1	Features	3

5 Methods

Rating	Name	Duplication	Size	Complexity
A	createTypeRender()	0	9	3
A	rendererElements()	0	7	2
A	rendererHiddenElements()	0	10	3
A	rendererElement()	0	4	1
A	output()	0	7	1

<?php

declare(strict_types=1);

namespace Enjoys\Forms\Renderer\Html;

use Enjoys\Forms\Element;
use Enjoys\Forms\Elements;
use Enjoys\Forms\Elements\Hidden;
use Enjoys\Forms\Helper;
use Enjoys\Forms\Renderer\AbstractRenderer;
use Enjoys\Forms\Renderer\Html\TypesRender\TypeRenderInterface;

class HtmlRenderer extends AbstractRenderer
{
    private const _MAP_ = [
        TypesRender\Button::class => [
            Elements\Button::class,
            Elements\Submit::class,
            Elements\Reset::class,
            Elements\Image::class
        ],
        TypesRender\Radio::class => [
            Elements\Radio::class,
            Elements\Checkbox::class
        ],
        TypesRender\Select::class => Elements\Select::class,
        TypesRender\Html::class => [
            Elements\Html::class,
            Elements\Header::class
        ]
    ];

    public static function createTypeRender(Element $element): TypeRenderInterface
    {
        /** @var false|string $typeRenderClass */
        $typeRenderClass = Helper::arrayRecursiveSearchKeyMap(get_class($element), self::_MAP_)[0] ?? false;
        if ($typeRenderClass === false || !class_exists($typeRenderClass)) {

The condition $typeRenderClass === false is always true.

            return new TypesRender\Input($element);
        }
        /** @var class-string<TypeRenderInterface> $typeRenderClass */
        return new $typeRenderClass($element);
    }

    public function rendererHiddenElements(): string
    {
        $html = [];
        foreach ($this->getForm()->getElements() as $element) {
            if ($element instanceof Hidden) {
                $this->getForm()->removeElement($element);
                $html[] = $element->baseHtml();
            }
        }
        return implode("\n", $html);
    }

    public function rendererElements(): string
    {
        $html = [];
        foreach ($this->getForm()->getElements() as $element) {
            $html[] = "<div>" . self::createTypeRender($element)->render() . "</div>";
        }
        return implode("\n", $html);
    }

    public function rendererElement(string $elementName): string
    {
        $element = $this->getForm()->getElement($elementName);
        return "<div>" . self::createTypeRender($element)->render() . "</div>";

It seems like $element can also be of type null; however, parameter $element of Enjoys\Forms\Renderer\Html\HtmlRenderer::createTypeRender() does only seem to accept Enjoys\Forms\Element, maybe add an additional type check?

    }

    public function output(): string
    {
        return sprintf(
            "<form%s>\n%s\n%s\n</form>",
            $this->getForm()->getAttributesString(),
            $this->rendererHiddenElements(),
            $this->rendererElements()
        );
    }
}