Enjoys\Forms\Rule\Email

Complexity

Total Complexity

6

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Test Coverage

Coverage

89.47%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	check()	0	11	2
A	setMessage()	0	6	2
A	validate()	0	15	2

<?php

declare(strict_types=1);

namespace Enjoys\Forms\Rule;

use Enjoys\Forms\Element;
use Enjoys\Forms\Interfaces\Ruleable;
use Enjoys\Forms\Rules;

class Email extends Rules implements RuleInterface
{
//    private $idn_to_ascii = false;

    public function setMessage(?string $message = null): ?string
    {
        if (is_null($message)) {
            $message = 'Не правильно введен email';
        }
        return parent::setMessage($message);
    }

    /**
     * @psalm-suppress PossiblyNullReference
     * @param Ruleable&Element $element
     * @return bool
     */
    public function validate(Ruleable $element): bool
    {

        $method = $this->getRequest()->getRequest()->getMethod();
        $requestData = match (strtolower($method)) {
            'get' => $this->getRequest()->getQueryData()->toArray(),
            'post' => $this->getRequest()->getPostData()->toArray(),
            default => []
        };
        $value = \getValueByIndexPath($element->getName(), $requestData);

The method getName() does not exist on Enjoys\Forms\Interfaces\Ruleable. Since it exists in all sub-types, consider adding an abstract or default implementation to Enjoys\Forms\Interfaces\Ruleable.

        if (!$this->check(\trim($value))) {

It seems like $value can also be of type false; however, parameter $string of trim() does only seem to accept string, maybe add an additional type check?

            $element->setRuleError($this->getMessage());
            return false;
        }
        return true;
    }


    private function check(string $value)
    {
        if (empty($value)) {
            return true;
        }

//        if ($this->idn_to_ascii === true) {
//            $value = idn_to_ascii($value);
//        }

        return filter_var($value, \FILTER_VALIDATE_EMAIL);
    }
}