Enjoys\Forms\Rule\Email::validate()

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	2.024

Importance

Changes

0

<?php
    public function validate(Ruleable $element): bool
    {

        $method = $this->getRequest()->getRequest()->getMethod();
        $requestData = match (strtolower($method)) {
            'get' => $this->getRequest()->getQueryData()->toArray(),
            'post' => $this->getRequest()->getPostData()->toArray(),
            default => []
        };
        $value = \getValueByIndexPath($element->getName(), $requestData);

The method getName() does not exist on Enjoys\Forms\Interfaces\Ruleable. Since it exists in all sub-types, consider adding an abstract or default implementation to Enjoys\Forms\Interfaces\Ruleable.

        if (!$this->check(\trim($value))) {

It seems like $value can also be of type false; however, parameter $string of trim() does only seem to accept string, maybe add an additional type check?

            $element->setRuleError($this->getMessage());
            return false;
        }
        return true;
    }