Enjoys\Forms\Rule\UploadCheck\ExtensionsCheck::check()

Complexity

Conditions	4
Paths	5

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function check(): bool
    {
        if ($this->value === false) {
            return true;
        }
        $extension = pathinfo($this->value->getClientFilename() ?? '', PATHINFO_EXTENSION);

        if (is_null($this->message)) {
            $this->message = 'Загрузка файлов с расширением .' . $extension . ' запрещена';

Are you sure $extension of type array|string can be used in concatenation?

        }


        if (!in_array(\strtolower($extension), $this->expectedExtensions, true)) {

It seems like $extension can also be of type array; however, parameter $string of strtolower() does only seem to accept string, maybe add an additional type check?

            $this->element->setRuleError($this->message);
            return false;
        }
        return true;
    }