Issues in ReleaseVersionComparator.php (master) - Issues in master - Enalean/tuleap - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4873)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tools/rpm/ReleaseVersionComparator.php (2 issues)

Labels

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

require_once 'FakePluginDescriptor.php';

class ReleaseVersionComparator {
    const COLOR_RED     = "\033[31m";
    const COLOR_GREEN   = "\033[32m";
    const COLOR_NOCOLOR = "\033[0m";

    protected $tmpNames = array();

    public function __construct($prevUri, $curUri) {
        $this->prevUri = $prevUri;
        $this->curUri  = $curUri;
    }

    public function __destruct() {
        foreach ($this->tmpNames as $file) {
            @unlink($file);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }
    }

    public function iterateOverPaths($paths, $rpms, $verbose=false) {
        $iRpms = array_flip(array_map('strtolower', $rpms));
        foreach ($paths as $path) {
            $versionPath = $path.'/VERSION';            
            $curVersion  = $this->getCurrentVersion($versionPath);
            try {
                $prevVersion = $this->getPreviousVersion($versionPath);
                $this->displayOneLine($path, $curVersion, $prevVersion, $iRpms, $verbose);
            } catch(Exception $e) {
                echo "Impossible to get previous $versionPath. It's normal if it's new in this release. Otherwise, please check\n";
            }
        }
    }

    public function displayOneLine($path, $curVersion, $prevVersion, $iRpms, $verbose) {
        $versionOk = version_compare($curVersion, $prevVersion, '>');
        if ($verbose || !$versionOk) {
            $flag = '';
            $name = basename($path);
            if (isset($iRpms[strtolower($name)])) {
                if ($versionOk) {
                    $flag .= self::COLOR_GREEN;
                } else {
                    $flag .= self::COLOR_RED;
                }
                $flag .= '[RPM] ';
            }
            echo "\t$flag".$path.": ".$curVersion.' (Previous release was: '.$prevVersion.')'.self::COLOR_NOCOLOR.PHP_EOL;        
        }
    }

    public function getCurrentVersion($relPath) {
        if (is_dir($this->curUri)) {
            return $this->getVersionContent($this->curUri.$relPath);
        } else {
            return $this->getRemoteVersion($this->curUri.$relPath);
        }
    }

    public function getPreviousVersion($relPath) {
        return $this->getRemoteVersion($this->prevUri.$relPath);
    }

    protected function getRemoteVersion($url) {
        $filePath = $this->getRemoteFile($url);
        return $this->getVersionContent($filePath);
    }

    protected function getRemoteFile($url) {
        $name   = tempnam('/tmp', 'codendi_release_');
        $this->tmpNames[] = $name;
        $output = array();
        $retVal = false;
        exec('svn cat '.$url.' 2>/dev/null > '.$name, $output, $retVal);
        if ($retVal === 0) {
            return $name;
        }
        throw new Exception('Impossible to get remote file: '.$url);
    }
    
    protected function getVersionContent($filePath) {
        return trim(file_get_contents($filePath));
    }

}

class PluginReleaseVersionComparator extends ReleaseVersionComparator {

    public function __construct($prevUri, $curUri, $fpd) {
        parent::__construct($prevUri, $curUri);
        $this->fpd = $fpd;
    }

    public function getPreviousVersion($relPath) {
        try {
            return $this->getRemoteVersion($this->prevUri.$relPath);
        } catch (Exception $e) {
            $pluginRoot = dirname($relPath);
            $pluginName = basename($pluginRoot);
            $path       = $this->fpd->findDescriptor($this->curUri.$pluginRoot);
            $relPath    = substr($path, -(strlen($path)-strlen($this->curUri)));

            // Get descriptor
            $oldDescPath = $this->getRemoteFile($this->prevUri.$relPath);
            $oldDesc     = $this->fpd->getDescriptorFromFile($pluginName, $oldDescPath);
            return $oldDesc->getVersion();
        }
        throw new Exception('No way to get the previous version number');
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

}

?>

1			<?php
2
3			require_once 'FakePluginDescriptor.php';
4
5			class ReleaseVersionComparator {
6			const COLOR_RED = "\033[31m";
7			const COLOR_GREEN = "\033[32m";
8			const COLOR_NOCOLOR = "\033[0m";
9
10			protected $tmpNames = array();
11
12			public function __construct($prevUri, $curUri) {
13			$this->prevUri = $prevUri;
14			$this->curUri = $curUri;
15			}
16
17			public function __destruct() {
18			foreach ($this->tmpNames as $file) {
19			@unlink($file);
			0 ignored issues – show Security Best Practice introduced 2015-12-16 20:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
20			}
21			}
22
23			public function iterateOverPaths($paths, $rpms, $verbose=false) {
24			$iRpms = array_flip(array_map('strtolower', $rpms));
25			foreach ($paths as $path) {
26			$versionPath = $path.'/VERSION';
27			$curVersion = $this->getCurrentVersion($versionPath);
28			try {
29			$prevVersion = $this->getPreviousVersion($versionPath);
30			$this->displayOneLine($path, $curVersion, $prevVersion, $iRpms, $verbose);
31			} catch(Exception $e) {
32			echo "Impossible to get previous $versionPath. It's normal if it's new in this release. Otherwise, please check\n";
33			}
34			}
35			}
36
37			public function displayOneLine($path, $curVersion, $prevVersion, $iRpms, $verbose) {
38			$versionOk = version_compare($curVersion, $prevVersion, '>');
39			if ($verbose \|\| !$versionOk) {
40			$flag = '';
41			$name = basename($path);
42			if (isset($iRpms[strtolower($name)])) {
43			if ($versionOk) {
44			$flag .= self::COLOR_GREEN;
45			} else {
46			$flag .= self::COLOR_RED;
47			}
48			$flag .= '[RPM] ';
49			}
50			echo "\t$flag".$path.": ".$curVersion.' (Previous release was: '.$prevVersion.')'.self::COLOR_NOCOLOR.PHP_EOL;
51			}
52			}
53
54			public function getCurrentVersion($relPath) {
55			if (is_dir($this->curUri)) {
56			return $this->getVersionContent($this->curUri.$relPath);
57			} else {
58			return $this->getRemoteVersion($this->curUri.$relPath);
59			}
60			}
61
62			public function getPreviousVersion($relPath) {
63			return $this->getRemoteVersion($this->prevUri.$relPath);
64			}
65
66			protected function getRemoteVersion($url) {
67			$filePath = $this->getRemoteFile($url);
68			return $this->getVersionContent($filePath);
69			}
70
71			protected function getRemoteFile($url) {
72			$name = tempnam('/tmp', 'codendi_release_');
73			$this->tmpNames[] = $name;
74			$output = array();
75			$retVal = false;
76			exec('svn cat '.$url.' 2>/dev/null > '.$name, $output, $retVal);
77			if ($retVal === 0) {
78			return $name;
79			}
80			throw new Exception('Impossible to get remote file: '.$url);
81			}
82
83			protected function getVersionContent($filePath) {
84			return trim(file_get_contents($filePath));
85			}
86
87			}
88
89			class PluginReleaseVersionComparator extends ReleaseVersionComparator {
90
91			public function __construct($prevUri, $curUri, $fpd) {
92			parent::__construct($prevUri, $curUri);
93			$this->fpd = $fpd;
94			}
95
96			public function getPreviousVersion($relPath) {
97			try {
98			return $this->getRemoteVersion($this->prevUri.$relPath);
99			} catch (Exception $e) {
100			$pluginRoot = dirname($relPath);
101			$pluginName = basename($pluginRoot);
102			$path = $this->fpd->findDescriptor($this->curUri.$pluginRoot);
103			$relPath = substr($path, -(strlen($path)-strlen($this->curUri)));
104
105			// Get descriptor
106			$oldDescPath = $this->getRemoteFile($this->prevUri.$relPath);
107			$oldDesc = $this->fpd->getDescriptorFromFile($pluginName, $oldDescPath);
108			return $oldDesc->getVersion();
109			}
110			throw new Exception('No way to get the previous version number');
			0 ignored issues – show Unused Code introduced 2015-12-16 20:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this `throw new \Exception('No...vious version number');` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
111			}
112
113			}
114
115			?>

GitHub Access Token became invalid

Issues (4873)

Security Analysis not enabled

tools/rpm/ReleaseVersionComparator.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Enalean / tuleap

GitHub Access Token became invalid

Issues (4873)

Security Analysis not enabled

tools/rpm/ReleaseVersionComparator.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like