Issues in RendererPresenter.class.php (master) - Issues in master - Enalean/tuleap - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4873)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

cardwall/include/RendererPresenter.class.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Copyright (c) Enalean, 2012-2015. All Rights Reserved.
 *
 * This file is a part of Tuleap.
 *
 * Tuleap is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * Tuleap is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with Tuleap. If not, see <http://www.gnu.org/licenses/>.
 */


/**
 * The content of the renderer
 */
class Cardwall_RendererPresenter extends Cardwall_BoardPresenter {

    /**
     * @var Tracker_FormElement_Field_Selectbox
     */
    public $field;

    /**
     * @var bool
     */
    public $has_columns;

    /**
     * @var string
     */
    public $warn_please_choose;

    /**
     * @var string
     */
    public $warn_no_values;

    public $is_display_avatar_selected = "";

    /**
     * @param Cardwall_Board $board The board
     * @param string $redirect_parameter the redirect paramter to add to various url
     * @param Tracker_FormElement_Field_Selectbox $field form to choose the column. false if no form (in widget) (thus no typehinting)
     * @param $form
     */
    public function __construct(Cardwall_Board $board, $redirect_parameter, $field, $form) {
        parent::__construct($board, $redirect_parameter);
        $hp                        = Codendi_HTMLPurifier::instance();
        $this->nifty               = Toggler::getClassname('cardwall_board-nifty') == 'toggler' ? 'nifty' : false;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->swimline_title      = '';
        $this->has_swimline_header = false;
        $this->field               = $field ? $field : false;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->form                = $form  ? $form  : false;
        $this->has_columns         = count($this->board->columns) > 0;
        $this->warn_please_choose  = $GLOBALS['Language']->getText('plugin_cardwall', 'warn_please_choose');
        $field_label               = $field ? $hp->purify($this->field->getLabel()) : '###';
        $this->warn_no_values      = $GLOBALS['Language']->getText('plugin_cardwall', 'warn_no_values', $field_label);
    }
}


GitHub Access Token became invalid

Issues (4873)

Security Analysis not enabled

cardwall/include/RendererPresenter.class.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1			<?php
2			/**
3			* Copyright (c) Enalean, 2012-2015. All Rights Reserved.
4			*
5			* This file is a part of Tuleap.
6			*
7			* Tuleap is free software; you can redistribute it and/or modify
8			* it under the terms of the GNU General Public License as published by
9			* the Free Software Foundation; either version 2 of the License, or
10			* (at your option) any later version.
11			*
12			* Tuleap is distributed in the hope that it will be useful,
13			* but WITHOUT ANY WARRANTY; without even the implied warranty of
14			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15			* GNU General Public License for more details.
16			*
17			* You should have received a copy of the GNU General Public License
18			* along with Tuleap. If not, see <http://www.gnu.org/licenses/>.
19			*/
20
21
22			/**
23			* The content of the renderer
24			*/
25			class Cardwall_RendererPresenter extends Cardwall_BoardPresenter {
26
27			/**
28			* @var Tracker_FormElement_Field_Selectbox
29			*/
30			public $field;
31
32			/**
33			* @var bool
34			*/
35			public $has_columns;
36
37			/**
38			* @var string
39			*/
40			public $warn_please_choose;
41
42			/**
43			* @var string
44			*/
45			public $warn_no_values;
46
47			public $is_display_avatar_selected = "";
48
49			/**
50			* @param Cardwall_Board $board The board
51			* @param string $redirect_parameter the redirect paramter to add to various url
52			* @param Tracker_FormElement_Field_Selectbox $field form to choose the column. false if no form (in widget) (thus no typehinting)
53			* @param $form
54			*/
55			public function __construct(Cardwall_Board $board, $redirect_parameter, $field, $form) {
56			parent::__construct($board, $redirect_parameter);
57			$hp = Codendi_HTMLPurifier::instance();
58			$this->nifty = Toggler::getClassname('cardwall_board-nifty') == 'toggler' ? 'nifty' : false;
			0 ignored issues – show Documentation Bug introduced 2015-12-16 20:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\Toggler::getClassname('...gler' ? 'nifty' : false` can also be of type `false`. However, the property `$nifty` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
59			$this->swimline_title = '';
60			$this->has_swimline_header = false;
61			$this->field = $field ? $field : false;
			0 ignored issues – show Documentation Bug introduced 2015-12-16 20:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$field ? $field : false` can also be of type `false`. However, the property `$field` is declared as type `object<Tracker_FormElement_Field_Selectbox>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
62			$this->form = $form ? $form : false;
63			$this->has_columns = count($this->board->columns) > 0;
64			$this->warn_please_choose = $GLOBALS['Language']->getText('plugin_cardwall', 'warn_please_choose');
65			$field_label = $field ? $hp->purify($this->field->getLabel()) : '###';
66			$this->warn_no_values = $GLOBALS['Language']->getText('plugin_cardwall', 'warn_no_values', $field_label);
67			}
68			}
69

Enalean / tuleap

GitHub Access Token became invalid

Issues (4873)

Security Analysis not enabled

cardwall/include/RendererPresenter.class.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like