Enalean / tuleap

plugins/agiledashboard/include/AgileDashboardRouterBuilder.php

Doc Comments +6 added lines

@@ -125,6 +125,8 @@ 
     }
 
     /**
+     * @param Codendi_Request $request
+     * @param AgileDashboard_Milestone_Pane_PanePresenterBuilderFactory $pane_presenter_builder_factory
      * @return Planning_VirtualTopMilestonePaneFactory
      */
     private function getTopMilestonePaneFactory(
@@ -143,6 +145,10 @@ 
         );
     }
 
+    /**
+     * @param Planning_MilestoneFactory $milestone_factory
+     * @param AgileDashboard_PaneInfoFactory $pane_info_factory
+     */
     private function getPanePresenterBuilderFactory($milestone_factory, $pane_info_factory) {
         $icon_factory = new AgileDashboard_PaneIconLinkPresenterCollectionFactory($pane_info_factory);
 

plugins/agiledashboard/include/Planning/ArtifactLinker.class.php

Doc Comments +3 added lines

@@ -72,6 +72,9 @@
         return $source_artifact;
     }
 
+    /**
+     * @param string $key
+     */
     private function getSourceArtifact(Codendi_Request $request, $key) {
         $artifact_id = (int) $request->getValidated($key, 'uint', 0);
         return $this->artifact_factory->getArtifactById($artifact_id);

plugins/agiledashboard/include/Planning/ArtifactMilestone.class.php

Doc Comments +6 added lines, -2 removed lines

@@ -223,6 +223,10 @@ 
         return $artifacts;
     }
 
+    /**
+     * @param Tracker_Artifact[] $artifacts
+     * @param PFUser $user
+     */
     private function addChildrenNodes(ArtifactNode $root_node, &$artifacts, $user) {
         foreach ($root_node->getChildren() as $node) {
             $artifact    = $node->getObject();
@@ -307,7 +311,7 @@ 
     /**
      * @param array $artifacts_ids
      * @param PFUser $user
-     * @return Boolean True if nothing went wrong
+     * @return boolean|null True if nothing went wrong
      */
     public function solveInconsistencies(PFUser $user, array $artifacts_ids) {
         $success  = true;
@@ -327,7 +331,7 @@ 
 
     /**
      * @see Planning_Milestone::getDuration()
-     * @return float
+     * @return integer
      */
     public function getDuration() {
         return $this->duration;

plugins/agiledashboard/include/Planning/MilestoneController.class.php

Doc Comments +1 added lines, -1 removed lines

@@ -51,7 +51,7 @@
      *   - pass $request to actions (e.g. show).
      *
      * @param Codendi_Request           $request
-     * @param PlanningFactory           $planning_factory
+     * @param PlanningFactory           $pane_factory
      * @param Planning_MilestoneFactory $milestone_factory
      */
     public function __construct(

plugins/agiledashboard/include/Planning/MilestoneControllerFactory.class.php

Doc Comments +1 added lines, -1 removed lines

@@ -83,7 +83,7 @@
      *
      * @param Codendi_Request $request
      *
-     * @return Planning_MilestoneController
+     * @return Planning_VirtualTopMilestoneController
      */
     public function getVirtualTopMilestoneController(Codendi_Request $request) {
         return new Planning_VirtualTopMilestoneController(

plugins/agiledashboard/include/Planning/MilestoneFactory.class.php

Doc Comments +16 added lines, -10 removed lines

@@ -102,6 +102,8 @@ 
     }
 
     /**
+     * @param integer $offset
+     * @param integer $number_to_fetch
      * @return array of Planning_Milestone (the last $number_to_fetch open ones for the given $planning)
      */
     public function getLastOpenMilestones(PFUser $user, Planning $planning, $offset, $number_to_fetch) {
@@ -132,7 +134,7 @@ 
      * @param  PFUser $user
      * @param  Integer $artifact_id
      *
-     * @return Planning_Milestone|null
+     * @return Planning_ArtifactMilestone|null
      */
     public function getBareMilestoneByArtifactId(PFUser $user, $artifact_id) {
         $artifact = $this->artifact_factory->getArtifactById($artifact_id);
@@ -148,7 +150,7 @@ 
      * @param  PFUser $user
      * @param  Integer $artifact_id
      *
-     * @return Planning_Milestone|null
+     * @return null|Planning_ArtifactMilestone
      */
     public function getValidatedBareMilestoneByArtifactId(PFUser $user, $artifact_id) {
         $artifact = $this->artifact_factory->getArtifactById($artifact_id);
@@ -164,7 +166,7 @@ 
     /**
      * @param PFUser $user
      * @param Tracker_Artifact $artifact
-     * @return Planning_Milestone|null
+     * @return Planning_ArtifactMilestone|null
      */
     public function getBareMilestoneByArtifact(PFUser $user, Tracker_Artifact $artifact) {
         $tracker  = $artifact->getTracker();
@@ -297,10 +299,9 @@ 
      * Retrieves the artifacts planned for the given milestone artifact.
      *
      * @param PFUser             $user
-     * @param Planning         $planning
      * @param Tracker_Artifact $milestone_artifact
      *
-     * @return TreeNode
+     * @return null|ArtifactNode
      */
     public function getPlannedArtifacts(PFUser             $user,
                                         Tracker_Artifact $milestone_artifact) {
@@ -315,12 +316,12 @@ 
     /**
      * Adds $parent_node children according to $artifact ones.
      *
-     * @param type $user
-     * @param type $artifact
-     * @param type $parent_node
+     * @param PFUser $user
+     * @param Tracker_Artifact $artifact
+     * @param TreeNode $parent_node
      * @param type $parents     The list of parents to prevent infinite recursion
      *
-     * @return boolean
+     * @return false|null
      */
     private function addChildrenPlannedArtifacts(PFUser             $user,
                                                  Tracker_Artifact $artifact,
@@ -337,6 +338,10 @@ 
         }
     }
 
+    /**
+     * @param PFUser $user
+     * @param Tracker_Artifact $artifact
+     */
     private function makeNodeWithChildren($user, $artifact, $parents) {
         $node = new ArtifactNode($artifact);
         $this->addChildrenPlannedArtifacts($user, $artifact, $node, $parents);
@@ -599,7 +604,7 @@ 
     /**
      * Create Milestones corresponding to an array of artifacts
      *
-     * @param Tracker_Artifact[] $artifact
+     * @param Tracker_Artifact[] $artifacts
      *
      * @return Planning_ArtifactMilestone[]
      */
@@ -741,6 +746,7 @@ 
     /**
      * Returns the last $quantity milestones - ordered by oldest first
      *
+     * @param integer $quantity
      * @return Planning_Milestone[]
      */
     public function getPastMilestones(PFUser $user, Planning $planning, $quantity) {

plugins/agiledashboard/include/Planning/MilestonePaneFactory.class.php

Doc Comments +1 added lines, -1 removed lines

@@ -103,7 +103,7 @@
         return $this->active_pane[$milestone->getArtifactId()];
     }
 
-    /** @return AgileDashboard_PaneInfo[] */
+    /** @return AgileDashboard_PaneInfo */
     public function getListOfPaneInfo(Planning_Milestone $milestone) {
         if (! isset($this->list_of_pane_info[$milestone->getArtifactId()])) {
             $this->buildListOfPaneInfo($milestone);

plugins/agiledashboard/include/Planning/MilestonePresenter.class.php

Doc Comments +7 added lines, -1 removed lines

@@ -51,6 +51,9 @@ 
      */
     private $presenter_data;
 
+    /**
+     * @param string $planning_redirect_to_new
+     */
     public function __construct(
             Planning_Milestone $milestone,
             PFUser $current_user,
@@ -111,7 +114,7 @@ 
     }
 
     /**
-     * @return array
+     * @return AgileDashboard_PaneInfo[]
      */
     public function getPaneInfoList() {
         return $this->presenter_data->getListOfPaneInfo();
@@ -140,6 +143,9 @@ 
         return $start_date && $end_date;
     }
 
+    /**
+     * @param integer $date
+     */
     private function formatDate($date) {
         return date($GLOBALS['Language']->getText('system', 'datefmt_day_and_month'), $date);
     }

plugins/agiledashboard/include/Planning/MilestoneRedirectParameter.class.php

Doc Comments +2 added lines, -1 removed lines

@@ -32,7 +32,8 @@
         return "planning[$pane_identifier][$planning_id]=$artifact_id";
     }
 
-    /** @return string */
+    /** @param string $pane_identifier
+/** @return string */
     public function getPlanningRedirectToNew(Planning_Milestone $milestone, $pane_identifier) {
         $planning_id = (int) $milestone->getPlanningId();