@@ -98,7 +98,7 @@ discard block |
||
98 | 98 | * |
99 | 99 | * @param Docman_ApprovalTable $table Approval table |
100 | 100 | * |
101 | - * @return Boolean |
|
101 | + * @return null|boolean |
|
102 | 102 | */ |
103 | 103 | private function notifyNextReviewer(Docman_ApprovalTable $table) { |
104 | 104 | $dao = new Docman_ApprovalTableReviewerDao(CodendiDataAccess::instance()); |
@@ -121,7 +121,7 @@ discard block |
||
121 | 121 | * @param Docman_ApprovalTable $table Approval table |
122 | 122 | * @param Integer $reviewerId Id of the reviewer |
123 | 123 | * |
124 | - * @return Boolean |
|
124 | + * @return null|boolean |
|
125 | 125 | */ |
126 | 126 | private function notifyIndividual(Docman_ApprovalTable $table, $reviewerId) { |
127 | 127 | $hp = Codendi_HTMLPurifier::instance(); |
@@ -191,7 +191,6 @@ discard block |
||
191 | 191 | /** |
192 | 192 | * Retrieve url to access a given docman item |
193 | 193 | * |
194 | - * @param Docman_Item $table The approval table that its reminder notification will be sent |
|
195 | 194 | * |
196 | 195 | * @return String |
197 | 196 | */ |
@@ -51,6 +51,9 @@ |
||
51 | 51 | return $this->rank; |
52 | 52 | } |
53 | 53 | |
54 | + /** |
|
55 | + * @param integer|null $v |
|
56 | + */ |
|
54 | 57 | function setReviewDate($v) { |
55 | 58 | $this->reviewDate = $v; |
56 | 59 | } |
@@ -76,6 +76,9 @@ discard block |
||
76 | 76 | return parent::prepareRanking($userId, $tableId, $rank, 'reviewer_id', 'table_id'); |
77 | 77 | } |
78 | 78 | |
79 | + /** |
|
80 | + * @param integer $userId |
|
81 | + */ |
|
79 | 82 | function addUser($tableId, $userId) { |
80 | 83 | $newRank = $this->prepareUserRanking($tableId, $userId, 'end'); |
81 | 84 | $sql = sprintf('INSERT INTO plugin_docman_approval_user'. |
@@ -146,6 +149,11 @@ discard block |
||
146 | 149 | return $this->_copyReviewers($srcTableId, $dstTableId, 'NULL', 0, "''", 'NULL'); |
147 | 150 | } |
148 | 151 | |
152 | + /** |
|
153 | + * @param string $date |
|
154 | + * @param string $comment |
|
155 | + * @param string $version |
|
156 | + */ |
|
149 | 157 | function _copyReviewers($srcTableId, $dstTableId, $date, $state, $comment, $version) { |
150 | 158 | $sql = 'INSERT INTO plugin_docman_approval_user'. |
151 | 159 | '(table_id, reviewer_id, rank, date, state, comment, version) '. |
@@ -158,6 +166,9 @@ discard block |
||
158 | 166 | return $this->update($sql); |
159 | 167 | } |
160 | 168 | |
169 | + /** |
|
170 | + * @param integer $state |
|
171 | + */ |
|
161 | 172 | function getAllReviewsForUserByState($userId, $state) { |
162 | 173 | // Item |
163 | 174 | $sql_item = 'SELECT u.table_id, i.item_id, i.group_id, t.date, i.title, g.group_name'. |
@@ -237,7 +237,7 @@ discard block |
||
237 | 237 | /** |
238 | 238 | * Add members of the given ugroup to the reviewer list. |
239 | 239 | * |
240 | - * @return true if at least one user was added to the list. |
|
240 | + * @return boolean if at least one user was added to the list. |
|
241 | 241 | */ |
242 | 242 | function addUgroup($ugroupId) { |
243 | 243 | $nbUserAdded = 0; |
@@ -316,6 +316,7 @@ discard block |
||
316 | 316 | |
317 | 317 | /** |
318 | 318 | * |
319 | + * @param integer $newTableId |
|
319 | 320 | */ |
320 | 321 | function newTableCopy($newTableId) { |
321 | 322 | $dao = $this->_getDao(); |
@@ -324,6 +325,7 @@ discard block |
||
324 | 325 | |
325 | 326 | /** |
326 | 327 | * |
328 | + * @param integer $newTableId |
|
327 | 329 | */ |
328 | 330 | function newTableReset($newTableId) { |
329 | 331 | $dao = $this->_getDao(); |
@@ -105,6 +105,8 @@ |
||
105 | 105 | |
106 | 106 | /** |
107 | 107 | * Did user access the wiki since the given version was published. |
108 | + * @param integer $groupId |
|
109 | + * @param integer $versionId |
|
108 | 110 | */ |
109 | 111 | function userAccessedSince($userId, $pageName, $groupId, $versionId) { |
110 | 112 | $sql = 'SELECT NULL'. |
@@ -45,6 +45,7 @@ discard block |
||
45 | 45 | * If there is no approval table linked to the item, pick-up the last |
46 | 46 | * version id of the wiki page. |
47 | 47 | * If there is no version for the given wiki page, default to 0. |
48 | + * @param Docman_Wiki $item |
|
48 | 49 | */ |
49 | 50 | function __construct($item, $versionNumber=null) { |
50 | 51 | parent::__construct($item); |
@@ -106,6 +107,9 @@ discard block |
||
106 | 107 | return $this->getTableFromVersion($this->item->getId(), $this->wikiVersionId); |
107 | 108 | } |
108 | 109 | |
110 | + /** |
|
111 | + * @param integer $version |
|
112 | + */ |
|
109 | 113 | function getTableFromVersion($itemId, $version) { |
110 | 114 | $table = null; |
111 | 115 | if($version !== null) { |
@@ -76,6 +76,9 @@ discard block |
||
76 | 76 | return $ret_id; |
77 | 77 | } |
78 | 78 | |
79 | + /** |
|
80 | + * @param string $field |
|
81 | + */ |
|
79 | 82 | private function _raiseMetadataChangeEvent(&$user, &$item, $group_id, $old, $new, $field) { |
80 | 83 | $logEventParam = array('group_id' => $group_id, |
81 | 84 | 'item' => &$item, |
@@ -1173,8 +1176,8 @@ discard block |
||
1173 | 1176 | * The force parameter must be set to true if you want to bypass permissions checking (@see permission_add_ugroup). |
1174 | 1177 | * Pretty difficult to know if a user can update the permissions which does not exist for a new item... |
1175 | 1178 | * |
1176 | - * @param $group_id integer The id of the project |
|
1177 | - * @param $item_id integer The id of the item |
|
1179 | + * @param integer $group_id integer The id of the project |
|
1180 | + * @param integer $item_id integer The id of the item |
|
1178 | 1181 | * @param $permission_definition array The definission of the permission (pretty name, relations between perms, internal name, ...) |
1179 | 1182 | * @param $old_permissions array The permissions before |
1180 | 1183 | * @param &$done_permissions array The permissions after |
@@ -1862,6 +1865,7 @@ discard block |
||
1862 | 1865 | |
1863 | 1866 | /** |
1864 | 1867 | * @access private |
1868 | + * @param Docman_ApprovalTableReviewerFactory $atrf |
|
1865 | 1869 | */ |
1866 | 1870 | function _approval_update_add_users($atrf, $usUserList, $sUgroups) { |
1867 | 1871 | $noError = true; |
@@ -1929,6 +1933,7 @@ discard block |
||
1929 | 1933 | |
1930 | 1934 | /** |
1931 | 1935 | * @access private |
1936 | + * @param Docman_ApprovalTableReviewerFactory $atrf |
|
1932 | 1937 | */ |
1933 | 1938 | function _approval_update_del_users($atrf, $selectedUsers) { |
1934 | 1939 | $deletedUsers = 0; |
@@ -1947,6 +1952,7 @@ discard block |
||
1947 | 1952 | |
1948 | 1953 | /** |
1949 | 1954 | * @access private |
1955 | + * @param Docman_ApprovalTableReviewerFactory $atrf |
|
1950 | 1956 | */ |
1951 | 1957 | function _approval_update_notify_users($atrf, $selectedUsers) { |
1952 | 1958 | $notifiedUsers = 0; |
@@ -1972,6 +1978,7 @@ discard block |
||
1972 | 1978 | |
1973 | 1979 | /** |
1974 | 1980 | * @access private |
1981 | + * @param Docman_ApprovalTableReviewerFactory $atrf |
|
1975 | 1982 | */ |
1976 | 1983 | function _approval_update_notif_resend($atrf) { |
1977 | 1984 | $res = $atrf->notifyReviewers(); |
@@ -145,6 +145,9 @@ |
||
145 | 145 | return $this->visitDocument($item, $params); |
146 | 146 | } |
147 | 147 | |
148 | + /** |
|
149 | + * @param Docman_Item $item |
|
150 | + */ |
|
148 | 151 | public function restrictAccess($item, $params = array()) { |
149 | 152 | // Check whether there is other references to this wiki page. |
150 | 153 | $dao = $this->_getItemDao(); |
@@ -164,6 +164,7 @@ discard block |
||
164 | 164 | * When a child of the source item is not found in the destination item, |
165 | 165 | * the search stops, the mapping is (obviously) not done and the source |
166 | 166 | * child and its future brothers are discared. |
167 | + * @param Docman_Folder $dstItem |
|
167 | 168 | */ |
168 | 169 | function compareFolderChildren($srcItem, $dstItem) { |
169 | 170 | $nodesToInspect = array(); |
@@ -210,6 +211,7 @@ discard block |
||
210 | 211 | |
211 | 212 | /** |
212 | 213 | * Search if there is an equivalent of $item in $parentId. |
214 | + * @param integer $parentId |
|
213 | 215 | */ |
214 | 216 | function searchMatchingItem($item, $parentId) { |
215 | 217 | $dao =& $this->getItemDao(); |