Enalean /
tuleap
| Conditions | 29 |
| Paths | > 20000 |
| Total Lines | 117 |
| Code Lines | 82 |
| Lines | 0 |
| Ratio | 0 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 247 | function outerTabs($params) { |
||
| 248 | global $Language,$sys_use_trove,$sys_use_snippet; |
||
| 249 | $selected_top_tab = ''; |
||
| 250 | if (isset($params['selected_top_tab'])) { |
||
| 251 | $selected_top_tab = $params['selected_top_tab']; |
||
| 252 | } |
||
| 253 | $menuTree = new TreeNode(); |
||
| 254 | $sthSelected = false; |
||
| 255 | |||
| 256 | $menuTree->addChild(new TreeNode(array('link'=>'/' |
||
| 257 | ,'title'=>$Language->getText('menu','home')))); |
||
| 258 | // We need to keep a reference on this node in order to set the |
||
| 259 | // selected value in the data. See bottom of this function. |
||
| 260 | $homeNode =& $menuTree->getChild(0); |
||
| 261 | |||
| 262 | |||
| 263 | if (user_isloggedin()) { |
||
| 264 | $selected = ((isset($params['selected_top_tab']) && $params['selected_top_tab'] == '/my/') || |
||
| 265 | strstr(getStringFromServer('REQUEST_URI'),'/my/') || |
||
| 266 | strstr(getStringFromServer('REQUEST_URI'),'/account/')); |
||
| 267 | $sthSelected = ($sthSelected || $selected); |
||
| 268 | $mynode = new TreeNode(array('link'=>'/my/' |
||
| 269 | ,'title'=>$Language->getText('menu','my_personal_page') |
||
| 270 | ,'selected'=>$selected)); |
||
| 271 | |||
| 272 | if($selected) { |
||
| 273 | $selected = (isset($params['selected_top_tab']) && $params['selected_top_tab'] == '/my/') || (boolean) strstr(getStringFromServer('REQUEST_URI'),'/my/'); |
||
| 274 | $mynode->addChild(new TreeNode(array('link'=>'/my/' |
||
| 275 | ,'title'=>$Language->getText('my_index','my_dashboard') |
||
| 276 | ,'selected'=>$selected))); |
||
| 277 | |||
| 278 | $selected = (boolean) strstr(getStringFromServer('REQUEST_URI'),'/account/'); |
||
| 279 | |||
| 280 | $mynode->addChild(new TreeNode(array('link'=>'/account/' |
||
| 281 | ,'title'=>$Language->getText('my_index','account_maintenance') |
||
| 282 | ,'selected'=>$selected))); |
||
| 283 | } |
||
| 284 | $menuTree->addChild($mynode); |
||
| 285 | |||
| 286 | } else { |
||
| 287 | $selected = (boolean) strstr(getStringFromServer('REQUEST_URI'),'/my/'); |
||
| 288 | $sthSelected = ($sthSelected || $selected); |
||
| 289 | $menuTree->addChild(new TreeNode(array('link'=>'/my/' |
||
| 290 | ,'title'=>$Language->getText('menu','my_personal_page') |
||
| 291 | ,'selected'=>$selected))); |
||
| 292 | } |
||
| 293 | |||
| 294 | if ($GLOBALS['sys_use_trove'] != 0 || (isset($params['group']) && $params['group'])) { |
||
| 295 | $selected = false; |
||
| 296 | if (isset($params['group']) && $params['group']) { |
||
| 297 | // get group info using the common result set |
||
| 298 | $pm = ProjectManager::instance(); |
||
| 299 | $project = $pm->getProject($params['group']); |
||
| 300 | if ($project && is_object($project)) { |
||
| 301 | if ($project->isError()) { |
||
| 302 | die('is error'); |
||
|
|
|||
| 303 | } else { |
||
| 304 | $sthSelected = true; |
||
| 305 | |||
| 306 | $projTree = $this->project_tabs($params['toptab'],$params['group']); |
||
| 307 | |||
| 308 | $projTree->setData(array('link'=>'/softwaremap/' |
||
| 309 | ,'title'=>$Language->getText('menu','projectree') |
||
| 310 | ,'selected'=>true)); |
||
| 311 | //'link'=>'/projects/'.$project->getUnixName().'/' |
||
| 312 | //,'title'=>$project->getPublicName() |
||
| 313 | //,'selected' => true)); |
||
| 314 | |||
| 315 | $menuTree->addChild($projTree); |
||
| 316 | } |
||
| 317 | } |
||
| 318 | } else { |
||
| 319 | $selected = (boolean) strstr(getStringFromServer('REQUEST_URI'),'softwaremap'); |
||
| 320 | $sthSelected = ($sthSelected || $selected); |
||
| 321 | $menuTree->addChild(new TreeNode(array('link'=>'/softwaremap/' |
||
| 322 | ,'title'=>$Language->getText('menu','projectree') |
||
| 323 | ,'selected'=>$selected))); |
||
| 324 | } |
||
| 325 | } |
||
| 326 | if ($GLOBALS['sys_use_snippet'] != 0) { |
||
| 327 | $selected = (boolean) strstr(getStringFromServer('REQUEST_URI'),'/snippet/'); |
||
| 328 | $sthSelected = ($sthSelected || $selected); |
||
| 329 | $menuTree->addChild(new TreeNode(array('link'=>'/snippet/' |
||
| 330 | ,'title'=>$Language->getText('menu','code_snippet') |
||
| 331 | ,'selected'=>$selected))); |
||
| 332 | } |
||
| 333 | |||
| 334 | if (user_ismember(1,'A')) { |
||
| 335 | $selected = strpos(getStringFromServer('REQUEST_URI'),'/admin/') === 0 || $selected_top_tab === 'admin'; |
||
| 336 | $sthSelected = ($sthSelected || $selected); |
||
| 337 | $menuTree->addChild(new TreeNode(array('link'=>'/admin/' |
||
| 338 | ,'title'=>$Language->getText('menu','admin') |
||
| 339 | ,'selected'=>$selected))); |
||
| 340 | } |
||
| 341 | |||
| 342 | $selected = (boolean) (strstr(getStringFromServer('REQUEST_URI'),'/site/') || $selected_top_tab === 'site'); |
||
| 343 | $sthSelected = ($sthSelected || $selected); |
||
| 344 | $menuTree->addChild(new TreeNode(array('link'=>'/site/' |
||
| 345 | ,'title'=>$Language->getText('include_layout','Help') |
||
| 346 | ,'selected'=>$selected))); |
||
| 347 | |||
| 348 | $additional_tabs = array(); |
||
| 349 | include $GLOBALS['Language']->getContent('layout/extra_tabs', null, null, '.php'); |
||
| 350 | foreach ($additional_tabs as $t) { |
||
| 351 | $sthSelected = ($sthSelected || $t['selected']); |
||
| 352 | $menuTree->addChild(new TreeNode($t)); |
||
| 353 | } |
||
| 354 | |||
| 355 | // Set selected value for 'home' link (this is the selected tab |
||
| 356 | // if no other was previously selected) |
||
| 357 | $homeNodeData =& $homeNode->getData(); |
||
| 358 | $homeNodeData['selected'] = !$sthSelected; |
||
| 359 | |||
| 360 | $buildMenuVisitor = new BuildMenuVisitor(); |
||
| 361 | $menuTree->accept($buildMenuVisitor); |
||
| 362 | echo $buildMenuVisitor->getHtml(); |
||
| 363 | } |
||
| 364 | |||
| 450 |
An exit expression should only be used in rare cases. For example, if you write a short command line script.
In most cases however, using an
exitexpression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage.