LanguageFilesTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	14
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	testLanguagesFiles()	0	11	3

<?php
/**
* Copyright (c) Xerox Corporation, Codendi Team, 2001-2009. All rights reserved
*
* 
*/

class LanguageFilesTest extends UnitTestCase {

    function testLanguagesFiles() {
        $cmd          = $GLOBALS['basedir'].'/src/utils/analyse_language_files.pl '.$GLOBALS['basedir'].' 2>&1';
        $return_value = 1;
        $output       = array();
        exec($cmd, $output, $return_value);
        $full_output = implode("\n", $output);
        if ($return_value != 0 || preg_match('/[1-9]\s*(missing|incorrect|duplicate) keys/', $full_output)) {

It seems like you are loosely comparing $return_value of type integer|null to 0; this is ambiguous as not only 0 == 0 is true, but null == 0 is true, too. Consider using a strict comparison ===.

            echo "<pre>\n$full_output\n</pre>";
            $this->fail();
        }
    }
}