BookControllerTest::testBookShowAllDeleteGET() - Code Metrics - Inspection of "Updated code to fix problems indecated" - EmilHacklin/MCV-v2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — main ( f3cfb1...17781b )

by Emil
created 2025-07-31 10:49 UTC
BookControllerTest::testBookShowAllDeleteGET() A

↳ Parent: BookControllerTest
Complexity

Conditions	2
Paths	2
Size

Total Lines	24
Code Lines	7
Duplication

Lines	0
Ratio	0 %
Importance

Changes	1
Bugs	1	Features	0
Metric	Value
cc	2
eloc	7
nc	2
nop	0
dl	0
loc	24
rs	10
c	1
b	1
f	0
<?php

namespace App\Tests\Controller;

use App\Repository\BookRepository;
use Doctrine\Persistence\ManagerRegistry;
use Symfony\Bundle\FrameworkBundle\KernelBrowser;
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\File\UploadedFile;
use Symfony\Component\HttpFoundation\Session\Session;
use Symfony\Component\Routing\RouterInterface;

class BookControllerTest extends WebTestCase
{
    private ?KernelBrowser $client = null;
    private ?int $createdBookId = null; // Store created book ID

    /**
     * testBookCreatePOST
     *
     * Test book_create_post route
     * @param  RouterInterface $router
     * @param  BookRepository $bookRepository
     * @return void
     */
    private function testBookCreatePOST(RouterInterface $router, BookRepository $bookRepository): void
    {
        // book_create_post
        $this->assertNotNull($this->client);

        // Generate URL from route name
        $url = $router->generate('book_create_post');

        // Create a mock UploadedFile
        $file = $this->createMock(UploadedFile::class);
        $file->method('isValid')->willReturn(true);
        $file->method('getMimeType')->willReturn('image/jpeg');
        $file->method('getClientOriginalName')->willReturn('test_image.jpg');
        $file->method('guessExtension')->willReturn('jpg');

        $formData = [
            'id' => 0,
            'title' => 'test book',
            'isbn' => '0000000000000',
            'author' => 'test author',
            'img' => $file,
        ];

        // Send POST request to the route
        $this->client->request('POST', $url, $formData);
                       request('POST', $url, $formData);

        // Assert that response is a redirect (302 status)
        $response = $this->client->getResponse();
        $this->assertTrue($response->isRedirect());

        $data = $bookRepository->readOneBookISBN('0000000000000');

        $this->assertEquals('test book', $data['book']['title']);
        $this->assertEquals('0000000000000', $data['book']['isbn']);
        $this->assertEquals('test author', $data['book']['author']);

        // After creating the book, store its ID
        $this->createdBookId = $data['book']['id'];

        // Test if title is null
        $this->assertNotNull($this->client);

        $formData = [
            'id' => 0,
            'title' => '',
            'isbn' => '000000000001',
            'author' => 'test author',
            'img' => $file,
        ];

        // Send POST request to the route
        $this->client->request('POST', $url, $formData);

        $data = $bookRepository->readOneBookISBN('0000000000001');

        $this->assertNull($data['book']['author']);
    }

    /**
     * testBookUpdatePOST
     *
     * Test book_update_post route
     *
     * @param  RouterInterface $router
     * @param  BookRepository $bookRepository
     * @return void
     */
    private function testBookUpdatePOST(RouterInterface $router, BookRepository $bookRepository): void
    {
        $this->assertNotNull($this->client);

        // Create a mock UploadedFile
        $file = $this->createMock(UploadedFile::class);
        $file->method('isValid')->willReturn(true);
        $file->method('getMimeType')->willReturn('image/jpeg');
        $file->method('getClientOriginalName')->willReturn('test_image1.jpg');
        $file->method('guessExtension')->willReturn('jpg');

        $formData = [
            'id' => $this->createdBookId,
            'title' => 'test book 2',
            'isbn' => '0000000000001',
            'author' => 'test author 2',
            'img' => $file,
        ];

        // Generate URL from route name
        $url = $router->generate('book_update_post', ['id' => (int) $this->createdBookId]);

        // Send POST request to the route
        $this->client->request('POST', $url, $formData);

        // Assert that response is a redirect (302 status)
        $response = $this->client->getResponse();
        $this->assertTrue($response->isRedirect());

        $data = $bookRepository->readOneBook((int) $this->createdBookId);

        $this->assertEquals('test book 2', $data['book']['title']);

        //Test if book don't exist
        $this->assertNotNull($this->client);

        $data = $bookRepository->readAllBooks();

        // Extract all existing IDs
        $existingIds = array_map(function ($book) {
            return $book['id'];
        }, $data['books']);

        // Find the smallest missing integer starting from 1
        $missingId = null;
        for ($i = 1; ; $i++) {
            if (!in_array($i, $existingIds, true)) {
                $missingId = $i;
                break;
            }
        }

        $formData = [
            'id' => (int) $missingId,
            'title' => 'test book 1',
            'isbn' => '0000000000000',
            'author' => 'test author 1',
            'img' => $file,
        ];

        // Generate URL from route name
        $url = $router->generate('book_update_post', ['id' => (int) $missingId]);

        // Send POST request to the route
        $this->client->request('POST', $url, $formData);

        // Assert that response is a redirect (302 status)
        $response = $this->client->getResponse();
        $this->assertTrue($response->isRedirect());

        $data = $bookRepository->readOneBook((int) $missingId);

        $this->assertNull($data['book']['author']);

        // Test if title is null
        $this->assertNotNull($this->client);

        $formData = [
            'id' => $this->createdBookId,
            'title' => '',
            'isbn' => '0000000000000',
            'author' => 'test author 1',
            'img' => $file,
        ];

        // Generate URL from route name
        $url = $router->generate('book_update_post', ['id' => (int) $this->createdBookId]);

        // Send POST request to the route
        $this->client->request('POST', $url, $formData);

        // Assert that response is a redirect (302 status)
        $response = $this->client->getResponse();
        $this->assertTrue($response->isRedirect());

        $data = $bookRepository->readOneBook((int) $this->createdBookId);

        $this->assertEquals('test book 2', $data['book']['title']);
    }

    /**
     * testBookDeletePOST
     *
     * Test book_delete_post route
     *
     * @param  RouterInterface $router
     * @return void
     */
    private function testBookDeletePOST(RouterInterface $router): void
    {
        $this->assertNotNull($this->client);

        $formData = [
            'id' => (int) $this->createdBookId,
        ];

        //book_delete_post

        // Generate URL from route name
        $url = $router->generate('book_delete_post', ['id' => (int)$this->createdBookId]);

        // Send POST request to the route
        $this->client->request('POST', $url, $formData);

        // Assert that response is a redirect (302 status)
        $response = $this->client->getResponse();
        $this->assertTrue($response->isRedirect());

        // Reset the ID to prevent repeated deletions
        $this->createdBookId = null;

        //Test to delete book that don't exists
        $this->assertNotNull($this->client);

        // Send POST request to the route
        $this->client->request('POST', $url, $formData);

        // Assert that response is a redirect (302 status)
        $response = $this->client->getResponse();
        $this->assertTrue($response->isRedirect());
    }

    /**
     * tearDown
     *
     * @return void
     */
    protected function tearDown(): void
    {
        parent::tearDown();

        if ($this->createdBookId !== null) {
            if (null === $this->client) {
                // Create a client to browse the application
                $this->client = static::createClient();
            }

            // Get the router
            /** @var RouterInterface $router */
            $router = static::getContainer()->get('router');

            // Generate delete URL
            $deleteUrl = $router->generate('book_delete_post', ['id' => $this->createdBookId]);

            // Send delete request
            $this->client->request('POST', $deleteUrl, ['id' => $this->createdBookId]);

            // Reset the ID to prevent repeated deletions
            $this->createdBookId = null;
        }
    }

    /**
     * testCRUD
     *
     * @return void
     */
    public function testCRUD(): void
    {
        if (null === $this->client) {
            // Create a client to browse the application
            $this->client = static::createClient();
        }

        // Retrieve the container
        $container = $this->client->getContainer();

        // Retrieve router service
        /** @var RouterInterface $router */
        $router = $container->get('router');

        // Get the ManagerRegistry service from container
        /** @var ManagerRegistry $doctrine */
        $doctrine = $container->get('doctrine');

        $bookRepository = new BookRepository($doctrine);

        // Test Create Book
        $this->testBookCreatePOST($router, $bookRepository);

        // Test Update Book
        $this->testBookUpdatePOST($router, $bookRepository);

        // Test Delete Book
        $this->testBookDeletePOST($router);
    }

    /**
     * testLibrary
     *
     * Test library route
     *
     * @return void
     */
    public function testLibrary(): void
    {
        if (null === $this->client) {
            // Create a client to browse the application
            $this->client = static::createClient();
        }

        // Retrieve router service
        /** @var RouterInterface $router */
        $router = static::getContainer()->get('router');

        //library

        // Generate URL from route name
        $url = $router->generate('library');

        // Send a GET request to the route
        $crawler = $this->client->request('GET', $url);

        // Assert the response status code
        $this->assertEquals(200, $this->client->getResponse()->getStatusCode());

        // Assert that certain content exists in the response
        $this->assertStringContainsString('Book: Library', $crawler->filter('title')->text());
    }

    /**
     * testBookCreateGET
     *
     * Test book_create_get route
     *
     * @return void
     */
    public function testBookCreateGET(): void
    {
        if (null === $this->client) {
            // Create a client to browse the application
            $this->client = static::createClient();
        }

        // Retrieve router service
        /** @var RouterInterface $router */
        $router = static::getContainer()->get('router');

        //book_create_get

        // Generate URL from route name
        $url = $router->generate('book_create_get');

        // Send a GET request to the route
        $crawler = $this->client->request('GET', $url);

        // Assert the response status code
        $this->assertEquals(200, $this->client->getResponse()->getStatusCode());

        // Assert that certain content exists in the response
        $this->assertStringContainsString('Book: Create', $crawler->filter('title')->text());
    }

    /**
     * testShowAll
     *
     * Test book_show_all route
     *
     * @return void
     */
    public function testShowAll(): void
    {
        if (null === $this->client) {
            // Create a client to browse the application
            $this->client = static::createClient();
        }

        // Retrieve router service
        /** @var RouterInterface $router */
        $router = static::getContainer()->get('router');

        //book_show_all

        // Generate URL from route name
        $url = $router->generate('book_show_all');

        // Send a GET request to the route
        $crawler = $this->client->request('GET', $url);

        // Assert the response status code
        $this->assertEquals(200, $this->client->getResponse()->getStatusCode());

        // Assert that certain content exists in the response
        $this->assertStringContainsString('Book: Show Library', $crawler->filter('title')->text());
    }

    /**
     * testShowOne
     *
     * Test book_show_one route
     *
     * @return void
     */
    public function testShowOne(): void
    {
        if (null === $this->client) {
            // Create a client to browse the application
            $this->client = static::createClient();
        }

        // Retrieve router service
        /** @var RouterInterface $router */
        $router = static::getContainer()->get('router');

        // Boot the kernel
        $kernel = self::bootKernel();

        // Get the ManagerRegistry service from container
        /** @var ManagerRegistry $doctrine */
        $doctrine = $kernel->getContainer()->get('doctrine');
        $bookRepository = new BookRepository($doctrine);

        $data = $bookRepository->readAllBooks();

        //If there is books in the library
        $id = null;

        if (count($data['books']) > 0) {
            $id = $data['books'][0]['id'];
        }

        if (null === $id) {
            $id = '0';
        }

        //book_show_one

        // Generate URL from route name
        $url = $router->generate('book_show_one', ['id' => $id]);

        // Send a GET request to the route
        $crawler = $this->client->request('GET', $url);

        // Assert the response status code
        $this->assertEquals(200, $this->client->getResponse()->getStatusCode());

        // Assert that certain content exists in the response
        $this->assertStringContainsString('Book: Show Book', $crawler->filter('title')->text());
    }

    /**
     * testShowAllUpdate
     *
     * Test book_show_all_update route
     *
     * @return void
     */
    public function testShowAllUpdate(): void
    {
        if (null === $this->client) {
            // Create a client to browse the application
            $this->client = static::createClient();
        }

        // Retrieve router service
        /** @var RouterInterface $router */
        $router = static::getContainer()->get('router');

        //book_show_all_update

        // Generate URL from route name
        $url = $router->generate('book_show_all_update');

        // Send a GET request to the route
        $crawler = $this->client->request('GET', $url);

        // Assert the response status code
        $this->assertEquals(200, $this->client->getResponse()->getStatusCode());

        // Assert that certain content exists in the response
        $this->assertStringContainsString('Book: Show Library Update', $crawler->filter('title')->text());
    }

    /**
     * testBookUpdateGET
     *
     * Test book_update_get route
     *
     * @return void
     */
    public function testBookUpdateGET(): void
    {
        if (null === $this->client) {
            // Create a client to browse the application
            $this->client = static::createClient();
        }

        // Retrieve router service
        /** @var RouterInterface $router */
        $router = static::getContainer()->get('router');

        // Boot the kernel
        $kernel = self::bootKernel();

        // Get the ManagerRegistry service from container
        /** @var ManagerRegistry $doctrine */
        $doctrine = $kernel->getContainer()->get('doctrine');
        $bookRepository = new BookRepository($doctrine);

        $data = $bookRepository->readAllBooks();

        //If there is books in the library
        $id = null;

        if (count($data['books']) > 0) {
            $id = $data['books'][0]['id'];
        }

        if (null === $id) {
            $id = '0';
        }

        //book_update_get

        // Generate URL from route name
        $url = $router->generate('book_update_get', ['id' => $id]);

        // Send a GET request to the route
        $crawler = $this->client->request('GET', $url);

        // Assert the response status code
        $this->assertEquals(200, $this->client->getResponse()->getStatusCode());

        // Assert that certain content exists in the response
        $this->assertStringContainsString('Book: Update book', $crawler->filter('title')->text());
    }

    /**
     * testBookShowAllDeleteGET
     *
     * Test book_show_all_delete_get route
     *
     * @return void
     */
    public function testBookShowAllDeleteGET(): void
    {
        if (null === $this->client) {
            // Create a client to browse the application
            $this->client = static::createClient();
        }

        // Retrieve router service
        /** @var RouterInterface $router */
        $router = static::getContainer()->get('router');

        //book_show_all_delete_get

        // Generate URL from route name
        $url = $router->generate('book_show_all_delete_get');

        // Send a GET request to the route
        $crawler = $this->client->request('GET', $url);

        // Assert the response status code
        $this->assertEquals(200, $this->client->getResponse()->getStatusCode());

        // Assert that certain content exists in the response
        $this->assertStringContainsString('Book: Show Library Delete', $crawler->filter('title')->text());
    }
}

EmilHacklin / MCV-v2

Push — main ( f3cfb1...17781b )

BookControllerTest::testBookShowAllDeleteGET() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like
