Player::calculateHandValue() - Code Metrics - Inspection of "Updated code to fix problems indecated" - EmilHacklin/MCV-v2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( f3cfb1...17781b )

by Emil

created 2025-07-31 10:49 UTC

Player::calculateHandValue() A

↳ Parent: Player

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
cc	2
eloc	4
nc	2
nop	0
dl	0
loc	8
rs	10
c	1
b	1
f	0
ccs	5
cts	5
cp	1
crap	2

<?php

namespace App\Game\BlackJack;

use App\Cards\Card;
use App\Cards\CardHand;

/**
 * Player.
 */
class Player extends CardHand
{
    protected int $handValue;
    protected bool $isBust;

    /**
     * checkIsBust.
     */
    protected function checkIsBust(): void
    {
        ($this->handValue > 21) ? $this->isBust = true : $this->isBust = false;
    }

    /**
     * calculateHandValue.
     */
    protected function calculateHandValue(): void
    {
        $lowValue = $this->getBlackJackValue();
        $highValue = $this->getBlackJackValueAceHigh();

        $this->handValue = ($highValue > 21) ? $lowValue : $highValue;

        $this->checkIsBust();
    }

    /**
     * isBust.
     */
    public function isBust(): bool
    {
        return $this->isBust;
    }

    /**
     * getHandValue.
     */
    public function getHandValue(): int
    {
        return $this->handValue;
    }

    /**
     * addCard.
     */
    public function addCard(Card $card): void
    {
        parent::addCard($card);

        $this->calculateHandValue();
    }
}


1		<?php
2
3		namespace App\Game\BlackJack;
4
5		use App\Cards\Card;
6		use App\Cards\CardHand;
7
8		/**
9		* Player.
10		*/
11		class Player extends CardHand
12		{
13		protected int $handValue;
14		protected bool $isBust;
15
16		/**
17		* checkIsBust.
18		*/
19	16	protected function checkIsBust(): void
20		{
21	16	($this->handValue > 21) ? $this->isBust = true : $this->isBust = false;
22		}
23
24		/**
25		* calculateHandValue.
26		*/
27	16	protected function calculateHandValue(): void
28		{
29	16	$lowValue = $this->getBlackJackValue();
30	16	$highValue = $this->getBlackJackValueAceHigh();
31
32	16	$this->handValue = ($highValue > 21) ? $lowValue : $highValue;
33
34	16	$this->checkIsBust();
35		}
36
37		/**
38		* isBust.
39		*/
40	7	public function isBust(): bool
41		{
42	7	return $this->isBust;
43		}
44
45		/**
46		* getHandValue.
47		*/
48	10	public function getHandValue(): int
49		{
50	10	return $this->handValue;
51		}
52
53		/**
54		* addCard.
55		*/
56	16	public function addCard(Card $card): void
57		{
58	16	parent::addCard($card);
59
60	16	$this->calculateHandValue();
61		}
62		}
63

EmilHacklin / MCV-v2

Push — main ( f3cfb1...17781b )

Player::calculateHandValue() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like