Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | View Code Duplication | trait SalesforceTrait |
|
|
|||
8 | { |
||
9 | /** |
||
10 | * Salesforce username. |
||
11 | * |
||
12 | * @var string|null |
||
13 | * |
||
14 | * @ORM\Column(nullable = true) |
||
15 | */ |
||
16 | private $salesforceUsername; |
||
17 | |||
18 | /** |
||
19 | * Salesforce nickname. |
||
20 | * |
||
21 | * @var string|null |
||
22 | * |
||
23 | * @ORM\Column(nullable = true) |
||
24 | */ |
||
25 | private $salesforceNickname; |
||
26 | |||
27 | /** |
||
28 | * Salesforce first name. |
||
29 | * |
||
30 | * @var string|null |
||
31 | * |
||
32 | * @ORM\Column(nullable = true) |
||
33 | */ |
||
34 | private $salesforceFirstName; |
||
35 | |||
36 | /** |
||
37 | * Salesforce last name. |
||
38 | * |
||
39 | * @var string|null |
||
40 | * |
||
41 | * @ORM\Column(nullable = true) |
||
42 | */ |
||
43 | private $salesforceLastName; |
||
44 | |||
45 | /** |
||
46 | * Salesforce real name. |
||
47 | * |
||
48 | * @var string|null |
||
49 | * |
||
50 | * @ORM\Column(nullable = true) |
||
51 | */ |
||
52 | private $salesforceRealName; |
||
53 | |||
54 | /** |
||
55 | * Salesforce profilePicture. |
||
56 | * |
||
57 | * @var string|null |
||
58 | * |
||
59 | * @ORM\Column(nullable = true) |
||
60 | */ |
||
61 | private $salesforceEmail; |
||
62 | |||
63 | /** |
||
64 | * Salesforce profile picture. |
||
65 | * |
||
66 | * @var string|null |
||
67 | * |
||
68 | * @ORM\Column(nullable = true) |
||
69 | */ |
||
70 | private $salesforceProfilePicture; |
||
71 | |||
72 | /** |
||
73 | * Salesforce access token. |
||
74 | * |
||
75 | * @var string|null |
||
76 | * |
||
77 | * @ORM\Column(nullable = true) |
||
78 | */ |
||
79 | private $salesforceAccessToken; |
||
80 | |||
81 | /** |
||
82 | * Salesforce refresh token. |
||
83 | * |
||
84 | * @var string|null |
||
85 | * |
||
86 | * @ORM\Column(nullable = true) |
||
87 | */ |
||
88 | private $salesforceRefreshToken; |
||
89 | |||
90 | /** |
||
91 | * Salesforce expires in. |
||
92 | * |
||
93 | * @var string|null |
||
94 | * |
||
95 | * @ORM\Column(nullable = true) |
||
96 | */ |
||
97 | private $salesforceExpiresIn; |
||
98 | |||
99 | /** |
||
100 | * Salesforce data. |
||
101 | * |
||
102 | * @var array|null |
||
103 | * |
||
104 | * @ORM\Column(type = "json_array", nullable = true) |
||
105 | */ |
||
106 | private $salesforceData; |
||
107 | |||
108 | /** |
||
109 | * Get Salesforce access token. |
||
110 | * |
||
111 | * @return string|null |
||
112 | */ |
||
113 | 3 | public function getSalesforceAccessToken() |
|
117 | |||
118 | /** |
||
119 | * Gets the Salesforce data. |
||
120 | * |
||
121 | * @return array|null |
||
122 | */ |
||
123 | 3 | public function getSalesforceData() |
|
127 | |||
128 | /** |
||
129 | * Get Salesforce email. |
||
130 | * |
||
131 | * @return string|null |
||
132 | */ |
||
133 | 3 | public function getSalesforceEmail() |
|
137 | |||
138 | /** |
||
139 | * Get Salesforce expires in. |
||
140 | * |
||
141 | * @return string|null |
||
142 | */ |
||
143 | 3 | public function getSalesforceExpiresIn() |
|
147 | |||
148 | /** |
||
149 | * Get Salesforce first name. |
||
150 | * |
||
151 | * @return string|null |
||
152 | */ |
||
153 | 3 | public function getSalesforceFirstName() |
|
157 | |||
158 | /** |
||
159 | * Get Salesforce last name. |
||
160 | * |
||
161 | * @return string|null |
||
162 | */ |
||
163 | 3 | public function getSalesforceLastName() |
|
167 | |||
168 | /** |
||
169 | * Get Salesforce nickname. |
||
170 | * |
||
171 | * @return string|null |
||
172 | */ |
||
173 | 3 | public function getSalesforceNickname() |
|
177 | |||
178 | /** |
||
179 | * Get Salesforce profile picture. |
||
180 | * |
||
181 | * @return string|null |
||
182 | */ |
||
183 | 3 | public function getSalesforceProfilePicture() |
|
187 | |||
188 | /** |
||
189 | * Get Salesforce real name. |
||
190 | * |
||
191 | * @return string|null |
||
192 | */ |
||
193 | 3 | public function getSalesforceRealName() |
|
197 | |||
198 | /** |
||
199 | * Get Salesforce refresh token. |
||
200 | * |
||
201 | * @return string|null |
||
202 | */ |
||
203 | 3 | public function getSalesforceRefreshToken() |
|
207 | |||
208 | /** |
||
209 | * Get Salesforce username. |
||
210 | * |
||
211 | * @return string|null |
||
212 | */ |
||
213 | 3 | public function getSalesforceUsername() |
|
217 | |||
218 | /** |
||
219 | * Set Salesforce access token. |
||
220 | * |
||
221 | * @param string|null $accessToken |
||
222 | * |
||
223 | * @return self |
||
224 | */ |
||
225 | 3 | public function setSalesforceAccessToken($accessToken) |
|
231 | |||
232 | /** |
||
233 | * Sets the Salesforce data. |
||
234 | * |
||
235 | * @param array|null $data |
||
236 | * |
||
237 | * @return self |
||
238 | */ |
||
239 | 3 | public function setSalesforceData(array $data = null) |
|
245 | |||
246 | /** |
||
247 | * Set Salesforce email. |
||
248 | * |
||
249 | * @param string|null $email |
||
250 | * |
||
251 | * @return self |
||
252 | */ |
||
253 | 3 | public function setSalesforceEmail($email) |
|
259 | |||
260 | /** |
||
261 | * Set Salesforce expires in. |
||
262 | * |
||
263 | * @param string|null $expiresIn |
||
264 | * |
||
265 | * @return self |
||
266 | */ |
||
267 | 3 | public function setSalesforceExpiresIn($expiresIn) |
|
273 | |||
274 | /** |
||
275 | * Set Salesforce first name. |
||
276 | * |
||
277 | * @param string|null $firstName |
||
278 | * |
||
279 | * @return self |
||
280 | */ |
||
281 | 3 | public function setSalesforceFirstName($firstName) |
|
287 | |||
288 | /** |
||
289 | * Set Salesforce last name. |
||
290 | * |
||
291 | * @param string|null $lastName |
||
292 | * |
||
293 | * @return self |
||
294 | */ |
||
295 | 3 | public function setSalesforceLastName($lastName) |
|
301 | |||
302 | /** |
||
303 | * Set Salesforce nickname. |
||
304 | * |
||
305 | * @param string|null $nickname |
||
306 | * |
||
307 | * @return self |
||
308 | */ |
||
309 | 3 | public function setSalesforceNickname($nickname) |
|
315 | |||
316 | /** |
||
317 | * Set Salesforce profile picture. |
||
318 | * |
||
319 | * @param string|null $profilePicture |
||
320 | * |
||
321 | * @return self |
||
322 | */ |
||
323 | 3 | public function setSalesforceProfilePicture($profilePicture) |
|
329 | |||
330 | /** |
||
331 | * Set Salesforce real name. |
||
332 | * |
||
333 | * @param string|null $realName |
||
334 | * |
||
335 | * @return self |
||
336 | */ |
||
337 | 3 | public function setSalesforceRealName($realName) |
|
343 | |||
344 | /** |
||
345 | * Set Salesforce refresh token. |
||
346 | * |
||
347 | * @param string|null $refreshToken |
||
348 | * |
||
349 | * @return self |
||
350 | */ |
||
351 | 3 | public function setSalesforceRefreshToken($refreshToken) |
|
357 | |||
358 | /** |
||
359 | * Set Salesforce username. |
||
360 | * |
||
361 | * @param string|null $username |
||
362 | * |
||
363 | * @return self |
||
364 | */ |
||
365 | 3 | public function setSalesforceUsername($username) |
|
371 | } |
||
372 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.