UpdateManagerController::fetchUpdate() - Code Metrics - Inspection of "Add updates manager class and a few more patches" - Elimuswift/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (5a81ac)

by Albert

created 2017-02-13 16:50 UTC

UpdateManagerController::fetchUpdate() A

↳ Parent: UpdateManagerController

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	7

Duplication

Lines	11
Ratio	100 %

Importance

Changes

Metric	Value
dl	11
loc	11
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	7
nc	3
nop	1

<?php
namespace Elimuswift\Core\Controllers;

use App\Http\Controllers\Controller;
use Elimuswift\Core\Traits\VerifiesPurchase;
use Elimuswift\Core\Contacts\RepositoryContract;
use Elimuswift\Core\Contacts\CustomersRepository;

/**
* 
*/
class UpdateManagerController extends Controller

{
	// When including ths trait make sure you inject RepositoryContract as $repository and 
	// CustomersRepository as $customers to the constructor
	use VerifiesPurchase;
	
	/**
	 * Update Repository 
	 *
	 * @var mixed
	 **/
	public $repository;

	/**
	 * Customers Repository 
	 *
	 * @var mixed
	 **/
	public $customers;

	/**
	 * Create a new instance of the UpdatesManagerController::class
	 * 
	 **/	
	public function __construct(RepositoryContract $repository, CustomersRepository $customers)
	{
		$this->repository = $repository;
		$this->customers = $customers;
	}

	/**
	 * 
	 *
	 * @return mixed Illuminate\Http\Response
	 * @param $version Version to fetch 
	 **/
	public function fetchUpdate($version)
	{
		$this->getCustomer();
		if(null == $this->customer)
			return $this->invalidKeyResponse();
		$update = $this->repository->config('updates.updatesPath')."/update_{$version}.zip";
		if(file_exists($update)){
			return response()->download($update);
		}

	}
	
}

1		<?php
2		namespace Elimuswift\Core\Controllers;
3
4		use App\Http\Controllers\Controller;
5		use Elimuswift\Core\Traits\VerifiesPurchase;
6		use Elimuswift\Core\Contacts\RepositoryContract;
7		use Elimuswift\Core\Contacts\CustomersRepository;
8
9		/**
10		*
11		*/
12	View Code Duplication	class UpdateManagerController extends Controller
		0 ignored issues – show Duplication introduced 2017-02-13 16:27 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14		// When including ths trait make sure you inject RepositoryContract as $repository and
15		// CustomersRepository as $customers to the constructor
16		use VerifiesPurchase;
17
18		/**
19		* Update Repository
20		*
21		* @var mixed
22		**/
23		public $repository;
24
25		/**
26		* Customers Repository
27		*
28		* @var mixed
29		**/
30		public $customers;
31
32		/**
33		* Create a new instance of the UpdatesManagerController::class
34		*
35		**/
36		public function __construct(RepositoryContract $repository, CustomersRepository $customers)
37		{
38		$this->repository = $repository;
39		$this->customers = $customers;
40		}
41
42		/**
43		*
44		*
45		* @return mixed Illuminate\Http\Response
46		* @param $version Version to fetch
47		**/
48		public function fetchUpdate($version)
49		{
50		$this->getCustomer();
51		if(null == $this->customer)
52		return $this->invalidKeyResponse();
53		$update = $this->repository->config('updates.updatesPath')."/update_{$version}.zip";
54		if(file_exists($update)){
55		return response()->download($update);
56		}
57
58		}
59
60		}

Elimuswift / core

Branch — master (5a81ac)

UpdateManagerController::fetchUpdate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like