InstallManagerController::__construct() - Code Metrics - Inspection of "Add updates manager class and a few more patches" - Elimuswift/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (5a81ac)

by Albert

created 2017-02-13 16:50 UTC

InstallManagerController::__construct() A

↳ Parent: InstallManagerController

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	5
Ratio	100 %

Importance

Changes

Metric	Value
dl	5
loc	5
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	2

<?php
namespace Elimuswift\Core\Controllers;

use App\Http\Controllers\Controller;
use Elimuswift\Core\Traits\VerifiesPurchase;
use Elimuswift\Core\Contacts\RepositoryContract;
use Elimuswift\Core\Contacts\CustomersRepository;

/**
* 
*/
class InstallManagerController extends Controller

{
	/**
	* When including this trait make sure you inject RepositoryContract as $repository 
	* and CustomersRepository as $customers to the constructor
	*/
	use VerifiesPurchase;
	
	/**
	 * Update Repository 
	 *
	 * @var mixed $repository
	 **/
	public $repository;

	/**
	 * Customers Repository 
	 *
	 * @var mixed $customers
	 **/
	public $customers;

	/**
	 * Create a new instance of the UpdatesManagerController::class
	 * 
	 **/	
	public function __construct(RepositoryContract $repository, CustomersRepository $customers)
	{
		$this->repository = $repository;
		$this->customers = $customers;
	}

	/**
	 * Get the installer zip file for the version specified
	 * NOTE: The purchase key must be passed in the request for verification
	 *
	 * @return mixed Illuminate\Http\Response
	 * @param $version Version to fetch 
	 **/
	public function getInstaller($version)
	{
		$response = $this->verifyPurchase();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		if(null == $this->customer)
			return $this->invalidKeyResponse();
		$install = $this->repository->config('install.resourcePath')."/install_{$version}.zip";
		if(file_exists($install)){
			return response()->download($install);
		}

	}
	
}

1		<?php
2		namespace Elimuswift\Core\Controllers;
3
4		use App\Http\Controllers\Controller;
5		use Elimuswift\Core\Traits\VerifiesPurchase;
6		use Elimuswift\Core\Contacts\RepositoryContract;
7		use Elimuswift\Core\Contacts\CustomersRepository;
8
9		/**
10		*
11		*/
12	View Code Duplication	class InstallManagerController extends Controller
		0 ignored issues – show Duplication introduced 2017-02-13 16:27 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14		/**
15		* When including this trait make sure you inject RepositoryContract as $repository
16		* and CustomersRepository as $customers to the constructor
17		*/
18		use VerifiesPurchase;
19
20		/**
21		* Update Repository
22		*
23		* @var mixed $repository
24		**/
25		public $repository;
26
27		/**
28		* Customers Repository
29		*
30		* @var mixed $customers
31		**/
32		public $customers;
33
34		/**
35		* Create a new instance of the UpdatesManagerController::class
36		*
37		**/
38		public function __construct(RepositoryContract $repository, CustomersRepository $customers)
39		{
40		$this->repository = $repository;
41		$this->customers = $customers;
42		}
43
44		/**
45		* Get the installer zip file for the version specified
46		* NOTE: The purchase key must be passed in the request for verification
47		*
48		* @return mixed Illuminate\Http\Response
49		* @param $version Version to fetch
50		**/
51		public function getInstaller($version)
52		{
53		$response = $this->verifyPurchase();
		0 ignored issues – show Unused Code introduced 2017-02-13 16:27 UTC by Report Bug Copy Issue Report `$response` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
54		if(null == $this->customer)
55		return $this->invalidKeyResponse();
56		$install = $this->repository->config('install.resourcePath')."/install_{$version}.zip";
57		if(file_exists($install)){
58		return response()->download($install);
59		}
60
61		}
62
63		}

Elimuswift / core

Branch — master (5a81ac)

InstallManagerController::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like