Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | View Code Duplication | class UpdateManagerController extends Controller |
|
|
|||
11 | { |
||
12 | // When including ths trait make sure you inject RepositoryContract as $repository and |
||
13 | // CustomersRepository as $customers to the constructor |
||
14 | use VerifiesPurchase; |
||
15 | |||
16 | /** |
||
17 | * Update Repository. |
||
18 | * |
||
19 | * @var mixed |
||
20 | **/ |
||
21 | public $repository; |
||
22 | |||
23 | /** |
||
24 | * Customers Repository. |
||
25 | * |
||
26 | * @var mixed |
||
27 | **/ |
||
28 | public $customers; |
||
29 | |||
30 | /** |
||
31 | * Create a new instance of the UpdatesManagerController::class. |
||
32 | **/ |
||
33 | public function __construct(RepositoryContract $repository, CustomersRepository $customers) |
||
38 | |||
39 | /** |
||
40 | * @return mixed Illuminate\Http\Response |
||
41 | * |
||
42 | * @param $version Version to fetch |
||
43 | **/ |
||
44 | public function fetchUpdate($version) |
||
55 | } |
||
56 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.