InstallManagerController   A
last analyzed

Complexity

Total Complexity 4

Size/Duplication

Total Lines 51
Duplicated Lines 100 %

Coupling/Cohesion

Components 1
Dependencies 1

Importance

Changes 0
Metric Value
wmc 4
lcom 1
cbo 1
dl 51
loc 51
rs 10
c 0
b 0
f 0

2 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 5 5 1
A getInstaller() 11 11 3

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Elimuswift\Core\Controllers;
4
5
use App\Http\Controllers\Controller;
6
use Elimuswift\Core\Traits\VerifiesPurchase;
7
use Elimuswift\Core\Contacts\RepositoryContract;
8
use Elimuswift\Core\Contacts\CustomersRepository;
9
10 View Code Duplication
class InstallManagerController extends Controller
0 ignored issues
show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
11
{
12
    /*
13
    * When including this trait make sure you inject RepositoryContract as $repository
14
    * and CustomersRepository as $customers to the constructor
15
    */
16
    use VerifiesPurchase;
17
18
    /**
19
     * Update Repository.
20
     *
21
     * @var mixed
22
     **/
23
    public $repository;
24
25
    /**
26
     * Customers Repository.
27
     *
28
     * @var mixed
29
     **/
30
    public $customers;
31
32
    /**
33
     * Create a new instance of the UpdatesManagerController::class.
34
     **/
35
    public function __construct(RepositoryContract $repository, CustomersRepository $customers)
36
    {
37
        $this->repository = $repository;
38
        $this->customers = $customers;
39
    }
40
41
    /**
42
     * Get the installer zip file for the version specified
43
     * NOTE: The purchase key must be passed in the request for verification.
44
     *
45
     * @return mixed Illuminate\Http\Response
46
     *
47
     * @param $version Version to fetch
48
     **/
49
    public function getInstaller($version)
50
    {
51
        $response = $this->verifyPurchase();
0 ignored issues
show
Unused Code introduced by
$response is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
52
        if (null == $this->customer) {
53
            return $this->invalidKeyResponse();
54
        }
55
        $install = $this->repository->config('install.resourcePath') . "/install_{$version}.zip";
56
        if (file_exists($install)) {
57
            return response()->download($install);
58
        }
59
    }
60
}
61