Elgg\Router\Route

Complexity

Total Complexity

15

Size/Duplication

Total Lines	84
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setMatchedParameters()	0	4	1
C	resolvePageOwner()	0	47	13
A	getMatchedParameters()	0	2	1

<?php

namespace Elgg\Router;

/**
 * Route Wrapper
 */
class Route extends \Symfony\Component\Routing\Route {

	/**
	 * @var array
	 */
	protected $parameters = [];

	/**
	 * Set matched parameters
	 *
	 * @param array $parameters Parameters
	 *
	 * @return static
	 * @internal
	 */
	public function setMatchedParameters(array $parameters) {
		$this->parameters = $parameters;

		return $this;
	}

	/**
	 * Get matched parameters
	 *
	 * @return array
	 * @internal
	 */
	public function getMatchedParameters() {
		return $this->parameters;
	}

	/**
	 * Attemps to resolve page owner from route parameters
	 *
	 * @return \ElggEntity|null
	 * @internal
	 */
	public function resolvePageOwner() {

		$params = $this->getMatchedParameters();
		$route = $params['_route'];

		$route_parts = explode(':', $route);

		$from_guid = function ($guid) {
			$entity = get_entity($guid);
			if ($entity instanceof \ElggUser || $entity instanceof \ElggGroup) {
				return $entity;
			} else if ($entity instanceof \ElggObject) {
				return $entity->getContainerEntity();
			}
		};

		switch ($route_parts[0]) {
			case 'view' :
			case 'edit' :
				$username = elgg_extract('username', $params);
				if ($username) {
					return get_user_by_username($username);

The expression return get_user_by_username($username) could also return false which is incompatible with the documented return type null|ElggEntity. Did you maybe forget to handle an error condition?

				}

				$guid = elgg_extract('guid', $params);
				if ($guid) {
					return $from_guid($guid);
				}
				break;

			case 'add' :
			case 'collection' :
				$username = elgg_extract('username', $params);
				if ($username) {
					return get_user_by_username($username);

The expression return get_user_by_username($username) could also return false which is incompatible with the documented return type null|ElggEntity. Did you maybe forget to handle an error condition?

				}

				$guid = elgg_extract('guid', $params);
				if ($guid) {
					return $from_guid($guid);
				}

				$container_guid = elgg_extract('container_guid', $params);
				if ($container_guid) {
					return $from_guid($container_guid);
				}
				break;
		}

	}
}