Completed
Push — master ( fab0a4...8e249d )
by Jeroen
41:43 queued 16:43
created
engine/classes/Elgg/I18n/Translator.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
 	/**
80 80
 	 * Get a map of all loaded translations
81 81
 	 *
82
-	 * @return array
82
+	 * @return string
83 83
 	 */
84 84
 	public function getLoadedTranslations() {
85 85
 		return $this->translations;
@@ -595,7 +595,7 @@  discard block
 block discarded – undo
595 595
 	/**
596 596
 	 * Returns an array of language codes.
597 597
 	 *
598
-	 * @return array
598
+	 * @return string[]
599 599
 	 */
600 600
 	public static function getAllLanguageCodes() {
601 601
 		return [
Please login to merge, or discard this patch.
engine/classes/Elgg/UploadService.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 	 * Returns an array of uploaded file objects regardless of upload status/errors
42 42
 	 *
43 43
 	 * @param string $input_name Form input name
44
-	 * @return UploadedFile[]
44
+	 * @return Http\UploadedFile[]
45 45
 	 */
46 46
 	public function getFiles($input_name) {
47 47
 		$files = $this->request->getFiles($input_name);
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 	 * @param string $input_name Form input name
59 59
 	 * @param bool   $check_for_validity If there is an uploaded file, is it required to be valid
60 60
 	 *
61
-	 * @return UploadedFile[]|false
61
+	 * @return string
62 62
 	 */
63 63
 	public function getFile($input_name, $check_for_validity = true) {
64 64
 		$file = $this->request->getFile($input_name, $check_for_validity);
Please login to merge, or discard this patch.
engine/lib/deprecated-2.3.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
  *
41 41
  * @param string $input_name The name of the file input field on the submission form
42 42
  *
43
- * @return mixed|false The contents of the file, or false on failure.
43
+ * @return false|string The contents of the file, or false on failure.
44 44
  * @deprecated 2.3
45 45
  */
46 46
 function get_uploaded_file($input_name) {
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
  *                           dimensions on all size; the image will be cropped.
95 95
  * @param bool   $upscale    Resize images smaller than $maxwidth x $maxheight?
96 96
  *
97
- * @return false|mixed The contents of the resized image, or false on failure
97
+ * @return false|string The contents of the resized image, or false on failure
98 98
  * @deprecated 2.3
99 99
  */
100 100
 function get_resized_image_from_uploaded_file($input_name, $maxwidth, $maxheight,
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
  * @param int    $y2         y coordinate for bottom, right corner
138 138
  * @param bool   $upscale    Resize images smaller than $maxwidth x $maxheight?
139 139
  *
140
- * @return false|mixed The contents of the resized image, or false on failure
140
+ * @return false|string The contents of the resized image, or false on failure
141 141
  * @deprecated 2.3
142 142
  */
143 143
 function get_resized_image_from_existing_file($input_name, $maxwidth, $maxheight,
Please login to merge, or discard this patch.
engine/classes/Elgg/EntityIconService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -418,7 +418,7 @@
 block discarded – undo
418 418
 	 * @param string     $type          The name of the icon. e.g., 'icon', 'cover_photo'
419 419
 	 * @param bool       $retain_master Keep the master icon (default: false)
420 420
 	 *
421
-	 * @return bool
421
+	 * @return boolean|null
422 422
 	 */
423 423
 	public function deleteIcon(ElggEntity $entity, $type = 'icon', $retain_master = false) {
424 424
 		$delete = $this->hooks->trigger("entity:$type:delete", $entity->getType(), [
Please login to merge, or discard this patch.
engine/classes/Elgg/AttributeLoader.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
 	 * Get primary attributes missing that are missing
130 130
 	 *
131 131
 	 * @param \stdClass $row Database row
132
-	 * @return array
132
+	 * @return boolean
133 133
 	 */
134 134
 	protected function isMissingPrimaries($row) {
135 135
 		return array_diff(self::$primary_attr_names, array_keys($row)) !== [];
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
 	 * Get secondary attributes that are missing
140 140
 	 *
141 141
 	 * @param \stdClass $row Database row
142
-	 * @return array
142
+	 * @return boolean
143 143
 	 */
144 144
 	protected function isMissingSecondaries($row) {
145 145
 		return array_diff($this->secondary_attr_names, array_keys($row)) !== [];
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
 	 * "secondary" attributes (e.g. those in {prefix}users_entity), but can load all at once if a
177 177
 	 * combined loader is available.
178 178
 	 *
179
-	 * @param mixed $row a row loaded from DB (array or \stdClass)
179
+	 * @param \stdClass $row a row loaded from DB (array or \stdClass)
180 180
 	 * @return array will be empty if failed to load all attributes (access control or entity doesn't exist)
181 181
 	 *
182 182
 	 * @throws \InvalidArgumentException|\LogicException|\IncompleteEntityException
Please login to merge, or discard this patch.
engine/classes/ElggPlugin.php 1 patch
Doc Comments   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 	 * Save the plugin object.  Make sure required values exist.
95 95
 	 *
96 96
 	 * @see \ElggObject::save()
97
-	 * @return bool
97
+	 * @return boolean|null
98 98
 	 */
99 99
 	public function save() {
100 100
 		// own by the current site so users can be deleted without affecting plugins
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
 	 * Sets the location of this plugin.
196 196
 	 *
197 197
 	 * @param string $id The path to the plugin's dir.
198
-	 * @return bool
198
+	 * @return string
199 199
 	 */
200 200
 	public function setID($id) {
201 201
 		return $this->title = $id;
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
 	/**
235 235
 	 * Sets the priority of the plugin
236 236
 	 *
237
-	 * @param mixed $priority The priority to set. One of +1, -1, first, last, or a number.
237
+	 * @param string $priority The priority to set. One of +1, -1, first, last, or a number.
238 238
 	 *                        If given a number, this will displace all plugins at that number
239 239
 	 *                        and set their priorities +1
240 240
 	 * @return bool
@@ -403,7 +403,7 @@  discard block
 block discarded – undo
403 403
 	 *
404 404
 	 * @param string $name The setting name to remove
405 405
 	 *
406
-	 * @return bool
406
+	 * @return integer
407 407
 	 */
408 408
 	public function unsetSetting($name) {
409 409
 		return remove_private_setting($this->guid, $name);
@@ -415,7 +415,7 @@  discard block
 block discarded – undo
415 415
 	 * @todo Should be a better way to do this without dropping to raw SQL.
416 416
 	 * @todo If we could namespace the plugin settings this would be cleaner.
417 417
 	 * @todo this shouldn't work because ps_prefix will be empty string
418
-	 * @return bool
418
+	 * @return integer
419 419
 	 */
420 420
 	public function unsetAllSettings() {
421 421
 		_elgg_services()->pluginSettingsCache->clear($this->guid);
@@ -510,7 +510,7 @@  discard block
 block discarded – undo
510 510
 	 * @param string $value     The setting value
511 511
 	 * @param int    $user_guid The user GUID
512 512
 	 *
513
-	 * @return mixed The new setting ID or false
513
+	 * @return boolean The new setting ID or false
514 514
 	 */
515 515
 	public function setUserSetting($name, $value, $user_guid = 0) {
516 516
 		$user_guid = (int) $user_guid;
@@ -582,7 +582,7 @@  discard block
 block discarded – undo
582 582
 	 * @todo fix that
583 583
 	 *
584 584
 	 * @param int $user_guid The user GUID to remove user settings.
585
-	 * @return bool
585
+	 * @return integer
586 586
 	 */
587 587
 	public function unsetAllUserSettings($user_guid) {
588 588
 		$db = $this->getDatabase();
@@ -601,7 +601,7 @@  discard block
 block discarded – undo
601 601
 	 * Use {@link removeAllUserSettings()} if you just want to remove
602 602
 	 * settings for a single user.
603 603
 	 *
604
-	 * @return bool
604
+	 * @return integer
605 605
 	 */
606 606
 	public function unsetAllUsersSettings() {
607 607
 		$db = $this->getDatabase();
@@ -841,7 +841,7 @@  discard block
 block discarded – undo
841 841
 	 * Start the plugin.
842 842
 	 *
843 843
 	 * @param int $flags Start flags for the plugin. See the constants in lib/plugins.php for details.
844
-	 * @return true
844
+	 * @return boolean
845 845
 	 * @throws PluginException
846 846
 	 */
847 847
 	public function start($flags) {
@@ -1094,7 +1094,7 @@  discard block
 block discarded – undo
1094 1094
 	 * Registers the plugin's languages
1095 1095
 	 *
1096 1096
 	 * @throws PluginException
1097
-	 * @return true
1097
+	 * @return boolean
1098 1098
 	 */
1099 1099
 	protected function registerLanguages() {
1100 1100
 		return _elgg_services()->translator->registerPluginTranslations($this->path);
@@ -1104,7 +1104,7 @@  discard block
 block discarded – undo
1104 1104
 	 * Registers the plugin's classes
1105 1105
 	 *
1106 1106
 	 * @throws PluginException
1107
-	 * @return true
1107
+	 * @return boolean
1108 1108
 	 */
1109 1109
 	protected function registerClasses() {
1110 1110
 		$classes_path = "$this->path/classes";
Please login to merge, or discard this patch.