HmacFactory::__construct() - Code Metrics - Inspection of "Merge pull request #10935 from mrclay/fixes6" - Elgg/Elgg - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ec2dfb...bb6a7d )

by Steve

created 2017-04-22 20:34 UTC

HmacFactory::__construct() A

↳ Parent: HmacFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	3
c	1
b	0
f	0
nc	1
nop	2
dl	0
loc	4
ccs	4
cts	4
cp	1
crap	1
rs	10

<?php
namespace Elgg\Security;

use ElggCrypto;
use Elgg\Database\SiteSecret;

/**
 * Provides a factory for HMAC objects
 */
class HmacFactory {

	/**
	 * @var SiteSecret
	 */
	private $site_secret;

	/**
	 * @var ElggCrypto
	 */
	private $crypto;

	/**
	 * Constructor
	 *
	 * @param SiteSecret $secret Site secret
	 * @param ElggCrypto $crypto Elgg crypto service
	 */
	public function __construct(SiteSecret $secret, ElggCrypto $crypto) {
		$this->site_secret = $secret;
		$this->crypto = $crypto;
	}

	/**
	 * Get an HMAC token builder/validator object
	 *
	 * @param mixed  $data HMAC data or serializable data
	 * @param string $algo Hash algorithm
	 * @param string $key  Optional key (default uses site secret)
	 *
	 * @return Hmac
	 */
	public function getHmac($data, $algo = 'sha256', $key = '') {
		if (!$key) {
			$key = $this->site_secret->get(true);
		}
		return new Hmac($key, [$this->crypto, 'areEqual'], $data, $algo);
	}
}


1		<?php
2		namespace Elgg\Security;
3
4		use ElggCrypto;
5		use Elgg\Database\SiteSecret;
6
7		/**
8		* Provides a factory for HMAC objects
9		*/
10		class HmacFactory {
11
12		/**
13		* @var SiteSecret
14		*/
15		private $site_secret;
16
17		/**
18		* @var ElggCrypto
19		*/
20		private $crypto;
21
22		/**
23		* Constructor
24		*
25		* @param SiteSecret $secret Site secret
26		* @param ElggCrypto $crypto Elgg crypto service
27		*/
28	10	public function __construct(SiteSecret $secret, ElggCrypto $crypto) {
29	10	$this->site_secret = $secret;
30	10	$this->crypto = $crypto;
31	10	}
32
33		/**
34		* Get an HMAC token builder/validator object
35		*
36		* @param mixed $data HMAC data or serializable data
37		* @param string $algo Hash algorithm
38		* @param string $key Optional key (default uses site secret)
39		*
40		* @return Hmac
41		*/
42	59	public function getHmac($data, $algo = 'sha256', $key = '') {
43	59	if (!$key) {
44	52	$key = $this->site_secret->get(true);
45		}
46	59	return new Hmac($key, [$this->crypto, 'areEqual'], $data, $algo);
47		}
48		}
49

Elgg / Elgg

Push — master ( ec2dfb...bb6a7d )

HmacFactory::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like