Issues in HttpProtocolTransport.php - All Issues - Inspection of "Merge pull request #12735 from jdalsem/pip-reqs" - Elgg/Elgg - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.x ( 668272...4d1768 )

by Jeroen

created 2019-07-17 12:17 UTC

All Issues
New 0

engine/classes/Elgg/Http/HttpProtocolTransport.php (1 issue)

Labels

Best Practice 1
Bug 1

Severity

Major 1

<?php

namespace Elgg\Http;

use Symfony\Component\HttpFoundation\Response;

/**
 * Transport for sending responses to HTTP clients via HTTP protocol
 *
 * @since 2.3
 * @internal
 */
class HttpProtocolTransport implements ResponseTransport {
	
	/**
	 * {@inheritdoc}
	 *
	 * @return Response
	 */
	public function send(Response $response) {
		return $response->send();
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
	}

}


1			<?php
2
3			namespace Elgg\Http;
4
5			use Symfony\Component\HttpFoundation\Response;
6
7			/**
8			* Transport for sending responses to HTTP clients via HTTP protocol
9			*
10			* @since 2.3
11			* @internal
12			*/
13			class HttpProtocolTransport implements ResponseTransport {
14
15			/**
16			* {@inheritdoc}
17			*
18			* @return Response
19			*/
20			public function send(Response $response) {
21			return $response->send();
			0 ignored issues – show Bug Best Practice introduced 2017-10-16 06:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return $response->send()` returns the type `Symfony\Component\HttpFoundation\Response` which is incompatible with the return type mandated by `Elgg\Http\ResponseTransport::send()` of `boolean`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
22			}
23
24			}
25

Elgg / Elgg

Push — 3.x ( 668272...4d1768 )

engine/classes/Elgg/Http/HttpProtocolTransport.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like