Elgg /
Elgg
| Conditions | 15 |
| Paths | 88 |
| Total Lines | 88 |
| Code Lines | 52 |
| Lines | 10 |
| Ratio | 11.36 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 36 | public function seed() { |
||
| 37 | |||
| 38 | $count_groups = function () { |
||
| 39 | return elgg_get_entities_from_metadata([ |
||
| 40 | 'types' => 'group', |
||
| 41 | 'metadata_names' => '__faker', |
||
| 42 | 'count' => true, |
||
| 43 | ]); |
||
| 44 | }; |
||
| 45 | |||
| 46 | View Code Duplication | $count_members = function ($group) { |
|
|
1 ignored issue
–
show
|
|||
| 47 | return elgg_get_entities_from_relationship([ |
||
| 48 | 'types' => 'user', |
||
| 49 | 'relationship' => 'member', |
||
| 50 | 'relationship_guid' => $group->getGUID(), |
||
| 51 | 'inverse_relationship' => true, |
||
| 52 | 'metadata_names' => '__faker', |
||
| 53 | 'count' => true, |
||
| 54 | ]); |
||
| 55 | }; |
||
| 56 | |||
| 57 | $exclude = []; |
||
| 58 | |||
| 59 | while ($count_groups() < $this->limit) { |
||
| 60 | $group = $this->getRandomGroup($exclude); |
||
| 61 | if (!$group) { |
||
| 62 | $group = $this->createGroup([ |
||
| 63 | 'access_id' => $this->getRandomVisibility(), |
||
| 64 | ], [ |
||
| 65 | 'content_access_mode' => $this->getRandomContentAccessMode(), |
||
| 66 | 'membership' => $this->getRandomMembership(), |
||
| 67 | ]); |
||
| 68 | if (!$group) { |
||
| 69 | continue; |
||
| 70 | } |
||
| 71 | } |
||
| 72 | |||
| 73 | $exclude[] = $group->guid; |
||
| 74 | |||
| 75 | if ($count_members($group) > 1) { |
||
| 76 | // exclude owner from count |
||
| 77 | continue; |
||
| 78 | } |
||
| 79 | |||
| 80 | $members_limit = $this->faker->numberBetween(5, 10); |
||
| 81 | |||
| 82 | $members_exclude = []; |
||
| 83 | |||
| 84 | while ($count_members($group) - 1 < $members_limit) { |
||
| 85 | $member = $this->getRandomUser($members_exclude); |
||
| 86 | if (!$member) { |
||
| 87 | $member = $this->createUser(); |
||
| 88 | if (!$member) { |
||
| 89 | continue; |
||
| 90 | } |
||
| 91 | } |
||
| 92 | |||
| 93 | $members_exclude[] = $member->guid; |
||
| 94 | |||
| 95 | if ($group->join($member)) { |
||
| 96 | $this->log("User $member->name [guid: $member->guid] joined group $group->name [guid: $group->guid]"); |
||
| 97 | } |
||
| 98 | |||
| 99 | if (!$group->isPublicMembership()) { |
||
| 100 | $invitee = $this->getRandomUser($members_exclude); |
||
| 101 | if ($invitee) { |
||
| 102 | $members_exclude[] = $invitee->guid; |
||
| 103 | if (!check_entity_relationship($invitee->guid, 'member', $group->guid)) { |
||
| 104 | add_entity_relationship($group->guid, 'invited', $invitee->guid); |
||
| 105 | $this->log("User $invitee->name [guid: $invitee->guid] was invited to $group->name [guid: $group->guid]"); |
||
| 106 | } |
||
| 107 | } |
||
| 108 | |||
| 109 | $requestor = $this->getRandomUser($members_exclude); |
||
| 110 | if ($requestor) { |
||
| 111 | $members_exclude[] = $requestor->guid; |
||
| 112 | if (!check_entity_relationship($group->guid, 'invited', $requestor->guid) |
||
| 113 | && !check_entity_relationship($requestor->guid, 'member', $group->guid) |
||
| 114 | ) { |
||
| 115 | add_entity_relationship($requestor->guid, 'membership_request', $group->guid); |
||
| 116 | $this->log("User $invitee->name [guid: $invitee->guid] requested to join $group->name [guid: $group->guid]"); |
||
| 117 | } |
||
| 118 | } |
||
| 119 | } |
||
| 120 | } |
||
| 121 | } |
||
| 122 | |||
| 123 | } |
||
| 124 | |||
| 180 |
Loading history...
This check marks private properties in classes that are never used. Those properties can be removed.