Elgg / Elgg

mod/discussions/views/default/resources/discussion/view.php

<?php

$guid = elgg_extract('guid', $vars);

elgg_register_rss_link();

elgg_entity_gatekeeper($guid, 'object', 'discussion');

$topic = get_entity($guid);

$container = $topic->getContainerEntity();

elgg_require_js('elgg/discussion');

elgg_set_page_owner_guid($container->getGUID());

elgg_group_gatekeeper();

if ($container instanceof ElggGroup) {
	$owner_url = "discussion/group/$container->guid";
} else {
	$owner_url = "discussion/owner/$container->guid";
}

elgg_push_breadcrumb($container->getDisplayName(), $owner_url);
elgg_push_breadcrumb($topic->title);

It seems like $topic->title can also be of type array; however, parameter $text of elgg_push_breadcrumb() does only seem to accept string, maybe add an additional type check?

$content = elgg_view_entity($topic, [
	'full_view' => true,
	'show_responses' => true,
]);

$params = [
	'content' => $content,
	'title' => $topic->title,
	'sidebar' => elgg_view('discussion/sidebar'),
	'filter' => '',
];
$body = elgg_view_layout('content', $params);

echo elgg_view_page($topic->title, $body);

It seems like $topic->title can also be of type array; however, parameter $title of elgg_view_page() does only seem to accept string, maybe add an additional type check?