CreateSystemLogTable::change() - Code Metrics - Inspection of "Merge pull request #11121 from mrclay/hypeJunction..." - Elgg/Elgg - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 92ff78...57630a )

by Steve

created 2017-08-07 17:18 UTC

CreateSystemLogTable::change() B

↳ Parent: CreateSystemLogTable

Complexity

Conditions	2
Paths	2

Size

Total Lines	131
Code Lines	82

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	82
nc	2
nop	0
dl	0
loc	131
rs	8.2857
c	0
b	0
f	0

How to fix Long Method

<?php

use Phinx\Migration\AbstractMigration;
use Phinx\Db\Adapter\MysqlAdapter;

class CreateSystemLogTable extends AbstractMigration {
	/**
	 * Change Method.
	 *
	 * Write your reversible migrations using this method.
	 *
	 * More information on writing migrations is available here:
	 * http://docs.phinx.org/en/latest/migrations.html#the-abstractmigration-class
	 *
	 * The following commands can be used in this method and Phinx will
	 * automatically reverse them when rolling back:
	 *
	 *    createTable
	 *    renameTable
	 *    addColumn
	 *    renameColumn
	 *    addIndex
	 *    addForeignKey
	 *
	 * Remember to call "create()" or "update()" and NOT "save()" when working
	 * with the Table class.
	 */
	public function change() {

		if ($this->hasTable("system_log")) {
			return;
		}

		$table = $this->table("system_log", [
			'engine' => "InnoDB",
			'encoding' => "utf8mb4",
			'collation' => "utf8mb4_general_ci",
		]);

		$table->addColumn('object_id', 'integer', [
			'null' => false,
			'limit' => MysqlAdapter::INT_REGULAR,
			'precision' => 10,
		]);

		$table->addColumn('object_class', 'string', [
			'null' => false,
			'limit' => 50,
		]);

		$table->addColumn('object_type', 'string', [
			'null' => false,
			'limit' => 50,
		]);
		
		$table->addColumn('object_subtype', 'string', [
			'null' => false,
			'limit' => 50,
		]);
		
		$table->addColumn('event', 'string', [
			'null' => false,
			'limit' => 50,
		]);
		
		$table->addColumn('performed_by_guid', 'integer', [
			'null' => false,
			'limit' => MysqlAdapter::INT_BIG,
			'precision' => 20,
			'signed' => false,
		]);
		
		$table->addColumn('owner_guid', 'integer', [
			'null' => false,
			'limit' => MysqlAdapter::INT_BIG,
			'precision' => 20,
			'signed' => false,
		]);
		
		$table->addColumn('access_id', 'integer', [
			'null' => false,
			'limit' => MysqlAdapter::INT_REGULAR,
			'precision' => 10,
		]);
		
		$table->addColumn('enabled', 'enum', [
			'null' => false,
			'default' => 'yes',
			'limit' => 3,
			'values' => [
				'yes',
				'no'
			],
		]);
		
		$table->addColumn('time_created', 'integer', [
			'null' => false,
			'limit' => MysqlAdapter::INT_REGULAR,
			'precision' => 10,
		]);
		
		$table->addColumn('ip_address', 'string', [
			'null' => false,
			'limit' => 46,
		]);

		$table->addIndex(['object_id'], [
			'name' => "object_id",
			'unique' => false,
		]);

		$table->addIndex(['object_class'], [
			'name' => "object_class",
			'unique' => false,
		]);

		$table->addIndex(['object_type'], [
			'name' => "object_type",
			'unique' => false,
		]);

		$table->addIndex(['object_subtype'], [
			'name' => "object_subtype",
			'unique' => false,
		]);

		$table->addIndex(['event'], [
			'name' => "event",
			'unique' => false,
		]);

		$table->addIndex(['performed_by_guid'], [
			'name' => "performed_by_guid",
			'unique' => false,
		]);

		$table->addIndex(['access_id'], [
			'name' => "access_id",
			'unique' => false,
		]);

		$table->addIndex(['time_created'], [
			'name' => "time_created",
			'unique' => false,
		]);

		$table->addIndex([
			'object_type',
			'object_subtype',
			'event'
		], [
			'name' => "river_key",
			'unique' => false
		]);
		
		$table->save();
		
	}
}


1			<?php
2
3			use Phinx\Migration\AbstractMigration;
4			use Phinx\Db\Adapter\MysqlAdapter;
5
6			class CreateSystemLogTable extends AbstractMigration {
7			/**
8			* Change Method.
9			*
10			* Write your reversible migrations using this method.
11			*
12			* More information on writing migrations is available here:
13			* http://docs.phinx.org/en/latest/migrations.html#the-abstractmigration-class
14			*
15			* The following commands can be used in this method and Phinx will
16			* automatically reverse them when rolling back:
17			*
18			* createTable
19			* renameTable
20			* addColumn
21			* renameColumn
22			* addIndex
23			* addForeignKey
24			*
25			* Remember to call "create()" or "update()" and NOT "save()" when working
26			* with the Table class.
27			*/
28			public function change() {
29
30			if ($this->hasTable("system_log")) {
31			return;
32			}
33
34			$table = $this->table("system_log", [
35			'engine' => "InnoDB",
36			'encoding' => "utf8mb4",
37			'collation' => "utf8mb4_general_ci",
38			]);
39
40			$table->addColumn('object_id', 'integer', [
41			'null' => false,
42			'limit' => MysqlAdapter::INT_REGULAR,
43			'precision' => 10,
44			]);
45
46			$table->addColumn('object_class', 'string', [
47			'null' => false,
48			'limit' => 50,
49			]);
50
51			$table->addColumn('object_type', 'string', [
52			'null' => false,
53			'limit' => 50,
54			]);
55
56			$table->addColumn('object_subtype', 'string', [
57			'null' => false,
58			'limit' => 50,
59			]);
60
61			$table->addColumn('event', 'string', [
62			'null' => false,
63			'limit' => 50,
64			]);
65
66			$table->addColumn('performed_by_guid', 'integer', [
67			'null' => false,
68			'limit' => MysqlAdapter::INT_BIG,
69			'precision' => 20,
70			'signed' => false,
71			]);
72
73			$table->addColumn('owner_guid', 'integer', [
74			'null' => false,
75			'limit' => MysqlAdapter::INT_BIG,
76			'precision' => 20,
77			'signed' => false,
78			]);
79
80			$table->addColumn('access_id', 'integer', [
81			'null' => false,
82			'limit' => MysqlAdapter::INT_REGULAR,
83			'precision' => 10,
84			]);
85
86			$table->addColumn('enabled', 'enum', [
87			'null' => false,
88			'default' => 'yes',
89			'limit' => 3,
90			'values' => [
91			'yes',
92			'no'
93			],
94			]);
95
96			$table->addColumn('time_created', 'integer', [
97			'null' => false,
98			'limit' => MysqlAdapter::INT_REGULAR,
99			'precision' => 10,
100			]);
101
102			$table->addColumn('ip_address', 'string', [
103			'null' => false,
104			'limit' => 46,
105			]);
106
107			$table->addIndex(['object_id'], [
108			'name' => "object_id",
109			'unique' => false,
110			]);
111
112			$table->addIndex(['object_class'], [
113			'name' => "object_class",
114			'unique' => false,
115			]);
116
117			$table->addIndex(['object_type'], [
118			'name' => "object_type",
119			'unique' => false,
120			]);
121
122			$table->addIndex(['object_subtype'], [
123			'name' => "object_subtype",
124			'unique' => false,
125			]);
126
127			$table->addIndex(['event'], [
128			'name' => "event",
129			'unique' => false,
130			]);
131
132			$table->addIndex(['performed_by_guid'], [
133			'name' => "performed_by_guid",
134			'unique' => false,
135			]);
136
137			$table->addIndex(['access_id'], [
138			'name' => "access_id",
139			'unique' => false,
140			]);
141
142			$table->addIndex(['time_created'], [
143			'name' => "time_created",
144			'unique' => false,
145			]);
146
147			$table->addIndex([
148			'object_type',
149			'object_subtype',
150			'event'
151			], [
152			'name' => "river_key",
153			'unique' => false
154			]);
155
156			$table->save();
157
158			}
159			}
160

Elgg / Elgg

Push — master ( 92ff78...57630a )

CreateSystemLogTable::change() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like