ElfSundae\Laravel\Support\Providers\AppServiceProvider

Complexity

Total Complexity

8

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	boot()	0	4	1
A	setLocaleForCarbon()	0	4	1
A	register()	0	6	1
A	getServiceProviders()	0	14	3
A	modifyCurrentRequest()	0	8	1
A	shouldAddAcceptableJsonType()	0	4	1

<?php

namespace ElfSundae\Laravel\Support\Providers;

use Carbon\Carbon;
use Illuminate\Http\Request;
use ElfSundae\Laravel\Support\Helper;
use Illuminate\Support\ServiceProvider;

class AppServiceProvider extends ServiceProvider
{
    /**
     * Bootstrap any application services.
     *
     * @return void
     */
    public function boot()
    {
        $this->setLocaleForCarbon();
    }

    /**
     * Set locale for Carbon.
     *
     * @return bool
     */
    protected function setLocaleForCarbon()
    {
        return Carbon::setLocale($this->app['config']->get('support.carbon_locale'), $this->app->getLocale());

The call to Carbon::setLocale() has too many arguments starting with $this->app->getLocale().

    }

    /**
     * Register any application services.
     *
     * @return void
     */
    public function register()
    {
        array_map([$this->app, 'register'], $this->getServiceProviders());

        $this->modifyCurrentRequest();
    }

    /**
     * Get service providers to be registered.
     *
     * @return array
     */
    protected function getServiceProviders()
    {
        $providers = [];

        if (is_app('admin') || $this->app->runningInConsole()) {
            array_push(
                $providers,
                \ElfSundae\Laravel\Datatables\DatatablesServiceProvider::class,
                \Rap2hpoutre\LaravelLogViewer\LaravelLogViewerServiceProvider::class
            );
        }

        return $providers;
    }

    /**
     * Modify the current request.
     *
     * @return void
     */
    protected function modifyCurrentRequest()
    {
        Helper::addAcceptableJsonType(
            function (Request $request) {
                return $this->shouldAddAcceptableJsonType($request);
            }
        );
    }

    /**
     * Determines appending JSON type to the "Accept" header for the current request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return bool
     */
    protected function shouldAddAcceptableJsonType(Request $request)

The parameter $request is not used and could be removed.

    {
        return is_app('api');
    }
}