ElfSundae\Laravel\Support\Exceptions\Handler

Complexity

Total Complexity

30

Size/Duplication

Total Lines	202
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	report()	0	20	4
A	getRequestInfo()	0	16	2
A	render()	0	10	3
A	renderForMaintenanceMode()	0	8	3
A	unauthenticated()	0	8	2
A	convertValidationExceptionToResponse()	0	10	2
B	renderHttpException()	0	23	6
A	convertExceptionToResponse()	0	8	3
A	convertExceptionToApiResponse()	0	6	2
A	createApiResponse()	0	14	3

<?php

namespace ElfSundae\Support\Exceptions;

use Exception;
use Psr\Log\LoggerInterface;
use ElfSundae\Laravel\Api\ApiResponse;
use Illuminate\Auth\AuthenticationException;
use Illuminate\Validation\ValidationException;
use Symfony\Component\HttpKernel\Exception\HttpException;
use ElfSundae\Laravel\Api\Exceptions\ApiResponseException;
use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
use Illuminate\Foundation\Http\Exceptions\MaintenanceModeException;

class Handler extends ExceptionHandler
{
    /**
     * Report or log an exception.
     *
     * This is a great spot to send exceptions to Sentry, Bugsnag, etc.
     *
     * @param  \Exception  $e
     * @return void
     */
    public function report(Exception $e)
    {
        if ($this->shouldntReport($e)) {
            return;
        }

        try {
            $logger = $this->container->make(LoggerInterface::class);
        } catch (Exception $ex) {
            throw $e; // throw the original exception
        }

        $requestInfo = $this->getRequestInfo();

        $logger->error($e, $requestInfo);

        if (method_exists($this, 'notify')) {
            $this->notify($e, $requestInfo);

The method notify() does not seem to exist on object<ElfSundae\Support\Exceptions\Handler>.

        }
    }

    /**
     * Get the request info.
     *
     * @return array
     */
    protected function getRequestInfo()
    {
        $request = $this->container->make('request');

        $info = [
            'IP' => $request->ips(),
            'UserAgent' => $request->server('HTTP_USER_AGENT'),
            'URL' => $request->fullUrl(),
        ];

        if ($this->container->runningInConsole()) {
            $info['Command'] = implode(' ', $request->server('argv', []));
        }

        return $info;
    }

    /**
     * Render an exception into an HTTP response.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Exception  $e
     * @return \Illuminate\Http\Response
     */
    public function render($request, Exception $e)
    {
        if ($e instanceof MaintenanceModeException) {
            return $this->renderForMaintenanceMode($request, $e);
        } elseif ($e instanceof ApiResponseException) {

The class ElfSundae\Laravel\Api\Exceptions\ApiResponseException does not exist. Did you forget a USE statement, or did you not list all dependencies?

            return $e->getResponse();
        }

        return parent::render($request, $e);
    }

    /**
     * Render for MaintenanceModeException.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Illuminate\Foundation\Http\Exceptions\MaintenanceModeException  $e
     * @return \Illuminate\Http\Response
     */
    protected function renderForMaintenanceMode($request, MaintenanceModeException $e)
    {
        if ($request->expectsJson()) {
            return $this->createApiResponse($e->getMessage() ?: '服务器维护中，请稍后重试。', 503, $e);
        }

        return $this->toIlluminateResponse($this->renderHttpException($e), $e);
    }

    /**
     * Convert an authentication exception into an unauthenticated response.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Illuminate\Auth\AuthenticationException  $e
     * @return \Illuminate\Http\Response
     */
    protected function unauthenticated($request, AuthenticationException $e)
    {
        if ($request->expectsJson()) {
            return $this->createApiResponse('认证失败，请先登录。', 401, $e);
        }

        return redirect()->guest('login');
    }

    /**
     * Create a response object from the given validation exception.
     *
     * @param  \Illuminate\Validation\ValidationException  $e
     * @param  \Illuminate\Http\Request  $request
     * @return \Symfony\Component\HttpFoundation\Response
     */
    protected function convertValidationExceptionToResponse(ValidationException $e, $request)
    {
        if ($request->expectsJson()) {
            $message = implode("\n", array_flatten($e->validator->errors()->getMessages()));

            return $this->createApiResponse($message, 422, $e);
        }

        return parent::convertValidationExceptionToResponse($e, $request);
    }

    /**
     * Render the given HttpException.
     *
     * @param  \Symfony\Component\HttpKernel\Exception\HttpException  $e
     * @return \Symfony\Component\HttpFoundation\Response
     */
    protected function renderHttpException(HttpException $e)
    {
        if ($this->container->make('request')->expectsJson()) {
            $status = $e->getStatusCode();
            $message = $e->getMessage();

            if (empty($message)) {
                if (401 === $status) {
                    $message = '认证失败，请先登录';
                } elseif (403 === $status) {
                    $message = '无权操作，拒绝访问';
                } elseif (404 === $status) {
                    $message = '404 Not Found';
                } else {
                    $message = 'Error '.$status;
                }
            }

            return $this->createApiResponse($message, $status, $e);
        }

        return parent::renderHttpException($e);
    }

    /**
     * Create a Symfony response for the given exception.
     *
     * @param  \Exception  $e
     * @return \Symfony\Component\HttpFoundation\Response
     */
    protected function convertExceptionToResponse(Exception $e)
    {
        if (request()->expectsJson() && ! $this->container->make('config')->get('app.debug')) {
            return $this->convertExceptionToApiResponse($e);
        }

        return parent::convertExceptionToResponse($e);
    }

    /**
     * Create an API response for the given exception.
     *
     * @param  \Exception  $e
     * @return \ElfSundae\Laravel\Api\ApiResponse
     */
    protected function convertExceptionToApiResponse(Exception $e)
    {
        $code = $this->isHttpException($e) ? $e->getStatusCode() : $e->getCode();

It seems like you code against a specific sub-type and not the parent class Exception as the method getStatusCode() does only exist in the following sub-classes of Exception: Illuminate\Foundation\Http\Exceptions\MaintenanceModeException, Illuminate\Http\Exceptions\PostTooLargeException, Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException, Symfony\Component\HttpKernel\Exception\BadRequestHttpException, Symfony\Component\HttpKernel\Exception\ConflictHttpException, Symfony\Component\HttpKernel\Exception\GoneHttpException, Symfony\Component\HttpKernel\Exception\HttpException, Symfony\Component\HttpKernel\Exception\LengthRequiredHttpException, Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException, Symfony\Component\HttpKernel\Exception\NotAcceptableHttpException, Symfony\Component\HttpKernel\Exception\NotFoundHttpException, Symfony\Component\HttpKernel\Exception\PreconditionFailedHttpException, Symfony\Component\HttpKernel\Exception\PreconditionRequiredHttpException, Symfony\Component\HttpKernel\Exception\ServiceUnavailableHttpException, Symfony\Component\HttpKernel\Exception\TooManyRequestsHttpException, Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException, Symfony\Component\HttpKernel\Exception\UnprocessableEntityHttpException, Symfony\Component\HttpKernel\Exception\UnsupportedMediaTypeHttpException. Maybe you want to instanceof check for one of these explicitly?

        return $this->createApiResponse($e->getMessage(), $code, $e);
    }

    /**
     * Create an API response.
     *
     * @param  mixed  $message
     * @param  int  $code
     * @param  \Exception  $e
     * @return \ElfSundae\Laravel\Api\ApiResponse
     */
    protected function createApiResponse($message, $code, Exception $e)
    {
        $response = new ApiResponse($message, $code);

        if ($response->getCode() === $response::successCode()) {
            $response->setCode(-1 * $response->getCode());
        }

        if (empty($response->getMessage())) {
            $response->setMessage('Error #'.$response->getCode());
        }

        return $response->withException($e);
    }
}