Complex classes like HttpClient often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use HttpClient, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 13 | class HttpClient |
||
| 14 | { |
||
| 15 | /** |
||
| 16 | * The default request options. |
||
| 17 | * |
||
| 18 | * @var array |
||
| 19 | */ |
||
| 20 | protected static $defaultOptions = [ |
||
| 21 | 'connect_timeout' => 5, |
||
| 22 | 'timeout' => 30, |
||
| 23 | ]; |
||
| 24 | |||
| 25 | /** |
||
| 26 | * The Guzzle client. |
||
| 27 | * |
||
| 28 | * @var \GuzzleHttp\Client |
||
| 29 | */ |
||
| 30 | protected $client; |
||
| 31 | |||
| 32 | /** |
||
| 33 | * The request options. |
||
| 34 | * |
||
| 35 | * @var array |
||
| 36 | */ |
||
| 37 | protected $options = []; |
||
| 38 | |||
| 39 | /** |
||
| 40 | * The Guzzle response. |
||
| 41 | * |
||
| 42 | * @var \GuzzleHttp\Psr7\Response |
||
| 43 | */ |
||
| 44 | protected $response; |
||
| 45 | |||
| 46 | /** |
||
| 47 | * Indicate whether to catch Guzzle exceptions. |
||
| 48 | * |
||
| 49 | * @var bool |
||
| 50 | */ |
||
| 51 | protected $catchExceptions = true; |
||
| 52 | |||
| 53 | /** |
||
| 54 | * Get the default request options. |
||
| 55 | * |
||
| 56 | * @return array |
||
| 57 | */ |
||
| 58 | 23 | public static function defaultOptions() |
|
| 62 | |||
| 63 | /** |
||
| 64 | * Set the default request options. |
||
| 65 | * |
||
| 66 | * @param array $options |
||
| 67 | * @return void |
||
| 68 | */ |
||
| 69 | 24 | public static function setDefaultOptions(array $options) |
|
| 73 | |||
| 74 | /** |
||
| 75 | * Create a http client instance. |
||
| 76 | * |
||
| 77 | * @param array|string|\Psr\Http\Message\UriInterface $options base URI or any request options |
||
| 78 | * |
||
| 79 | * @throws \InvalidArgumentException |
||
| 80 | */ |
||
| 81 | 23 | public function __construct($options = []) |
|
| 82 | { |
||
| 83 | 23 | if (is_string($options) || $options instanceof UriInterface) { |
|
| 84 | 1 | $options = ['base_uri' => $options]; |
|
| 85 | 23 | } elseif (! is_array($options)) { |
|
| 86 | 1 | throw new InvalidArgumentException('Options must be a string, UriInterface, or an array'); |
|
| 87 | } |
||
| 88 | |||
| 89 | 22 | $this->client = new Client( |
|
| 90 | 22 | array_replace_recursive(static::defaultOptions(), $options) |
|
| 91 | 22 | ); |
|
| 92 | |||
| 93 | 22 | $this->options = $this->client->getConfig(); |
|
|
|
|||
| 94 | 22 | } |
|
| 95 | |||
| 96 | /** |
||
| 97 | * Get the Guzzle client instance. |
||
| 98 | * |
||
| 99 | * @return \GuzzleHttp\Client |
||
| 100 | */ |
||
| 101 | 4 | public function getClient() |
|
| 105 | |||
| 106 | /** |
||
| 107 | * Get whether to catch Guzzle exceptions or not. |
||
| 108 | * |
||
| 109 | * @return bool |
||
| 110 | */ |
||
| 111 | 1 | public function areExceptionsCaught() |
|
| 115 | |||
| 116 | /** |
||
| 117 | * Set whether to catch Guzzle exceptions or not. |
||
| 118 | * |
||
| 119 | * @param bool $catch |
||
| 120 | * @return $this |
||
| 121 | */ |
||
| 122 | 2 | public function catchExceptions($catch) |
|
| 128 | |||
| 129 | /** |
||
| 130 | * Get the request options using "dot" notation. |
||
| 131 | * |
||
| 132 | * @param string|null $key |
||
| 133 | * @return mixed |
||
| 134 | */ |
||
| 135 | 10 | public function getOption($key = null) |
|
| 139 | |||
| 140 | /** |
||
| 141 | * Set the request options using "dot" notation. |
||
| 142 | * |
||
| 143 | * @param string|array $key |
||
| 144 | * @param mixed $value |
||
| 145 | * @return $this |
||
| 146 | */ |
||
| 147 | 7 | public function option($key, $value = null) |
|
| 157 | |||
| 158 | /** |
||
| 159 | * Merge the given options to the request options. |
||
| 160 | * |
||
| 161 | * @param array ...$options |
||
| 162 | * @return $this |
||
| 163 | */ |
||
| 164 | 1 | public function mergeOption(array ...$options) |
|
| 170 | |||
| 171 | /** |
||
| 172 | * Remove one or many request options using "dot" notation. |
||
| 173 | * |
||
| 174 | * @param array|string $keys |
||
| 175 | * @return $this |
||
| 176 | */ |
||
| 177 | 2 | public function removeOption($keys) |
|
| 183 | |||
| 184 | /** |
||
| 185 | * Set a request header. |
||
| 186 | * |
||
| 187 | * @param string $name |
||
| 188 | * @param mixed $value |
||
| 189 | * @return $this |
||
| 190 | */ |
||
| 191 | 5 | public function header($name, $value) |
|
| 195 | |||
| 196 | /** |
||
| 197 | * Set the request content type. |
||
| 198 | * |
||
| 199 | * @param string $type |
||
| 200 | * @return $this |
||
| 201 | */ |
||
| 202 | 1 | public function contentType($type) |
|
| 206 | |||
| 207 | /** |
||
| 208 | * Set the request accept type. |
||
| 209 | * |
||
| 210 | * @param string $type |
||
| 211 | * @return $this |
||
| 212 | */ |
||
| 213 | 3 | public function accept($type) |
|
| 217 | |||
| 218 | /** |
||
| 219 | * Set the request accept type to "application/json". |
||
| 220 | * |
||
| 221 | * @return $this |
||
| 222 | */ |
||
| 223 | 1 | public function acceptJson() |
|
| 227 | |||
| 228 | /** |
||
| 229 | * Specify where the body of the response will be saved. |
||
| 230 | * Set the "sink" option. |
||
| 231 | * |
||
| 232 | * @param mixed $dest |
||
| 233 | * @return $this |
||
| 234 | */ |
||
| 235 | 1 | public function saveTo($dest) |
|
| 239 | |||
| 240 | /** |
||
| 241 | * Get the Guzzle response instance. |
||
| 242 | * |
||
| 243 | * @return \GuzzleHttp\Psr7\Response|null |
||
| 244 | */ |
||
| 245 | 3 | public function getResponse() |
|
| 249 | |||
| 250 | /** |
||
| 251 | * Get data from the response. |
||
| 252 | * |
||
| 253 | * @param string|\Closure $callback |
||
| 254 | * @param array $parameters |
||
| 255 | * @param mixed $default |
||
| 256 | * @return mixed |
||
| 257 | */ |
||
| 258 | 5 | protected function getResponseData($callback, array $parameters = [], $default = null) |
|
| 268 | |||
| 269 | /** |
||
| 270 | * Get the response content. |
||
| 271 | * |
||
| 272 | * @return string |
||
| 273 | */ |
||
| 274 | 4 | public function getContent() |
|
| 278 | |||
| 279 | /** |
||
| 280 | * Get the JSON-decoded response content. |
||
| 281 | * |
||
| 282 | * @param bool $assoc |
||
| 283 | * @return mixed |
||
| 284 | */ |
||
| 285 | 2 | public function getJsonContent($assoc = true) |
|
| 289 | |||
| 290 | /** |
||
| 291 | * Make request to a URI. |
||
| 292 | * |
||
| 293 | * @param string $uri |
||
| 294 | * @param string $method |
||
| 295 | * @param array $options |
||
| 296 | * @return $this |
||
| 297 | */ |
||
| 298 | 9 | public function request($uri = '', $method = 'GET', array $options = []) |
|
| 315 | |||
| 316 | /** |
||
| 317 | * Make request to a URI, expecting JSON content. |
||
| 318 | * |
||
| 319 | * @param string $uri |
||
| 320 | * @param string $method |
||
| 321 | * @param array $options |
||
| 322 | * @return $this |
||
| 323 | */ |
||
| 324 | 3 | public function requestJson($uri = '', $method = 'GET', array $options = []) |
|
| 332 | |||
| 333 | /** |
||
| 334 | * Add JSON type to the "Accept" header for the request options. |
||
| 335 | * |
||
| 336 | * @param array $options |
||
| 337 | * @return array |
||
| 338 | */ |
||
| 339 | 3 | protected function addAcceptableJsonType(array $options) |
|
| 350 | |||
| 351 | /** |
||
| 352 | * Request the URI and return the response content. |
||
| 353 | * |
||
| 354 | * @param string $uri |
||
| 355 | * @param string $method |
||
| 356 | * @param array $options |
||
| 357 | * @return string |
||
| 358 | */ |
||
| 359 | 1 | public function fetchContent($uri = '', $method = 'GET', array $options = []) |
|
| 363 | |||
| 364 | /** |
||
| 365 | * Request the URI and return the JSON-decoded response content. |
||
| 366 | * |
||
| 367 | * @param string $uri |
||
| 368 | * @param string $method |
||
| 369 | * @param array $options |
||
| 370 | * @return mixed |
||
| 371 | */ |
||
| 372 | 1 | public function fetchJson($uri = '', $method = 'GET', array $options = []) |
|
| 376 | |||
| 377 | /** |
||
| 378 | * Get all allowed magic request methods. |
||
| 379 | * |
||
| 380 | * @return array |
||
| 381 | */ |
||
| 382 | 6 | protected function getMagicRequestMethods() |
|
| 388 | |||
| 389 | /** |
||
| 390 | * Get all allowed magic response methods. |
||
| 391 | * |
||
| 392 | * @return array |
||
| 393 | */ |
||
| 394 | 5 | protected function getMagicResponseMethods() |
|
| 401 | |||
| 402 | /** |
||
| 403 | * Determine if the given method is a magic request method. |
||
| 404 | * |
||
| 405 | * @param string $method |
||
| 406 | * @param string &$requestMethod |
||
| 407 | * @param string &$httpMethod |
||
| 408 | * @return bool |
||
| 409 | */ |
||
| 410 | 6 | protected function isMagicRequest($method, &$requestMethod, &$httpMethod) |
|
| 428 | |||
| 429 | /** |
||
| 430 | * Get parameters for $this->request() from the magic request methods. |
||
| 431 | * |
||
| 432 | * @param string $httpMethod |
||
| 433 | * @param array $parameters |
||
| 434 | * @return array |
||
| 435 | */ |
||
| 436 | 1 | protected function getRequestParameters($httpMethod, array $parameters) |
|
| 446 | |||
| 447 | /** |
||
| 448 | * Handle magic method to send request, get response data, or set |
||
| 449 | * request options. |
||
| 450 | * |
||
| 451 | * @param string $method |
||
| 452 | * @param array $parameters |
||
| 453 | * @return mixed |
||
| 454 | */ |
||
| 455 | 6 | public function __call($method, $parameters) |
|
| 469 | } |
||
| 470 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..