Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 7 | class ApiTokenKeyGenerate extends Command |
||
| 8 | { |
||
| 9 | /** |
||
| 10 | * The name and signature of the console command. |
||
| 11 | * |
||
| 12 | * @var string |
||
| 13 | */ |
||
| 14 | protected $signature = 'api:token-key {--show : Display the key instead of modifying files}'; |
||
| 15 | |||
| 16 | /** |
||
| 17 | * The console command description. |
||
| 18 | * |
||
| 19 | * @var string |
||
| 20 | */ |
||
| 21 | protected $description = 'Set the api token key'; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * Execute the console command. |
||
| 25 | * |
||
| 26 | * @return mixed |
||
| 27 | */ |
||
| 28 | View Code Duplication | public function handle() |
|
| 42 | |||
| 43 | /** |
||
| 44 | * Generate a random key for the api token. |
||
| 45 | * |
||
| 46 | * @return string |
||
| 47 | */ |
||
| 48 | protected function generateRandomKey() |
||
| 52 | |||
| 53 | /** |
||
| 54 | * Set the api token key in the environment file. |
||
| 55 | * |
||
| 56 | * @param string $key |
||
| 57 | */ |
||
| 58 | protected function setKeyInEnvironmentFile($key) |
||
| 72 | } |
||
| 73 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.