FluentArrayAccess::offsetGet() - Code Metrics - Inspection of "Add FluentArrayAccess trait" - ElfSundae/holly - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4718fd...669f8f )

by Elf

created 2016-12-06 01:02 UTC

FluentArrayAccess::offsetGet() A

↳ Parent: FluentArrayAccess

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	4
ccs	0
cts	2
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

namespace App\Support\Traits;

trait FluentArrayAccess
{
    /**
     * Determine if the given offset exists.
     *
     * @param  string  $offset
     * @return bool
     */
    public function offsetExists($offset)
    {
        return isset($this->attributes[$offset]);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Get the value for a given offset.
     *
     * @param  string  $offset
     * @return mixed
     */
    public function offsetGet($offset)
    {
        return $this->get($offset);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the value at the given offset.
     *
     * @param  string  $offset
     * @param  mixed   $value
     * @return void
     */
    public function offsetSet($offset, $value)
    {
        $this->attributes[$offset] = $value;
    }

    /**
     * Unset the value at the given offset.
     *
     * @param  string  $offset
     * @return void
     */
    public function offsetUnset($offset)
    {
        unset($this->attributes[$offset]);
    }
}


1			<?php
2
3			namespace App\Support\Traits;
4
5			trait FluentArrayAccess
6			{
7			/**
8			* Determine if the given offset exists.
9			*
10			* @param string $offset
11			* @return bool
12			*/
13			public function offsetExists($offset)
14			{
15			return isset($this->attributes[$offset]);
			1 ignored issue – show Bug introduced 2016-12-06 01:07 UTC by Report Bug Copy Issue Report The property `attributes` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
16			}
17
18			/**
19			* Get the value for a given offset.
20			*
21			* @param string $offset
22			* @return mixed
23			*/
24			public function offsetGet($offset)
25			{
26			return $this->get($offset);
			0 ignored issues – show Bug introduced 2016-12-06 01:07 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27			}
28
29			/**
30			* Set the value at the given offset.
31			*
32			* @param string $offset
33			* @param mixed $value
34			* @return void
35			*/
36			public function offsetSet($offset, $value)
37			{
38			$this->attributes[$offset] = $value;
39			}
40
41			/**
42			* Unset the value at the given offset.
43			*
44			* @param string $offset
45			* @return void
46			*/
47			public function offsetUnset($offset)
48			{
49			unset($this->attributes[$offset]);
50			}
51			}
52

ElfSundae / holly

Push — master ( 4718fd...669f8f )

FluentArrayAccess::offsetGet() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like