Complex classes like Message often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Message, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
7 | class Message implements JsonSerializable |
||
8 | { |
||
9 | /** |
||
10 | * The BearyChat client for sending message. |
||
11 | * |
||
12 | * @var \ElfSundae\BearyChat\Client |
||
13 | */ |
||
14 | protected $client; |
||
15 | |||
16 | /** |
||
17 | * The text to be sent with the message. |
||
18 | * |
||
19 | * @var string |
||
20 | */ |
||
21 | protected $text; |
||
22 | |||
23 | /** |
||
24 | * The notification for the text. |
||
25 | * |
||
26 | * @var string |
||
27 | */ |
||
28 | protected $notification; |
||
29 | |||
30 | /** |
||
31 | * Indicates the text field should be parsed as markdown syntax. |
||
32 | * |
||
33 | * @var bool |
||
34 | */ |
||
35 | protected $markdown; |
||
36 | |||
37 | /** |
||
38 | * The channel that the message should be sent to. |
||
39 | * |
||
40 | * @var string |
||
41 | */ |
||
42 | protected $channel; |
||
43 | |||
44 | /** |
||
45 | * The user that the message should be sent to. |
||
46 | * |
||
47 | * @var string |
||
48 | */ |
||
49 | protected $user; |
||
50 | |||
51 | /** |
||
52 | * The attachments to be sent. |
||
53 | * |
||
54 | * @var array |
||
55 | */ |
||
56 | protected $attachments = []; |
||
57 | |||
58 | /** |
||
59 | * The default values for each attachment. |
||
60 | * |
||
61 | * @var array |
||
62 | */ |
||
63 | protected $attachmentDefaults = []; |
||
64 | |||
65 | /** |
||
66 | * Create a new message. |
||
67 | * |
||
68 | * @param \ElfSundae\BearyChat\Client|null $client |
||
69 | */ |
||
70 | 23 | public function __construct(Client $client = null) |
|
71 | { |
||
72 | 23 | if ($this->client = $client) { |
|
73 | 5 | $this->configureDefaults($client->getMessageDefaults(), true); |
|
74 | } |
||
75 | 23 | } |
|
76 | |||
77 | /** |
||
78 | * Get the BearyChat client for sending message. |
||
79 | * |
||
80 | * @return \ElfSundae\BearyChat\Client |
||
81 | */ |
||
82 | 2 | public function getClient() |
|
83 | { |
||
84 | 2 | return $this->client; |
|
85 | } |
||
86 | |||
87 | /** |
||
88 | * Get the text. |
||
89 | * |
||
90 | * @return string |
||
91 | */ |
||
92 | 8 | public function getText() |
|
96 | |||
97 | /** |
||
98 | * Set the text. |
||
99 | * |
||
100 | * @param string $text |
||
101 | * @return $this |
||
102 | */ |
||
103 | 7 | public function setText($text) |
|
109 | |||
110 | /** |
||
111 | * Set the text. |
||
112 | * |
||
113 | * @param string $text |
||
114 | * @return $this |
||
115 | */ |
||
116 | 4 | public function text($text) |
|
120 | |||
121 | /** |
||
122 | * Get the notification. |
||
123 | * |
||
124 | * @return string |
||
125 | */ |
||
126 | 8 | public function getNotification() |
|
130 | |||
131 | /** |
||
132 | * Set the notification. |
||
133 | * |
||
134 | * @param string $notification |
||
135 | * @return $this |
||
136 | */ |
||
137 | 5 | public function setNotification($notification) |
|
143 | |||
144 | /** |
||
145 | * Set the notification. |
||
146 | * |
||
147 | * @param string $notification |
||
148 | * @return $this |
||
149 | */ |
||
150 | 1 | public function notification($notification) |
|
154 | |||
155 | /** |
||
156 | * Get the markdown. |
||
157 | * |
||
158 | * @return bool |
||
159 | */ |
||
160 | 8 | public function getMarkdown() |
|
164 | |||
165 | /** |
||
166 | * Set the markdown. |
||
167 | * |
||
168 | * @param bool $markdown |
||
169 | * @return $this |
||
170 | */ |
||
171 | 4 | public function setMarkdown($markdown) |
|
177 | |||
178 | /** |
||
179 | * Set the markdown. |
||
180 | * |
||
181 | * @param bool $markdown |
||
182 | * @return $this |
||
183 | */ |
||
184 | 1 | public function markdown($markdown = true) |
|
188 | |||
189 | /** |
||
190 | * Get the channel which the message should be sent to. |
||
191 | * |
||
192 | * @return string |
||
193 | */ |
||
194 | 11 | public function getChannel() |
|
198 | |||
199 | /** |
||
200 | * Set the channel which the message should be sent to. |
||
201 | * |
||
202 | * @param string $channel |
||
203 | * @return $this |
||
204 | */ |
||
205 | 6 | public function setChannel($channel) |
|
206 | { |
||
207 | 6 | $this->removeTarget(); |
|
208 | |||
209 | 6 | if ($channel) { |
|
210 | 6 | $this->channel = (string) $channel; |
|
211 | } |
||
212 | |||
213 | 6 | return $this; |
|
214 | } |
||
215 | |||
216 | /** |
||
217 | * Set the channel which the message should be sent to. |
||
218 | * |
||
219 | * @param string $channel |
||
220 | * @return $this |
||
221 | */ |
||
222 | 4 | public function channel($channel) |
|
226 | |||
227 | /** |
||
228 | * Get the user which the message should be sent to. |
||
229 | * |
||
230 | * @return string |
||
231 | */ |
||
232 | 11 | public function getUser() |
|
236 | |||
237 | /** |
||
238 | * Set the user which the message should be sent to. |
||
239 | * |
||
240 | * @param string $user |
||
241 | * @return $this |
||
242 | */ |
||
243 | 10 | public function setUser($user) |
|
244 | { |
||
245 | 10 | $this->removeTarget(); |
|
246 | |||
247 | 10 | if ($user) { |
|
248 | 10 | $this->user = (string) $user; |
|
249 | } |
||
250 | |||
251 | 10 | return $this; |
|
252 | } |
||
253 | |||
254 | /** |
||
255 | * Set the user which the message should be sent to. |
||
256 | * |
||
257 | * @param string $user |
||
258 | * @return $this |
||
259 | */ |
||
260 | 4 | public function user($user) |
|
264 | |||
265 | /** |
||
266 | * Get the target that the message should be sent to: |
||
267 | * `#channel` or `@user` or null. |
||
268 | * |
||
269 | * @return string |
||
270 | */ |
||
271 | 4 | public function getTarget() |
|
281 | |||
282 | /** |
||
283 | * Set the target (user or channel) that the message should be sent to. |
||
284 | * |
||
285 | * @param string $target @user, #channel, channel, null |
||
286 | * @return $this |
||
287 | */ |
||
288 | 3 | public function setTarget($target) |
|
289 | { |
||
290 | 3 | $this->removeTarget(); |
|
291 | |||
292 | 3 | if ($target = (string) $target) { |
|
293 | 3 | $mark = mb_substr($target, 0, 1); |
|
294 | 3 | $to = mb_substr($target, 1); |
|
295 | |||
296 | 3 | if ($mark === '@') { |
|
297 | 3 | $this->setUser($to); |
|
298 | 2 | } elseif ($mark === '#') { |
|
299 | 1 | $this->setChannel($to); |
|
300 | } else { |
||
301 | 2 | $this->setChannel($target); |
|
302 | } |
||
303 | } |
||
304 | |||
305 | 3 | return $this; |
|
306 | } |
||
307 | |||
308 | /** |
||
309 | * Remove the target, then this message will be sent to |
||
310 | * the webhook defined target. |
||
311 | * |
||
312 | * @return $this |
||
313 | */ |
||
314 | 10 | public function removeTarget() |
|
320 | |||
321 | /** |
||
322 | * Set the target. |
||
323 | * |
||
324 | * @param string $target |
||
325 | * @return $this |
||
326 | */ |
||
327 | 1 | public function target($target) |
|
331 | |||
332 | /** |
||
333 | * Set the target. |
||
334 | * |
||
335 | * @param string $target |
||
336 | * @return $this |
||
337 | */ |
||
338 | 3 | public function to($target) |
|
342 | |||
343 | /** |
||
344 | * Get the attachments defaults. |
||
345 | * |
||
346 | * @return array |
||
347 | */ |
||
348 | 1 | public function getAttachmentDefaults() |
|
352 | |||
353 | /** |
||
354 | * Set the attachments defaults. |
||
355 | * |
||
356 | * @param array $defaults |
||
357 | * @return $this |
||
358 | */ |
||
359 | 8 | public function setAttachmentDefaults($defaults) |
|
369 | |||
370 | /** |
||
371 | * Get the attachments for the message. |
||
372 | * |
||
373 | * @return array |
||
374 | */ |
||
375 | 11 | public function getAttachments() |
|
379 | |||
380 | /** |
||
381 | * Set the attachments for the message. |
||
382 | * |
||
383 | * @param mixed $attachments |
||
384 | * @return $this |
||
385 | */ |
||
386 | 6 | public function setAttachments($attachments) |
|
398 | |||
399 | /** |
||
400 | * Set the attachments for the message. |
||
401 | * |
||
402 | * @param mixed $attachments |
||
403 | * @return $this |
||
404 | */ |
||
405 | 1 | public function attachments($attachments) |
|
409 | |||
410 | /** |
||
411 | * Add an attachment to the message. |
||
412 | * |
||
413 | * The parameter can be an payload array that contains all of attachment's fields. |
||
414 | * The parameters can also be attachment's fields that in order of |
||
415 | * text, title, images and color. Except the text, other parameters |
||
416 | * can be ignored. |
||
417 | * |
||
418 | * @param mixed $attachment |
||
419 | * @return $this |
||
420 | */ |
||
421 | 10 | public function addAttachment($attachment) |
|
440 | |||
441 | /** |
||
442 | * Get payload for an attachment. |
||
443 | * |
||
444 | * @param mixed $text |
||
445 | * @param mixed $title |
||
446 | * @param mixed $images |
||
447 | * @param mixed $color |
||
448 | * @return array |
||
449 | */ |
||
450 | 9 | protected function getAttachmentPayload($text = null, $title = null, $images = null, $color = null) |
|
472 | |||
473 | /** |
||
474 | * Get payload for images. |
||
475 | * |
||
476 | * @param mixed $value |
||
477 | * @return array |
||
478 | */ |
||
479 | 9 | protected function getImagesPayload($value) |
|
495 | |||
496 | /** |
||
497 | * Convert any type to string. |
||
498 | * |
||
499 | * @param mixed $value |
||
500 | * @param int $jsonOptions |
||
501 | * @return string |
||
502 | */ |
||
503 | 9 | protected function stringValue($value, $jsonOptions = JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES) |
|
519 | |||
520 | /** |
||
521 | * Add an attachment to the message. |
||
522 | * It alias to `addAttachment`. |
||
523 | * |
||
524 | * @return $this |
||
525 | */ |
||
526 | 6 | public function add() |
|
530 | |||
531 | /** |
||
532 | * Add an image attachment to the message. |
||
533 | * |
||
534 | * @param string|string[] $image |
||
535 | * @param string $desc |
||
536 | * @param string $title |
||
537 | * @return $this |
||
538 | */ |
||
539 | 1 | public function addImage($image, $desc = null, $title = null) |
|
543 | |||
544 | /** |
||
545 | * Remove attachment[s] for the message. |
||
546 | * |
||
547 | * @return $this |
||
548 | */ |
||
549 | 7 | public function removeAttachments() |
|
565 | |||
566 | /** |
||
567 | * Remove attachment[s] for the message. |
||
568 | * It alias to `removeAttachments`. |
||
569 | * |
||
570 | * @return $this |
||
571 | */ |
||
572 | 1 | public function remove() |
|
576 | |||
577 | /** |
||
578 | * Configure message defaults. |
||
579 | * |
||
580 | * @param array $defaults |
||
581 | * @param bool $force |
||
582 | * @return $this |
||
583 | */ |
||
584 | 6 | public function configureDefaults(array $defaults, $force = false) |
|
606 | |||
607 | /** |
||
608 | * Fill with message defaults. |
||
609 | * |
||
610 | * @param string $key |
||
611 | * @param mixed $value |
||
612 | * @return void |
||
613 | */ |
||
614 | 3 | protected function fillDefaults($key, $value) |
|
635 | |||
636 | /** |
||
637 | * Convert a string to studly caps case. |
||
638 | * |
||
639 | * @param string $string |
||
640 | * @return string |
||
641 | */ |
||
642 | 3 | protected function studlyCase($string) |
|
646 | |||
647 | /** |
||
648 | * Conveniently set message content. |
||
649 | * |
||
650 | * The parameters may be: |
||
651 | * `($text, $markdown, $notification)` |
||
652 | * or `($text, $attachment_text, $attachment_title, $attachment_images, $attachment_color)`. |
||
653 | * |
||
654 | * @return $this |
||
655 | */ |
||
656 | 3 | public function content() |
|
679 | |||
680 | /** |
||
681 | * Convert the message to an array. |
||
682 | * |
||
683 | * @return array |
||
684 | */ |
||
685 | 7 | public function toArray() |
|
706 | |||
707 | /** |
||
708 | * Convert the message to JSON string. |
||
709 | * |
||
710 | * @param int $options |
||
711 | * @return string |
||
712 | */ |
||
713 | 1 | public function toJson($options = 0) |
|
717 | |||
718 | /** |
||
719 | * Serializes the object to a value that can be serialized natively by json_encode(). |
||
720 | * |
||
721 | * @return array |
||
722 | */ |
||
723 | 1 | public function jsonSerialize() |
|
727 | |||
728 | /** |
||
729 | * Send the message. |
||
730 | * |
||
731 | * The parameters accepts the same format of `content` method. |
||
732 | * |
||
733 | * @return bool |
||
734 | */ |
||
735 | 2 | public function send() |
|
754 | |||
755 | /** |
||
756 | * Send the message to the given target. |
||
757 | * |
||
758 | * @param mixed $target |
||
759 | * @return bool |
||
760 | */ |
||
761 | 1 | public function sendTo($target) |
|
767 | |||
768 | /** |
||
769 | * Convert the message to its string representation. |
||
770 | * |
||
771 | * @return string |
||
772 | */ |
||
773 | 1 | public function __toString() |
|
777 | } |
||
778 |