ControllerActionRouteHandler - Code Metrics - ElementsFramework/DynamicRouting - Measure and Improve Code Quality continuously with Scrutinizer

ControllerActionRouteHandler A
last analyzed 2017-08-26 14:25 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
dl	0
loc	28
c	0
b	0
f	0
wmc	3
lcom	0
cbo	0
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	process()	0	4	1
A	isValid()	0	8	2

<?php


namespace ElementsFramework\DynamicRouting\Handler;


use ElementsFramework\DynamicRouting\Model\DynamicRoute;
use Illuminate\Http\Request;
use Illuminate\Http\Response;
use Illuminate\Support\Facades\App;

class ControllerActionRouteHandler implements AbstractRouteTypeHandler
{

    /**
     * Uses the user input and the route definition to build and return a response for the user.
     * @param Request $request
     * @param DynamicRoute $route
     * @return Response
     */
    public function process(Request $request, DynamicRoute $route)
    {
        return App::call($route->configuration['target']);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Checks if the given route object is a valid route that can be handled with this handler.
     * @param DynamicRoute $route
     * @return boolean
     */
    public static function isValid(DynamicRoute $route)
    {
        if(isset($route->configuration['target']) === false) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return false;
        }

        return true;
    }
}

1			<?php
2
3
4			namespace ElementsFramework\DynamicRouting\Handler;
5
6
7			use ElementsFramework\DynamicRouting\Model\DynamicRoute;
8			use Illuminate\Http\Request;
9			use Illuminate\Http\Response;
10			use Illuminate\Support\Facades\App;
11
12			class ControllerActionRouteHandler implements AbstractRouteTypeHandler
13			{
14
15			/**
16			* Uses the user input and the route definition to build and return a response for the user.
17			* @param Request $request
18			* @param DynamicRoute $route
19			* @return Response
20			*/
21			public function process(Request $request, DynamicRoute $route)
22			{
23			return App::call($route->configuration['target']);
			0 ignored issues – show Documentation introduced 2016-09-19 14:35 UTC by Report Bug Copy Issue Report The property `configuration` does not exist on `object<ElementsFramework...ing\Model\DynamicRoute>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
24			}
25
26			/**
27			* Checks if the given route object is a valid route that can be handled with this handler.
28			* @param DynamicRoute $route
29			* @return boolean
30			*/
31			public static function isValid(DynamicRoute $route)
32			{
33			if(isset($route->configuration['target']) === false) {
			0 ignored issues – show Documentation introduced 2016-09-19 14:35 UTC by Report Bug Copy Issue Report The property `configuration` does not exist on `object<ElementsFramework...ing\Model\DynamicRoute>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
34			return false;
35			}
36
37			return true;
38			}
39			}

ElementsFramework / DynamicRouting

ControllerActionRouteHandler A last analyzed 2017-08-26 14:25 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

ControllerActionRouteHandler A
last analyzed 2017-08-26 14:25 UTC