CreatorController::add() - Code Metrics - Elbar/InvestMe - Measure and Improve Code Quality continuously with Scrutinizer

CreatorController::add() B
last analyzed 2016-05-23 13:40 UTC

↳ Parent: CreatorController

Complexity

Conditions	2
Paths	2

Size

Total Lines	24
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	2

Metric	Value
c	2
b	0
f	2
dl	0
loc	24
rs	8.9713
cc	2
eloc	18
nc	2
nop	1

<?php

namespace App\Http\Controllers;

use App\User;
use Illuminate\Http\Request;
use App\Creator;
use App\Http\Requests;
use Illuminate\Support\Facades\Auth;
use Validator;
use Illuminate\Support\Facades\DB;

class CreatorController extends Controller
{
    //
    public function index()
    {
        if (Auth::user()->isCreator == null)
            return view('creators.form');
        return redirect('/');
    }
    public function create()
    {

    }
    public function add(Request $request)
    {
        $validator = Validator::make($request->all(), [
            'postcode' => 'required|integer',
            'country' => 'required',
            'address' => 'required',
        ]);

        if ($validator->fails()) {
            return redirect('/creator')
                ->withInput()
                ->withErrors($validator);
        }
        $id = Auth::user()->id;
        $creator = new Creator();
        $creator->postcode = $request->postcode;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $creator->country = $request->country;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $creator->home_address = $request->address;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $creator->user_id = $id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $creator->save();
        DB::update('update users set isCreator = 1 where id = ?', [$id]);

        return redirect('/new');
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use App\User;
6			use Illuminate\Http\Request;
7			use App\Creator;
8			use App\Http\Requests;
9			use Illuminate\Support\Facades\Auth;
10			use Validator;
11			use Illuminate\Support\Facades\DB;
12
13			class CreatorController extends Controller
14			{
15			//
16			public function index()
17			{
18			if (Auth::user()->isCreator == null)
19			return view('creators.form');
20			return redirect('/');
21			}
22			public function create()
23			{
24
25			}
26			public function add(Request $request)
27			{
28			$validator = Validator::make($request->all(), [
29			'postcode' => 'required\|integer',
30			'country' => 'required',
31			'address' => 'required',
32			]);
33
34			if ($validator->fails()) {
35			return redirect('/creator')
36			->withInput()
37			->withErrors($validator);
38			}
39			$id = Auth::user()->id;
40			$creator = new Creator();
41			$creator->postcode = $request->postcode;
			0 ignored issues – show Documentation introduced 2016-05-19 05:29 UTC by Report Bug Copy Issue Report The property `postcode` does not exist on `object<App\Creator>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
42			$creator->country = $request->country;
			0 ignored issues – show Documentation introduced 2016-05-19 05:29 UTC by Report Bug Copy Issue Report The property `country` does not exist on `object<App\Creator>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
43			$creator->home_address = $request->address;
			0 ignored issues – show Documentation introduced 2016-05-19 05:29 UTC by Report Bug Copy Issue Report The property `home_address` does not exist on `object<App\Creator>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
44			$creator->user_id = $id;
			0 ignored issues – show Documentation introduced 2016-05-19 05:29 UTC by Report Bug Copy Issue Report The property `user_id` does not exist on `object<App\Creator>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
45			$creator->save();
46			DB::update('update users set isCreator = 1 where id = ?', [$id]);
47
48			return redirect('/new');
49			}
50			}
51

Elbar / InvestMe

CreatorController::add() B last analyzed 2016-05-23 13:40 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

CreatorController::add() B
last analyzed 2016-05-23 13:40 UTC