App\Http\Controllers\AdminCreatorController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	90
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	3
Bugs	0	Features	1

7 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	5	1
A	create()	0	4	1
A	store()	0	4	1
A	show()	0	4	1
A	edit()	0	6	1
A	update()	0	10	1
A	destroy()	0	7	1

<?php


namespace App\Http\Controllers;


use Illuminate\Http\Request;


use App\Http\Requests;

use App\Creator;

use Illuminate\Support\Facades\Session;


class AdminCreatorController extends Controller

{

    /**

     * Display a listing of the resource.

     *

     * @return \Illuminate\Http\Response

     */

    public function index()

    {

      $creators = Creator::all();

        return view('Admin.creators.index',compact('creators'));

    }


    /**

     * Show the form for creating a new resource.

     *

     * @return \Illuminate\Http\Response

     */

    public function create()

    {

        //

    }


    /**

     * Store a newly created resource in storage.

     *

     * @param  \Illuminate\Http\Request  $request

     * @return \Illuminate\Http\Response

     */

    public function store(Request $request)

The parameter $request is not used and could be removed.

    {

        //

    }


    /**

     * Display the specified resource.

     *

     * @param  int  $id

     * @return \Illuminate\Http\Response

     */

    public function show($id)

The parameter $id is not used and could be removed.

    {

        //

    }


    /**

     * Show the form for editing the specified resource.

     *

     * @param  int  $id

     * @return \Illuminate\Http\Response

     */

    public function edit($id)

    {

      $creator = Creator::find($id);

      $creators = Creator::all();

        return view('Admin.creators.edit',compact('creator','creators'));

    }


    /**

     * Update the specified resource in storage.

     *

     * @param  \Illuminate\Http\Request  $request

     * @param  int  $id

     * @return \Illuminate\Http\Response

     */

    public function update(Request $request, $id)

    {

        Creator::updateOrCreate(['id'=>$id],[

The method updateOrCreate() does not exist on App\Creator. Did you maybe mean create()?

            'postcode' => $request['postcode'],

            'country' => $request['country'],

            'home_address' => $request['home_address'],

        ]);

        Session::flash('message','Successfully updated');

        return redirect(url('creators'));

It seems like url('creators') targeting url() can also be of type object<Illuminate\Contracts\Routing\UrlGenerator>; however, redirect() does only seem to accept string|null, maybe add an additional type check?

    }


    /**

     * Remove the specified resource from storage.

     *

     * @param  int  $id

     * @return \Illuminate\Http\Response

     */

    public function destroy($id)

    {

       Creator::destroy($id);


        Session::flash('message','Successfully deleted');

        return redirect(url('creators'));

It seems like url('creators') targeting url() can also be of type object<Illuminate\Contracts\Routing\UrlGenerator>; however, redirect() does only seem to accept string|null, maybe add an additional type check?

    }

}