ElaoEnumExtension::load() - Code Metrics - Inspection of "Add the Symfony bundle" - Elao/PhpEnums - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#75)

by Maxime

created 2020-02-13 15:20 UTC

ElaoEnumExtension::load() A

↳ Parent: ElaoEnumExtension

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.7666
c	0
b	0
f	0
cc	3
nc	4
nop	2

<?php

/*
 * This file is part of the "elao/enum" package.
 *
 * Copyright (C) Elao
 *
 * @author Elao <[email protected]>
 */

namespace Elao\Enum\Bridge\Symfony\Bundle\DependencyInjection;

use Elao\Enum\Bridge\Symfony\HttpKernel\Controller\ArgumentResolver\EnumValueResolver;
use Elao\Enum\Bridge\Symfony\Serializer\Normalizer\EnumNormalizer;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
use Symfony\Component\HttpKernel\DependencyInjection\Extension;

class ElaoEnumExtension extends Extension
{
    public function load(array $configs, ContainerBuilder $container)
    {
        $loader = new XmlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
        $loader->load('services.xml');

        $config = $this->processConfiguration($this->getConfiguration($configs, $container), $configs);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        if (!$this->isConfigEnabled($container, $config['argument_value_resolver'])) {
            $container->removeDefinition(EnumValueResolver::class);
        }

        if (!$this->isConfigEnabled($container, $config['serializer'])) {
            $container->removeDefinition(EnumNormalizer::class);
        }
    }

    public function getNamespace()
    {
        return 'http://elao.com/schema/dic/elao_enum';
    }

    public function getXsdValidationBasePath()
    {
        return __DIR__ . '/../Resources/config/schema';
    }
}


1			<?php
2
3			/*
4			* This file is part of the "elao/enum" package.
5			*
6			* Copyright (C) Elao
7			*
8			* @author Elao <[email protected]>
9			*/
10
11			namespace Elao\Enum\Bridge\Symfony\Bundle\DependencyInjection;
12
13			use Elao\Enum\Bridge\Symfony\HttpKernel\Controller\ArgumentResolver\EnumValueResolver;
14			use Elao\Enum\Bridge\Symfony\Serializer\Normalizer\EnumNormalizer;
15			use Symfony\Component\Config\FileLocator;
16			use Symfony\Component\DependencyInjection\ContainerBuilder;
17			use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
18			use Symfony\Component\HttpKernel\DependencyInjection\Extension;
19
20			class ElaoEnumExtension extends Extension
21			{
22			public function load(array $configs, ContainerBuilder $container)
23			{
24			$loader = new XmlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
25			$loader->load('services.xml');
26
27			$config = $this->processConfiguration($this->getConfiguration($configs, $container), $configs);
			0 ignored issues – show Documentation introduced 2020-02-13 15:21 UTC by Report Bug Copy Issue Report `$this->getConfiguration($configs, $container)` is of type `null\|object`, but the function expects a `object<Symfony\Component...ConfigurationInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
28
29			if (!$this->isConfigEnabled($container, $config['argument_value_resolver'])) {
30			$container->removeDefinition(EnumValueResolver::class);
31			}
32
33			if (!$this->isConfigEnabled($container, $config['serializer'])) {
34			$container->removeDefinition(EnumNormalizer::class);
35			}
36			}
37
38			public function getNamespace()
39			{
40			return 'http://elao.com/schema/dic/elao_enum';
41			}
42
43			public function getXsdValidationBasePath()
44			{
45			return __DIR__ . '/../Resources/config/schema';
46			}
47			}
48

Elao / PhpEnums

Pull Request — master (#75)

ElaoEnumExtension::load() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like