ActionCollection::has() - Code Metrics - Inspection of "Create Action abstraction" - Edwin-Luijten/shopify-client - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — develop ( 1bc728...a00b17 )

by Edwin

created 2017-10-16 09:25 UTC

ActionCollection::has() A

↳ Parent: ActionCollection

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	4
cts	4
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	1
crap	2

<?php

namespace ShopifyClient\Action;

use ShopifyClient\Exception\ClientException;

class ActionCollection {
    /**
     * @var array
     */
    private $items = [];

    /**
     * @param $name
     * @param ActionInterface $action
     */
    public function add($name, ActionInterface $action) {
        $this->items[$name] = $action;
    }

    /**
     * @param $name
     * @return ActionInterface
     * @throws ClientException
     */
    public function get($name): ActionInterface {
        if (!$this->has($name)) {
            throw new ClientException(sprintf('%s action does not exist.', $name));
        }

        return $this->items[$name];
    }

    /**
     * @param $name
     * @return bool
     */
    public function has($name): bool {
        if (!isset($this->items[$name])) {
            return false;
        }

        return true;
    }
}

1		<?php
2
3		namespace ShopifyClient\Action;
4
5		use ShopifyClient\Exception\ClientException;
6
7		class ActionCollection {
8		/**
9		* @var array
10		*/
11		private $items = [];
12
13		/**
14		* @param $name
15		* @param ActionInterface $action
16		*/
17	5	public function add($name, ActionInterface $action) {
18	5	$this->items[$name] = $action;
19	5	}
20
21		/**
22		* @param $name
23		* @return ActionInterface
24		* @throws ClientException
25		*/
26	133	public function get($name): ActionInterface {
27	133	if (!$this->has($name)) {
28	3	throw new ClientException(sprintf('%s action does not exist.', $name));
29		}
30
31	130	return $this->items[$name];
32		}
33
34		/**
35		* @param $name
36		* @return bool
37		*/
38	133	public function has($name): bool {
39	133	if (!isset($this->items[$name])) {
40	4	return false;
41		}
42
43	130	return true;
44		}
45		}

Edwin-Luijten / shopify-client

Push — develop ( 1bc728...a00b17 )

ActionCollection::has() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like