Issues in Moves.php (master) - Issues in master - Edwin-Luijten/oauth2-moves - Measure and Improve Code Quality continuously with Scrutinizer

Issues (2)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Provider/Moves.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace League\OAuth2\Client\Provider;

use League\OAuth2\Client\Provider\Exception\IdentityProviderException;
use League\OAuth2\Client\Token\AccessToken;
use Psr\Http\Message\ResponseInterface;

class Moves extends AbstractProvider
{
    /**
     * @var string
     */
    const BASE_MOVES_URL = 'https://moves-app.com';

    /**
     * @var string
     */
    const BASE_MOVES_API_URL = 'https://api.moves-app.com';

    /**
     * @var string
     */
    protected $apiAuthVersion = 'v1';

    /**
     * @var string
     */
    protected $apiVersion = '1.1';

    /**
     * Constructs an OAuth 2.0 service provider.
     *
     * @param array $options An array of options to set on this provider.
     *     Options include `clientId`, `clientSecret`, `redirectUri`, `state`, `apiVersion`.
     *     Individual providers may introduce more options, as needed.
     * @param array $collaborators An array of collaborators that may be used to
     *     override this provider's default behavior. Collaborators include
     *     `grantFactory`, `requestFactory`, `httpClient`, and `randomFactory`.
     *     Individual providers may introduce more collaborators, as needed.
     */
    public function __construct(array $options = [], array $collaborators = [])
    {
        parent::__construct($options, $collaborators);

        foreach ($options as $option => $value) {
            if (property_exists($this, $option)) {
                $this->{$option} = $value;
            }
        }
    }

    /**
     * Get authorization url to begin OAuth flow
     *
     * @return string
     */
    public function getBaseAuthorizationUrl()
    {
        return self::BASE_MOVES_API_URL . '/oauth/' . $this->apiAuthVersion . '/authorize';
    }

    /**
     * Get access token url to retrieve token
     *
     * @param  array $params
     *
     * @return string
     */
    public function getBaseAccessTokenUrl(array $params)
    {
        return self::BASE_MOVES_API_URL . '/oauth/' . $this->apiAuthVersion . '/access_token';
    }

    /**
     * Get provider url to fetch user details
     *
     * @param  AccessToken $token
     *
     * @return string
     */
    public function getResourceOwnerDetailsUrl(AccessToken $token)
    {
        return self::BASE_MOVES_API_URL . '/api/' . $this->apiVersion . '/user/profile?access_token=' . $token;
    }

    /**
     * @link https://dev.moves-app.com/docs/authentication#scopes
     * Get the default scopes used by this provider.
     *
     * This should not be a complete list of all scopes, but the minimum
     * required for the provider user interface!
     *
     * @return array
     */
    protected function getDefaultScopes()
    {
        return ['default'];
    }

    /**
     * Check a provider response for errors.
     *
     * @throws IdentityProviderException
     * @param  ResponseInterface $response
     * @param  string $data Parsed response data
     * @return void
     */
    protected function checkResponse(ResponseInterface $response, $data)
    {
        if (isset($data['error'])) {
            throw new IdentityProviderException(
                $data['error'] ?: $response->getReasonPhrase(),
                $response->getStatusCode(),
                $response
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            );
        }
    }

    /**
     * Generate a user object from a successful user details request.
     *
     * @param array $response
     * @param AccessToken $token
     * @return \League\OAuth2\Client\Provider\ResourceOwnerInterface
     */
    protected function createResourceOwner(array $response, AccessToken $token)
    {
        return new MovesResourceOwner($response);
    }
}


1		<?php
2
3		namespace League\OAuth2\Client\Provider;
4
5		use League\OAuth2\Client\Provider\Exception\IdentityProviderException;
6		use League\OAuth2\Client\Token\AccessToken;
7		use Psr\Http\Message\ResponseInterface;
8
9		class Moves extends AbstractProvider
10		{
11		/**
12		* @var string
13		*/
14		const BASE_MOVES_URL = 'https://moves-app.com';
15
16		/**
17		* @var string
18		*/
19		const BASE_MOVES_API_URL = 'https://api.moves-app.com';
20
21		/**
22		* @var string
23		*/
24		protected $apiAuthVersion = 'v1';
25
26		/**
27		* @var string
28		*/
29		protected $apiVersion = '1.1';
30
31		/**
32		* Constructs an OAuth 2.0 service provider.
33		*
34		* @param array $options An array of options to set on this provider.
35		* Options include `clientId`, `clientSecret`, `redirectUri`, `state`, `apiVersion`.
36		* Individual providers may introduce more options, as needed.
37		* @param array $collaborators An array of collaborators that may be used to
38		* override this provider's default behavior. Collaborators include
39		* `grantFactory`, `requestFactory`, `httpClient`, and `randomFactory`.
40		* Individual providers may introduce more collaborators, as needed.
41		*/
42	24	public function __construct(array $options = [], array $collaborators = [])
43		{
44	24	parent::__construct($options, $collaborators);
45
46	24	foreach ($options as $option => $value) {
47	24	if (property_exists($this, $option)) {
48	24	$this->{$option} = $value;
49	16	}
50	16	}
51	24	}
52
53		/**
54		* Get authorization url to begin OAuth flow
55		*
56		* @return string
57		*/
58	12	public function getBaseAuthorizationUrl()
59		{
60	12	return self::BASE_MOVES_API_URL . '/oauth/' . $this->apiAuthVersion . '/authorize';
61		}
62
63		/**
64		* Get access token url to retrieve token
65		*
66		* @param array $params
67		*
68		* @return string
69		*/
70	15	public function getBaseAccessTokenUrl(array $params)
71		{
72	15	return self::BASE_MOVES_API_URL . '/oauth/' . $this->apiAuthVersion . '/access_token';
73		}
74
75		/**
76		* Get provider url to fetch user details
77		*
78		* @param AccessToken $token
79		*
80		* @return string
81		*/
82	6	public function getResourceOwnerDetailsUrl(AccessToken $token)
83		{
84	6	return self::BASE_MOVES_API_URL . '/api/' . $this->apiVersion . '/user/profile?access_token=' . $token;
85		}
86
87		/**
88		* @link https://dev.moves-app.com/docs/authentication#scopes
89		* Get the default scopes used by this provider.
90		*
91		* This should not be a complete list of all scopes, but the minimum
92		* required for the provider user interface!
93		*
94		* @return array
95		*/
96	6	protected function getDefaultScopes()
97		{
98	6	return ['default'];
99		}
100
101		/**
102		* Check a provider response for errors.
103		*
104		* @throws IdentityProviderException
105		* @param ResponseInterface $response
106		* @param string $data Parsed response data
107		* @return void
108		*/
109	12	protected function checkResponse(ResponseInterface $response, $data)
110		{
111	12	if (isset($data['error'])) {
112	3	throw new IdentityProviderException(
113	3	$data['error'] ?: $response->getReasonPhrase(),
114	3	$response->getStatusCode(),
115	2	$response
		0 ignored issues – show Documentation introduced 2016-02-09 15:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$response` is of type `object<Psr\Http\Message\ResponseInterface>`, but the function expects a `array\|string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
116	2	);
117		}
118	9	}
119
120		/**
121		* Generate a user object from a successful user details request.
122		*
123		* @param array $response
124		* @param AccessToken $token
125		* @return \League\OAuth2\Client\Provider\ResourceOwnerInterface
126		*/
127	3	protected function createResourceOwner(array $response, AccessToken $token)
128		{
129	3	return new MovesResourceOwner($response);
130		}
131		}
132

Edwin-Luijten / oauth2-moves

Issues (2)

Security Analysis no request data

src/Provider/Moves.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like