FuncTpl::func() - Code Metrics - Inspection of "Updated Bonfim View Component" - EdsonOnildoJR/PHP-Template-Engine - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ab7df5...238a89 )

by Edson

created 2018-03-10 00:11 UTC

FuncTpl::func() A

↳ Parent: FuncTpl

Complexity

Conditions	3
Paths	3

Size

Total Lines	9
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	0
cts	9
cp	0
rs	9.6666
c	0
b	0
f	0
cc	3
eloc	7
nc	3
nop	0
crap	12

<?php

namespace Bonfim\Component\View;

class FuncTpl
{
    private $pattern = '/{\s?func ([\w]+)\((.*?)\)\s?}/is';
    private $content;
    private $match;
    private $funcName;
    private $funcArgs;

    public function __construct(string $content)
    {
        $this->content = $content;
        $this->func();
    }

    public function __toString(): string
    {
        return $this->content;
    }

    public function func(): void
    {
        if (preg_match_all($this->pattern, $this->content, $matches, PREG_SET_ORDER)) {
            for ($i = 0; $i < count($matches); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                $this->match = $matches[$i];
                $this->setFuncName();
                $this->setFuncArgs();
                $content = '<?php echo('.$this->funcName.'('.$this->funcArgs.')); ?>';
                $this->content = str_replace($matches[$i][0], $content, $this->content);
            };
        }
    }

    private function setFuncName()
    {
        $this->funcName = $this->match[1];
    }

    private function setFuncArgs()
    {
        $this->funcArgs = $this->match[2];
    }
}


1			<?php
2
3			namespace Bonfim\Component\View;
4
5			class FuncTpl
6			{
7			private $pattern = '/{\s?func ([\w]+)\((.*?)\)\s?}/is';
8			private $content;
9			private $match;
10			private $funcName;
11			private $funcArgs;
12
13			public function __construct(string $content)
14			{
15			$this->content = $content;
16			$this->func();
17			}
18
19			public function __toString(): string
20			{
21			return $this->content;
22			}
23
24			public function func(): void
25			{
26			if (preg_match_all($this->pattern, $this->content, $matches, PREG_SET_ORDER)) {
27			for ($i = 0; $i < count($matches); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2018-03-10 00:13 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
28			$this->match = $matches[$i];
29			$this->setFuncName();
30			$this->setFuncArgs();
31			$content = '<?php echo('.$this->funcName.'('.$this->funcArgs.')); ?>';
32			$this->content = str_replace($matches[$i][0], $content, $this->content);
33			};
34			}
35			}
36
37			private function setFuncName()
38			{
39			$this->funcName = $this->match[1];
40			}
41
42			private function setFuncArgs()
43			{
44			$this->funcArgs = $this->match[2];
45			}
46			}
47

EdsonOnildoJR / PHP-Template-Engine

Push — master ( ab7df5...238a89 )

FuncTpl::func() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like