FuncTag::handle() - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/master'" - EdsonOnildoJR/PHP-Template-Engine - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 67cfc6...1f1489 )

by Edson

created 2018-04-13 04:27 UTC

FuncTag::handle() A

↳ Parent: FuncTag

Complexity

Conditions	3
Paths	3

Size

Total Lines	9
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	7
nc	3
nop	0
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0

<?php

namespace Sketch\Tpl;

class FuncTag extends Tag
filter:
    dependency_paths: ["lib/*"]
{
    private $pattern = '/{\s?func ([\w]+)\((.*?)\)\s?}/is';
    private $match;
    private $funcName;
    private $funcArgs;

    public function handle(): void
    {
        if (preg_match_all($this->pattern, self::$content, $matches, PREG_SET_ORDER)) {
            for ($i = 0; $i < count($matches); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                $this->match = $matches[$i];
                $this->setFuncName();
                $this->setFuncArgs();
                $content = '<?php '.$this->funcName.'('.$this->funcArgs.'); ?>';
                self::$content = str_replace($matches[$i][0], $content, self::$content);

            };
        }
    }

    private function setFuncName()
    {
        $this->funcName = $this->match[1];
    }

    private function setFuncArgs()
    {
        $this->funcArgs = $this->match[2];
    }
}


1			<?php
2
3			namespace Sketch\Tpl;
4
5			class FuncTag extends Tag
			0 ignored issues – show Bug introduced 2018-04-13 04:28 UTC by Report Bug Copy Issue Report The type `Sketch\Tpl\Tag` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
6			{
7			private $pattern = '/{\s?func ([\w]+)\((.*?)\)\s?}/is';
8			private $match;
9			private $funcName;
10			private $funcArgs;
11
12			public function handle(): void
13			{
14			if (preg_match_all($this->pattern, self::$content, $matches, PREG_SET_ORDER)) {
15			for ($i = 0; $i < count($matches); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2018-03-10 00:13 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
16			$this->match = $matches[$i];
17			$this->setFuncName();
18			$this->setFuncArgs();
19			$content = '<?php '.$this->funcName.'('.$this->funcArgs.'); ?>';
20			self::$content = str_replace($matches[$i][0], $content, self::$content);
			0 ignored issues – show Bug Best Practice introduced 2018-04-13 04:28 UTC by Report Bug Copy Issue Report The property `content` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
21			};
22			}
23			}
24
25			private function setFuncName()
26			{
27			$this->funcName = $this->match[1];
28			}
29
30			private function setFuncArgs()
31			{
32			$this->funcArgs = $this->match[2];
33			}
34			}
35

EdsonOnildoJR / PHP-Template-Engine

Push — master ( 67cfc6...1f1489 )

FuncTag::handle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like