Bonfim\Component\View\ElseifView

Complexity

Total Complexity

6

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	elseif()	0	8	3
A	setElseifContent()	0	13	3

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 9 and the first side effect is on line 5.

namespace Bonfim\Component\View;

trait ElseifView

Possible parse error: trait missing opening or closing brace

{
    private $elseif = array();

    private function setElseifContent()
    {
        $pattern = '/{\s?elseif (.*?)\s?([><!=])(=)?(=)?\s?(.*?)\s?}(.*?){end}/is';
        if (preg_match_all($pattern, $this->ifContent, $matches, PREG_SET_ORDER)) {
            for ($i = 0; $i < count($matches); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                $this->ifContent = str_replace($matches[$i][0], '', $this->ifContent);

The property ifContent does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

                $this->elseif[$i]['firstCondition'] = $this->setCondition($matches[$i][1]);

It seems like setCondition() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $this->elseif[$i]['secondCondition'] = $this->setCondition($matches[$i][5]);
                $this->elseif[$i]['operator'] = implode('', array_slice($matches[$i], 2, 3));
                $this->elseif[$i]['content'] = trim($matches[$i][6]);
            }
        }
        $this->ifContent = str_replace('{end}', '', $this->ifContent);
    }

    private function elseif(): void
    {
        if (count($this->elseif) != 0) {
            for ($i = 0; $i < count($this->elseif); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                $this->replace .= "<?php elseif({$this->elseif[$i]['firstCondition']}";

The property replace does not exist on Bonfim\Component\View\ElseifView. Did you maybe forget to declare it?

                $this->replace .= " {$this->elseif[$i]['operator']}";
                $this->replace .= " {$this->elseif[$i]['secondCondition']}): ?>";
                $this->replace .= trim($this->elseif[$i]['content']);
            }
        }
    }
}