Inheritance::replace() - Code Metrics - Inspection of "Added some tests" - EdsonOnildoJR/PHP-Template-Engine - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 238a89...e6faf3 )

by Edson

created 2018-03-10 01:46 UTC

Inheritance::replace() A

↳ Parent: Inheritance

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	5
cts	5
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	0
crap	2

<?php

namespace Bonfim\Component\View;

class Inheritance
{
    use ParseTpl;

    private $blocks = [];
    private $content = '';
    private $patternBlock   = '/{\s?block \'?"?([\w]+)"?\'?\s?}(.*?){\s?\/block\s?}/is';
    private $patternExtends = '/{\s?extends \'?"?(.*?)"?\'?\s?}/is';

    public function __construct(string $content, array $config)
    {
        $this->config = $config;
        $this->content = $content;
        $this->block();
        $this->extends();
    }

    public function __toString(): string
    {
        return $this->content;
    }

    private function block(): void
    {
        if (preg_match_all($this->patternBlock, $this->content, $matches, PREG_SET_ORDER)) {
            for ($i = 0; $i < count($matches); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                $this->blocks[$matches[$i][1]] = $matches[$i][2];
                $this->content = str_replace($this->blocks[$matches[$i][1]], '', $this->content);
            };
        }
    }

    private function extends(): void
    {
        if (preg_match($this->patternExtends, $this->content, $match)) {
            $this->content = $this->getContent($match[1]);
            $this->replace();
        }
    }

    private function replace(): void
    {
        foreach ($this->blocks as $key => $value) {
            $this->content = preg_replace('/{\s?block \'?"?'.$key.'"?\'?\s?}(.*?){\s?\/block\s?}/is', $value, $this->content);
        }

        $this->content = preg_replace('/{\s?block \'?"?[\w]+"?\'?\s?}/is', '', $this->content);
        $this->content = preg_replace('/{\s?\/block\s?}/is', '', $this->content);
    }
}


1		<?php
2
3		namespace Bonfim\Component\View;
4
5		class Inheritance
6		{
7		use ParseTpl;
8
9		private $blocks = [];
10		private $content = '';
11		private $patternBlock = '/{\s?block \'?"?([\w]+)"?\'?\s?}(.*?){\s?\/block\s?}/is';
12		private $patternExtends = '/{\s?extends \'?"?(.*?)"?\'?\s?}/is';
13
14	2	public function __construct(string $content, array $config)
15		{
16	2	$this->config = $config;
17	2	$this->content = $content;
18	2	$this->block();
19	2	$this->extends();
20	2	}
21
22	2	public function __toString(): string
23		{
24	2	return $this->content;
25		}
26
27	2	private function block(): void
28		{
29	2	if (preg_match_all($this->patternBlock, $this->content, $matches, PREG_SET_ORDER)) {
30	2	for ($i = 0; $i < count($matches); $i++) {
		0 ignored issues – show Performance Best Practice introduced 2018-03-10 00:13 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
31	2	$this->blocks[$matches[$i][1]] = $matches[$i][2];
32	2	$this->content = str_replace($this->blocks[$matches[$i][1]], '', $this->content);
33		};
34		}
35	2	}
36
37	2	private function extends(): void
38		{
39	2	if (preg_match($this->patternExtends, $this->content, $match)) {
40	2	$this->content = $this->getContent($match[1]);
41	2	$this->replace();
42		}
43	2	}
44
45	2	private function replace(): void
46		{
47	2	foreach ($this->blocks as $key => $value) {
48	2	$this->content = preg_replace('/{\s?block \'?"?'.$key.'"?\'?\s?}(.*?){\s?\/block\s?}/is', $value, $this->content);
49		}
50
51	2	$this->content = preg_replace('/{\s?block \'?"?[\w]+"?\'?\s?}/is', '', $this->content);
52	2	$this->content = preg_replace('/{\s?\/block\s?}/is', '', $this->content);
53	2	}
54		}
55

EdsonOnildoJR / PHP-Template-Engine

Push — master ( 238a89...e6faf3 )

Inheritance::replace() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like