LoopTag::handle() - Code Metrics - Inspection of "Rename foreach tag to loop tag" - EdsonOnildoJR/PHP-Template-Engine - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#13)

by Edson

created 2018-04-29 17:01 UTC

LoopTag::handle() A

↳ Parent: LoopTag

Complexity

Conditions	3
Paths	3

Size

Total Lines	17
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	12
nc	3
nop	0
dl	0
loc	17
ccs	13
cts	13
cp	1
crap	3
rs	9.4285
c	0
b	0
f	0

<?php

namespace Sketch\Tpl;

/**
 * Class LoopTag
 * @package Sketch\Tpl
 */
class LoopTag extends Tag
{
    /**
     * @var string
     */
    private $pattern = '/{\s?loop (.*?) as ([\w]+)\s?}(.*?){\s?\/loop\s?}/is';
    /**
     * @var string
     */
    private $block = '';
    /**
     * @var string
     */
    private $array = '';
    /**
     * @var string
     */
    private $callback = '';
    /**
     * @var string
     */
    private $foreachContent = '';
    /**
     * @var
     */
    private $match;

    public function handle(): void
    {
        if (preg_match_all($this->pattern, self::$content, $matches, PREG_SET_ORDER)) {
            for ($i = 0; $i < count($matches); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                $this->match = $matches[$i];
                $this->setForeachBlock();
                $this->setForeachArray();
                $this->setForeachCallback();
                $this->setForeachContent();

                $content  = "<?php foreach({$this->array} as {$this->callback}): ?>";
                $content .= $this->foreachContent;
                $content .= "<?php endforeach; ?>";

                self::$content = str_replace($this->block, $content, self::$content);
            };
            new LoopTag();
        }
    }

    private function setForeachBlock() : void
    {
        $this->block = $this->match[0];
    }

    private function setForeachArray() : void
    {
        $explode = explode('.', $this->match[1]);

        $variableArray = '$'.$explode[0];

        for ($i = 1; $i < count($explode); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            $variableArray .= "->".$explode[$i];
        }

        $this->array = $variableArray;
    }

    private function setForeachCallback() : void
    {
        $this->callback = '$'.$this->match[2];
    }

    private function setForeachContent() : void
    {
        $this->foreachContent = trim($this->match[3]);
    }
}


1		<?php
2
3		namespace Sketch\Tpl;
4
5		/**
6		* Class LoopTag
7		* @package Sketch\Tpl
8		*/
9		class LoopTag extends Tag
10		{
11		/**
12		* @var string
13		*/
14		private $pattern = '/{\s?loop (.?) as ([\w]+)\s?}(.?){\s?\/loop\s?}/is';
15		/**
16		* @var string
17		*/
18		private $block = '';
19		/**
20		* @var string
21		*/
22		private $array = '';
23		/**
24		* @var string
25		*/
26		private $callback = '';
27		/**
28		* @var string
29		*/
30		private $foreachContent = '';
31		/**
32		* @var
33		*/
34		private $match;
35
36	4	public function handle(): void
37		{
38	4	if (preg_match_all($this->pattern, self::$content, $matches, PREG_SET_ORDER)) {
39	2	for ($i = 0; $i < count($matches); $i++) {
		0 ignored issues – show Performance Best Practice introduced 2018-03-10 00:13 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
40	2	$this->match = $matches[$i];
41	2	$this->setForeachBlock();
42	2	$this->setForeachArray();
43	2	$this->setForeachCallback();
44	2	$this->setForeachContent();
45
46	2	$content = "<?php foreach({$this->array} as {$this->callback}): ?>";
47	2	$content .= $this->foreachContent;
48	2	$content .= "<?php endforeach; ?>";
49
50	2	self::$content = str_replace($this->block, $content, self::$content);
51		};
52	2	new LoopTag();
53		}
54	4	}
55
56	2	private function setForeachBlock() : void
57		{
58	2	$this->block = $this->match[0];
59	2	}
60
61	2	private function setForeachArray() : void
62		{
63	2	$explode = explode('.', $this->match[1]);
64
65	2	$variableArray = '$'.$explode[0];
66
67	2	for ($i = 1; $i < count($explode); $i++) {
		0 ignored issues – show Performance Best Practice introduced 2018-03-09 11:03 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
68	2	$variableArray .= "->".$explode[$i];
69		}
70
71	2	$this->array = $variableArray;
72	2	}
73
74	2	private function setForeachCallback() : void
75		{
76	2	$this->callback = '$'.$this->match[2];
77	2	}
78
79	2	private function setForeachContent() : void
80		{
81	2	$this->foreachContent = trim($this->match[3]);
82	2	}
83		}
84

EdsonOnildoJR / PHP-Template-Engine

Pull Request — master (#13)

LoopTag::handle() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like