Issues in Fullcalendar.php (master) - Issues in master - Edofre/laravel-fullcalendar - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Fullcalendar.php (2 issues)

Labels

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Edofre\Fullcalendar;

/**
 * Class Fullcalendar
 * @package Edofre\Fullcalendar
 */
class Fullcalendar
{
    /** @var string */
    protected $id = 'fullcalendar';
    /** @var array */
    protected $events = [];
    /** @var array */
    protected $defaultOptions = [
        'header'   => [
            'left'   => 'prev,next today',
            'center' => 'title',
            'right'  => 'month,agendaWeek,agendaDay',
        ],
        'firstDay' => 1,
    ];
    /** @var array */
    protected $clientOptions = [];

    /**
     * Renders the view that includes the script files
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public static function renderScriptFiles()
    {
        return view('fullcalendar::files', [
            'include_gcal' => config('fullcalendar.enable_gcal'),
        ]);
    }

    /**
     * @return string
     */
    public function generate()
    {
        return $this->calendar() . $this->script();
    }

    /**
     * Create the <div> the calendar will be rendered into
     * @return string
     */
    private function calendar()
    {
        return "<div id='" . $this->getId() . "'></div>";
    }

    /**
     * @return string
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * @param $id
     */
    public function setId($id)
    {
        $this->id = $id;
    }

    /**
     * Get the <script> block to render the calendar
     * @return \Illuminate\View\View
     */
    private function script()
    {
        return view('fullcalendar::script', [
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'id'              => $this->getId(),
            'options'         => $this->getOptionsJson(),
            'include_scripts' => config('fullcalendar.include_scripts', true),
            'include_gcal'    => config('fullcalendar.enable_gcal', false),
        ])->render();
    }

    /**
     * @return string
     */
    public function getOptionsJson()
    {
        $options = $this->getOptions();

        if (!isset($options['events'])) {
            $options['events'] = $this->events;
        }

        // Encode the JSON properly to format the callbacks
        return JsonEncoder::encode($options);
    }


    /**
     * Get the fullcalendar options (not including the events list)
     * @return array
     */
    public function getOptions()
    {
        return array_merge($this->defaultOptions, $this->clientOptions);
    }


    /**
     * @param array $options
     */
    public function setOptions(array $options)
    {
        $this->clientOptions = $options;
    }

    /**
     * @return array
     */
    public function getEvents()
    {
        return $this->events;
    }

    /**
     * @param mixed $events
     */
    public function setEvents($events)
    {
        $this->events = $events;

    }
}

1			<?php
2
3			namespace Edofre\Fullcalendar;
4
5			/**
6			* Class Fullcalendar
7			* @package Edofre\Fullcalendar
8			*/
9			class Fullcalendar
10			{
11			/** @var string */
12			protected $id = 'fullcalendar';
13			/** @var array */
14			protected $events = [];
15			/** @var array */
16			protected $defaultOptions = [
17			'header' => [
18			'left' => 'prev,next today',
19			'center' => 'title',
20			'right' => 'month,agendaWeek,agendaDay',
21			],
22			'firstDay' => 1,
23			];
24			/** @var array */
25			protected $clientOptions = [];
26
27			/**
28			* Renders the view that includes the script files
29			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
30			*/
31			public static function renderScriptFiles()
32			{
33			return view('fullcalendar::files', [
34			'include_gcal' => config('fullcalendar.enable_gcal'),
35			]);
36			}
37
38			/**
39			* @return string
40			*/
41			public function generate()
42			{
43			return $this->calendar() . $this->script();
44			}
45
46			/**
47			* Create the <div> the calendar will be rendered into
48			* @return string
49			*/
50			private function calendar()
51			{
52			return "<div id='" . $this->getId() . "'></div>";
53			}
54
55			/**
56			* @return string
57			*/
58			public function getId()
59			{
60			return $this->id;
61			}
62
63			/**
64			* @param $id
65			*/
66			public function setId($id)
67			{
68			$this->id = $id;
69			}
70
71			/**
72			* Get the <script> block to render the calendar
73			* @return \Illuminate\View\View
74			*/
75			private function script()
76			{
77			return view('fullcalendar::script', [
			0 ignored issues – show Bug introduced 2017-06-24 22:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `render` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
78			'id' => $this->getId(),
79			'options' => $this->getOptionsJson(),
80			'include_scripts' => config('fullcalendar.include_scripts', true),
81			'include_gcal' => config('fullcalendar.enable_gcal', false),
82			])->render();
83			}
84
85			/**
86			* @return string
87			*/
88			public function getOptionsJson()
89			{
90			$options = $this->getOptions();
91
92			if (!isset($options['events'])) {
93			$options['events'] = $this->events;
94			}
95
96			// Encode the JSON properly to format the callbacks
97			return JsonEncoder::encode($options);
98			}
99
100
101			/**
102			* Get the fullcalendar options (not including the events list)
103			* @return array
104			*/
105			public function getOptions()
106			{
107			return array_merge($this->defaultOptions, $this->clientOptions);
108			}
109
110
111			/**
112			* @param array $options
113			*/
114			public function setOptions(array $options)
115			{
116			$this->clientOptions = $options;
117			}
118
119			/**
120			* @return array
121			*/
122			public function getEvents()
123			{
124			return $this->events;
125			}
126
127			/**
128			* @param mixed $events
129			*/
130			public function setEvents($events)
131			{
132			$this->events = $events;
			0 ignored issues – show Documentation Bug introduced 2017-08-19 20:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$events` of type `*` is incompatible with the declared type `array` of property `$events`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
133			}
134			}

Edofre / laravel-fullcalendar

Issues (3)

Security Analysis no request data

src/Fullcalendar.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like